Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-05-06 Thread shuai xu
Hi, devs, There haven’t been any further responses to this email over the past few days. I'd like to initiate a vote on the current proposal[1] in the next few days. If there are any concerns about this FLIP-519[1], I will gladly pause and make necessary adjustments. Best, Xu Shuai [1]htt

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-27 Thread shuai xu
Hi Ron, Thank you so much for your feedback and support on this proposal! I really appreciate you taking the time to review it in detail. You're absolutely right about the table's content. When table.exec.async-lookup.key-ordered-enabled=true and table.exec.async-lookup.output-mode=ORDERED,

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-24 Thread Ron Liu
Hi, Shuai Thanks for driving this proposal. The FLIP looks good to me overall, +1 for it. I have a small question about the table's contents. When 'table.exec.async-lookup.key-ordered-enabled=true' and 'table.exec.async-lookup.output-mode=ORDERD', the lookup join in key ordered should be 'yes', n

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-17 Thread shuai xu
Hi Xuyang, Thanks for your response. Actually, ALLOW_UNORDERED is only enabled when facing append-only streams for higher throughput. KEY_ORDERED is designed for scenarios where upsert key exists. Its goal is to achieve higher performance compared to the ORDERED mode while ensuring correct

Re:Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-16 Thread Xuyang
Hi, Shuai. This is a valuable addition to the current AsyncLookupJoin, and I’m generally in favor of it. I have one question. Why do we need to introduce additional parameters to control KEY_ORDERED and ALLOW_UNORDERED? In other words, what scenarios require allowing users to perform co

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-10 Thread shuai xu
Hi all, This FLIP will primarily focus on the implementation within the table module. As for support in the DataStream API, it will be addressed in a separate FLIP. > 2025年4月8日 09:57,shuai xu 写道: > > Hi devs, > > I'd like to start a discussion on FLIP-519: Introduce async lookup key > ordered

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-10 Thread shuai xu
Hi Zakelly, Thank you for your response and for taking responsibility for generalizing the functionality of the 'Asynchronous Execution Model' (AEC). As we discussed earlier, the subsequent work on FLIP will be based on operators that support AEC. If you need any further discussion, please feel

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-09 Thread Zakelly Lan
Hi all, I have also added a 'Follow up' section at the end of the FLIP-425[1] describing this. [1] https://cwiki.apache.org/confluence/x/S4p3EQ Best, Zakelly On Wed, Apr 9, 2025 at 12:42 PM Zakelly Lan wrote: > Thanks for driving this! > > +1 for the FLIP given there is a solid user case beh

Re: [DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-08 Thread Zakelly Lan
Thanks for driving this! +1 for the FLIP given there is a solid user case behind. Shuai and I had a discussion and we agree that `KeyedAsyncWaitOperator` in current FLIP shares similar functionality with the `Asynchronous Execution Model (AEC)` introduced in FLIP-425[1]. We think it is better to

[DISCUSS] FLIP-519: Introduce async lookup key ordered mode

2025-04-07 Thread shuai xu
Hi devs, I'd like to start a discussion on FLIP-519: Introduce async lookup key ordered mode[1]. The Flink system currently supports both record-level ordered and unordered output modes for asynchronous lookup joins. However, it does not guarantee the processing order of records sharing the same