Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread Timo Walther
ingsongLee Send Time:2019年8月15日(星期四) 10:31 To:dev Subject:Re: [DISCUSS] FLIP-51: Rework of the Expression Design Hi jark: I'll add a chapter to list blink planner extended functions. Best, Jingsong Lee -- From:Jark Wu Se

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread JingsongLee
-51: Rework of the Expression Design Hi jark: I'll add a chapter to list blink planner extended functions. Best, Jingsong Lee -- From:Jark Wu Send Time:2019年8月15日(星期四) 05:12 To:dev Subject:Re: [DISCUSS] FLIP-51: Rework o

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread JingsongLee
Hi jark: I'll add a chapter to list blink planner extended functions. Best, Jingsong Lee -- From:Jark Wu Send Time:2019年8月15日(星期四) 05:12 To:dev Subject:Re: [DISCUSS] FLIP-51: Rework of the Expression Design Thanks Jingson

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-14 Thread Jark Wu
Thanks Jingsong for starting the discussion. The general design of the FLIP looks good to me. +1 for the FLIP. It's time to get rid of the old Expression! Regarding to the function behavior, shall we also include new functions from blink planner (e.g. LISTAGG, REGEXP, TO_DATE, etc..) ? Best, Ja

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-14 Thread Timo Walther
Hi Jingsong, thanks for writing down this FLIP. Big +1 from my side to finally get rid of PlannerExpressions and have consistent and well-defined behavior for Table API and SQL updated to FLIP-37. We might need to discuss some of the behavior of particular functions but this should not affec

[DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-13 Thread JingsongLee
Hi everyone, We would like to start a discussion thread on "FLIP-51: Rework of the Expression Design"(Design doc: [1], FLIP: [2]), where we describe how to improve the new java Expressions to work with type inference and convert expression to the calcite RexNode. This is a follow-up plan for FL