Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-03-04 Thread xiangyu feng
; >>>> >> > > >>>> > >>>> >> > > >>>> > >>>> >> > > Best, >>>> > >>>> >> > > Ron >>>> > >>>> >> > > >>>> > >>>> >>

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-24 Thread weijie guo
efer to set the default value of this option >>> as'false in >>> > >>>> the >>> > >>>> >> first >>> > >>>> >> > > > place. Setting as true might introduce unexpected >>> behavior >>> > for >>> > >>>&

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-24 Thread Ron Liu
plementation options >> > and >> > >>>> are >> > >>>> >> they >> > >>>> >> > > > feasible? >> > >>>> >> > > > >> > >>>> >> > > > Yes, we have already imple

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-24 Thread xiangyu feng
; >> > > > > Thank you for proposing this FLIP, it's great work and > > looks > > >>>> very > > >>>> >> > > useful > > >>>> >> > > > > for users. > > >>>&g

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-23 Thread Lincoln Lee
;>> >> and > >>>> >> > > > > should the engine enable this optimization by default. > >>>> Currently > >>>> >> for > >>>> >> > > > source > >>>> >> > > > > reuse, the default value of > >>>>

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-19 Thread xiangyu feng
> > > > think the engine should turn on Sink reuse optimization by >>>> >> default. >>>> >> > > > > 2. Regarding Sink Digest, you mentioned disregarding the sink >>>> >> target >>>> >> > > > &g

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-19 Thread Ron Liu
>> >> > > > can >>> >> > > > > be done. I have a question: have you considered the technical >>> >> > > > > implementation options and are they feasible? >>> >> > > > > >>> >> > > > &

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-19 Thread xiangyu feng
> > > > > Regards, >> >> > > > > > Xiangyu >> >> > > > > > >> >> > > > > > xiangyu feng 于2025年2月11日周二 14:17写道: >> >> > > > > > >> >> > > > &

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-18 Thread Ron Liu
; > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://paimon.apache.org/docs/master/maintenance/write-performance/#local-merging > >> > > > > > > > >> > > > > >

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-18 Thread Cong Cheng
a structure to be processed >> should >> > be >> > > > > > fixed." >> > > > > > >> >> > > > > > >> I'm not very sure why the data structure of SinkWriter >> should be >> > &

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-17 Thread Kevin Cheng
>> I'm not very sure why the data structure of SinkWriter >> should be >> > > > > fixed. >> > > > > > >> Can you elaborate the scenario here? >> > > > > > >> >> > > > > > >> "Is there

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-17 Thread xiangyu feng
By `filling in the inconsistent field from different sources`, > > do > > > > you > > > > > > >> refer to implementations like the LocalMerge Operator [1] for > > > > Paimon? > > > > > > IMHO, > > > > > > >> this should not be incl

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-14 Thread Kevin Cheng
> > >> > > > > > >> Regards, > > > > > >> Xiangyu Feng > > > > > >> > > > > > >> xiangyu feng 于2025年2月11日周二 13:46写道: > > > > > >> > > > > > >>> Hi Yanquan, > > > > > >>> &

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-13 Thread xiangyu feng
ces. If not, a SQL validation exception > > should > > > > be > > > > >>> raised for planner. > > > > >>> > > > > >>> Regards, > > > > >>> Xiangyu Feng > > > > >>> > > > >

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-13 Thread Ron Liu
gt; > be > > > >>> raised for planner. > > > >>> > > > >>> Regards, > > > >>> Xiangyu Feng > > > >>> > > > >>> > > > >>> > > > >>> Yanquan Lv 于2025年2月10日周一 16:25写道: &g

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-12 Thread xiangyu feng
i, Xiangyu. Thanks for driving this. > > >>>> > > >>>> I have a question to confirm: > > >>>> Considering the case that different Sources use different > columns[1], > > >>>> will the Schema of CatalogTable[2] contain all tar

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-12 Thread Ron Liu
rces use different columns[1], > >>>> will the Schema of CatalogTable[2] contain all target columns for > Sources? > >>>> And for SinkWriter, the data structure to be processed should be > fixed. > >>>> Is there a node or a

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-12 Thread xiangyu feng
field of Rowdata >>>> that passed from different Sources? >>>> >>>> [1] >>>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-506%3A+Support+Reuse+Multiple+Table+Sinks+in+Planner >>>> [2] >>>> https://nightlies.apache.org/flink/fl

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-10 Thread xiangyu feng
rg/confluence/display/FLINK/FLIP-506%3A+Support+Reuse+Multiple+Table+Sinks+in+Planner >> [2] >> https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sourcessinks/#planning >> >> >> >> > 2025年2月6日 17:06,xiangyu feng 写道: >> > &g

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-10 Thread xiangyu feng
Sources? >>> >>> [1] >>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-506%3A+Support+Reuse+Multiple+Table+Sinks+in+Planner >>> [2] >>> https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sourcessinks/#planning >>> >>> >>>

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-10 Thread xiangyu feng
nning > > > > > 2025年2月6日 17:06,xiangyu feng 写道: > > > > Hi devs, > > > > I'm opening this thread to discuss FLIP-506: Support Reuse Multiple Table > > Sinks in Planner[1]. > > > > Currently if users want to partial-update a downst

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-10 Thread Yanquan Lv
/sourcessinks/#planning > 2025年2月6日 17:06,xiangyu feng 写道: > > Hi devs, > > I'm opening this thread to discuss FLIP-506: Support Reuse Multiple Table > Sinks in Planner[1]. > > Currently if users want to partial-update a downstream table from multiple > source tables in

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-06 Thread xiangyu feng
ent here, I can't find that in the FLIP. > > Best regards, > > Martijn > > On Thu, Feb 6, 2025 at 10:06 AM xiangyu feng wrote: > > > Hi devs, > > > > I'm opening this thread to discuss FLIP-506: Support Reuse Multiple Table > > Sinks in Planner[

Re: [DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-06 Thread Martijn Visser
Hi Xiangyu Feng, Thanks for the FLIP. Could you elaborate on why Statement Sets aren't sufficient here, I can't find that in the FLIP. Best regards, Martijn On Thu, Feb 6, 2025 at 10:06 AM xiangyu feng wrote: > Hi devs, > > I'm opening this thread to discuss FLIP-506

[DISCUSS] FLIP-506: Support Reuse Multiple Table Sinks in Planner

2025-02-06 Thread xiangyu feng
Hi devs, I'm opening this thread to discuss FLIP-506: Support Reuse Multiple Table Sinks in Planner[1]. Currently if users want to partial-update a downstream table from multiple source tables in one datastream, they would have to manually union all source tables and add lots of "ca