Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-15 Thread Zakelly Lan
Hi everyone, Thanks for all the comments! If there are no objections, I'd like to start a vote after 72 hours. Please let me know if you have any concerns. Thanks! Best, Zakelly On Tue, Jan 16, 2024 at 10:23 AM xiangyu feng wrote: > Hi Zakelly, > > Thanks for driving this. +1 to remove the

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-15 Thread xiangyu feng
Hi Zakelly, Thanks for driving this. +1 to remove the LEGACY mode. This will make the semantic of snapshot ownership more clear. Best regards, Xiangyu Feng Yuan Mei 于2024年1月15日周一 23:16写道： > +1 > > Thanks for driving this Zakelly! > > Best > Yuan > > On Mon, Jan 15, 2024 at 10:47 PM Piotr Nowoj

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-15 Thread Yuan Mei
+1 Thanks for driving this Zakelly! Best Yuan On Mon, Jan 15, 2024 at 10:47 PM Piotr Nowojski wrote: > +1 good idea! > > pon., 15 sty 2024 o 05:11 Jinzhong Li > napisał(a): > > > Hi Zakelly, > > > > Thanks for driving the discussion. It makes sense to remove LEGACY mode > in > > Flink 2.0. >

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-15 Thread Piotr Nowojski
+1 good idea! pon., 15 sty 2024 o 05:11 Jinzhong Li napisał(a): > Hi Zakelly, > > Thanks for driving the discussion. It makes sense to remove LEGACY mode in > Flink 2.0. > > Best, > Jinzhong Li > > On Mon, Jan 15, 2024 at 10:34 AM Xuannan Su wrote: > > > Hi Zakelly, > > > > Thanks for driving

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-14 Thread Jinzhong Li
Hi Zakelly, Thanks for driving the discussion. It makes sense to remove LEGACY mode in Flink 2.0. Best, Jinzhong Li On Mon, Jan 15, 2024 at 10:34 AM Xuannan Su wrote: > Hi Zakelly, > > Thanks for driving this. +1 to removing the LEGACY mode. > > Best regards, > Xuannan > > On Mon, Jan 15, 202

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-14 Thread Xuannan Su
Hi Zakelly, Thanks for driving this. +1 to removing the LEGACY mode. Best regards, Xuannan On Mon, Jan 15, 2024 at 3:22 AM Danny Cranmer wrote: > > +1 to removing LEGACY mode in Flink 2.0. Thanks for driving. > > Danny, > > On Sat, 13 Jan 2024, 08:20 Yanfei Lei, wrote: > > > Thanks Zakelly for

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-14 Thread Hangxiang Yu
Hi, Zakelly. Thanks for the quick feedback and driving this. +1 for removing LEGACY mode in Flink 2.0. On Mon, Jan 15, 2024 at 3:23 AM Danny Cranmer wrote: > +1 to removing LEGACY mode in Flink 2.0. Thanks for driving. > > Danny, > > On Sat, 13 Jan 2024, 08:20 Yanfei Lei, wrote: > > > Thanks Za

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-14 Thread Danny Cranmer
+1 to removing LEGACY mode in Flink 2.0. Thanks for driving. Danny, On Sat, 13 Jan 2024, 08:20 Yanfei Lei, wrote: > Thanks Zakelly for starting this discussion. > > Regardless of whether it is for users or developers, deprecating > RestoreMode#LEGACY makes the semantics clearer and lower mainte

Re: [DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-13 Thread Yanfei Lei
Thanks Zakelly for starting this discussion. Regardless of whether it is for users or developers, deprecating RestoreMode#LEGACY makes the semantics clearer and lower maintenance costs, and Flink 2.0 is a good time point to do this. So +1 for the overall idea. Best, Yanfei Zakelly Lan 于2024年1月1

[DISCUSS] FLIP-416: Deprecate and remove the RestoreMode#LEGACY

2024-01-10 Thread Zakelly Lan
Hi devs, I'd like to start a discussion on FLIP-416: Deprecate and remove the RestoreMode#LEGACY[1]. The FLIP-193[2] introduced two modes of state file ownership during checkpoint restoration: RestoreMode#CLAIM and RestoreMode#NO_CLAIM. The LEGACY mode, which was how Flink worked until 1.15, has