Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-16 Thread Rui Fan
taskmanager.out size periodically. If it's too quick, >> most of >> > > job >> > > > > > > aren't >> > > > > > > > necessary. If it's too slow, the file size cannot be >

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-15 Thread Rui Fan
t; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > To Hangxiang: > > > > > > > > > > > > > > > > > 1. I have a similar concern as Feng. Will we red

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-14 Thread Feng Jin
t; > > > > > > > > > > > Please see my last comment, thanks! > > > > > > > > > > > > > > > taskManager.log contains lots of important information like > > init > > > > log. > > > > >

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-14 Thread Hangxiang Yu
't > > really > > > > > want > > > > > > to log into taskmanager.out, it just happened by accident. > > > > > > So, if users change the System.out to LOG.info, it still happen. > > > > > > > > > > > > >

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-14 Thread Rui Fan
> > > > > > ? It may help us to debug granularly. > > > > > > > > > > I'm not sure what `log the subtask info` means. Let me confirm with > > you > > > > > first. > > > > > Do you mean like this: LOG.info(&

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-14 Thread Hangxiang Yu
gt; > > > > > > Best, > > > > Rui > > > > > > > > On Thu, Nov 9, 2023 at 11:47 AM Hangxiang Yu > > > wrote: > > > > > > > > > Hi, Rui. > > > > > Thanks for the proposal. It sounds reasonable. > > >

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-10 Thread Piotr Nowojski
and error here. > > > > 2. Since we have redirected to LOG mode, Could we also log the > subtask > > > info > > > > ? It may help us to debug granularly. > > > > > > > > On Thu, Nov 9, 2023 at 9:47 AM F

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-09 Thread Rui Fan
gt; Hi, Rui. > > > > > > > > Thank you for initiating this proposal. > > > > > > > > I have a question regarding redirecting stdout and stderr to LOG: > > > > > > > > Will they be written to the taskManager.log file by default or

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-09 Thread Piotr Nowojski
> > for users to use this feature? > > > > > > Best, > > > Feng > > > > > > On Thu, Nov 9, 2023 at 3:15 AM Archit Goyal > > > > > > wrote: > > > > > > > Hi Rui, > > > >

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Rui Fan
Thanks for the proposal. > > > > > > The proposed solution of supporting System out and err to be redirected > > to > > > LOG or discarded and introducing an enum and two options to manage > this, > > > seems reasonable. > > > > > > +1

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Hangxiang Yu
asonable. > > > > +1 > > > > Thanks, > > Archit Goyal > > > > > > From: Piotr Nowojski > > Date: Wednesday, November 8, 2023 at 7:38 AM > > To: dev@flink.apache.org > > Subject: Re: [DISCUSS] FLIP-390: Support System o

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Feng Jin
ms reasonable. > > +1 > > Thanks, > Archit Goyal > > > From: Piotr Nowojski > Date: Wednesday, November 8, 2023 at 7:38 AM > To: dev@flink.apache.org > Subject: Re: [DISCUSS] FLIP-390: Support System out and err to be > redirected to LOG or discarded > Hi Rui

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Archit Goyal
To: dev@flink.apache.org Subject: Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded Hi Rui, Thanks for the proposal. +1 I don't have any major comments :) One nit. In `SystemOutRedirectToLog` in this code: System.arraycopy(buf,

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Piotr Nowojski
Hi Rui, Thanks for the proposal. +1 I don't have any major comments :) One nit. In `SystemOutRedirectToLog` in this code: System.arraycopy(buf, count - LINE_SEPARATOR_LENGTH, bytes, 0, LINE_SEPARATOR_LENGTH); return Arrays.equals(LINE_SEPARATOR_BYTES, bytes) Is there a r

[DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Rui Fan
Hi all! I would like to start a discussion of FLIP-390: Support System out and err to be redirected to LOG or discarded[1]. In various production environments, either cloud native or physical machines, the disk space that Flink TaskManager can use is limited. In general, the flink users shouldn'