Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-17 Thread yuxia
://lists.apache.org/thread/m4r3wrd7p96wdst3nz3ncqzog6kf51cf Best regards, Yuxia - 原始邮件 - 发件人: "Jark Wu" 收件人: "dev" 发送时间: 星期五, 2023年 4 月 14日 下午 11:04:58 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi Yuxia, Thank you for the updating. That sounds goo

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-14 Thread Jark Wu
ate operation hasn't been executed successfully in the java > doc of the method. > I had updated this FLIP. > > > Best regards, > Yuxia > > ----- 原始邮件 - > 发件人: "Jark Wu" > 收件人: "dev" > 发送时间: 星期五, 2023年 4 月 14日 下午 5:10:48 > 主题: R

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-14 Thread yuxia
收件人: "dev" 发送时间: 星期五, 2023年 4 月 14日 下午 5:10:48 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement The FLIP looks good to me. +1 to start a vote. I just have a question: what will happen if the "executeTruncation" returns false without any exceptions? Best, Jark On Thu,

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-14 Thread Jark Wu
metada. > > I think we can relax to the constraint to support truncate temporary > > table. Now, I update it to the FLIP. > > > > > > 3: > > Thanks for your input, I agree that we can dicuss it in a different FLIP. > > > > > > > > Best regar

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-13 Thread Jing Ge
ble. Now, I update it to the FLIP. > > > 3: > Thanks for your input, I agree that we can dicuss it in a different FLIP. > > > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jing Ge" > 收件人: "dev" > 发送时间: 星期六, 2023年 4 月 08日 上午

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-13 Thread yuxia
uot;Aitozi" 收件人: "dev" 发送时间: 星期四, 2023年 4 月 13日 下午 4:49:11 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Well, thanks xia for your clarification. Agree with your point, I have no other concerns. Best, Aitozi. yuxia 于2023年4月13日周四 16:17写道: > > Hi, Aitozi. > Th

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-13 Thread Aitozi
channel to discuss what the Flink > catalog is for or do we need to introduce some new mechanism for it. > > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Aitozi" > 收件人: "dev" > 发送时间: 星期四, 2023年 4 月 13日 下午 2:37:48 > 主题: Re: [DISCUSS]

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-13 Thread yuxia
023年 4 月 13日 下午 2:37:48 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi, xia > which I think if Flink supports table cache in framework-level, we can also recache in framework-level for truncate table statement. I think currently flink catalog already will some stats for th

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-12 Thread Aitozi
l/connector/catalog/TruncatableTable.java > > [2] > > https://github.com/apache/spark/blob/06c09a79b371c5ac3e4ebad1118ed94b460f48d1/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/TruncateTableExec.scala > > > > > > I think the external catalog can

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-12 Thread liu ron
t; I think the external catalog can implemnet such logic in method > `executeTruncation`. > > Best regards, > Yuxia > > ----- 原始邮件 - > 发件人: "liu ron" > 收件人: "dev" > 发送时间: 星期二, 2023年 4 月 11日 上午 10:51:36 > 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE T

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-11 Thread yuxia
liu ron" 收件人: "dev" 发送时间: 星期二, 2023年 4 月 11日 上午 10:51:36 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi, xia It's a nice improvement to support TRUNCATE TABLE statement, making Flink more feature-rich. I think the truncate syntax is a command that will be e

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-10 Thread liu ron
validating that information in some > manner? Or does truncating a source table for a query cause undefined > behavior on that query? > > Basically, I'm trying to think through the implementations of a truncate > operation to streaming sources and queries. > > Cheers, &

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-10 Thread yuxia
间: 星期二, 2023年 4 月 11日 上午 2:15:10 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi Yuxia, On Mon, Apr 10, 2023 at 10:35 AM yuxia wrote: > Hi, Jim. > > 1: I'm expecting all DynamicTableSinks to support. But it's hard to > support all at one shot. For the

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-10 Thread Jim Hughes
reaming sources and queries. Cheers, Jim > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jim Hughes" > 收件人: "dev" > 发送时间: 星期一, 2023年 4 月 10日 下午 9:32:28 > 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement > > Hi Yuxia, > &

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-10 Thread yuxia
tes with streaming queries? Best regards, Yuxia - 原始邮件 - 发件人: "Jim Hughes" 收件人: "dev" 发送时间: 星期一, 2023年 4 月 10日 下午 9:32:28 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi Yuxia, Two questions: 1. Are you expecting all DynamicTableSinks to support

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-10 Thread Jim Hughes
Hi Yuxia, Two questions: 1. Are you expecting all DynamicTableSinks to support Truncate? The FLIP could use some explanation for what supporting and not supporting the operation means. 2. How will truncate inoperate with streaming queries? That is, if I truncate an input to a streaming query

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-09 Thread yuxia
ay, I can propose it in a new FLIP. It won't break >> the current design. >> >> As for concrete syntax in the FLIP, I think the current one is the concrete >> syntax, we don't allow TABLE keyword to be optional. >> >> 3: Thanks for your reminder, I have u

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-07 Thread Jing Ge
e next Monday (4.10). [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-302%3A+Support+TRUNCATE+TABLE+statement Best regards, Yuxia - 原始邮件 - 发件人: "yuxia" 收件人: "dev" 发送时间: 星期五, 2023年 3 月 24日 上午 11:27:42 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statemen

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-06 Thread Jingsong Li
/FLIP-302%3A+Support+TRUNCATE+TABLE+statement > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "yuxia" > 收件人: "dev" > 发送时间: 星期五, 2023年 3 月 24日 上午 11:27:42 > 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement > > Thanks all for y

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-06 Thread yuxia
quot;dev" 发送时间: 星期五, 2023年 3 月 24日 上午 11:27:42 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Thanks all for your feedback. @Shammon FY My gut feeling is that the end user shouldn't care about whether it'll delete direcotry or move to Trash directory with the TRUNCA

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-23 Thread yuxia
---- 发件人: "Ran Tao" 收件人: "dev" 发送时间: 星期四, 2023年 3 月 23日 下午 6:28:17 主题: Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement Hi, yuxia. Thanks for starting the discussion. I think it's a nice improvement to support TRUNCATE TABLE statement because many other matur

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-23 Thread Ran Tao
Hi, yuxia. Thanks for starting the discussion. I think it's a nice improvement to support TRUNCATE TABLE statement because many other mature engines supports it. I have some questions. 1. because table has different types, whether we will support view or temporary tables? 2. some other engines s

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-23 Thread Hang Ruan
Hi, yuxia, Thanks for starting the discussion. I wonder what the behavior is when we truncate a table which is used as a source. Source table and sink table may have different table options. IMO, the truncate sql should be supported no matter which kind the table is. Best, Hang Shammon FY 于202

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-22 Thread Shammon FY
Hi yuxia Thanks for initiating this discussion. There are usually two types of data deletion in a production environment: one is deleting data directly and the other is moving the data to the trash directory which will be deleted periodically by the underlying system. Can we distinguish between

[DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-22 Thread yuxia
Hi, devs. I'd like to start a discussion about FLIP-302: Support TRUNCATE TABLE statement [1]. The TRUNCATE TABLE statement is a SQL command that allows users to quickly and efficiently delete all rows from a table without dropping the table itself. This statement is commonly used in data wa