Re: [DISCUSS] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-30 Thread Shengkai Fang
Hi, Considering there has been no response for a long time, I want to start the vote on Thursday. Best, Shengkai Jingsong Li 于2022年11月24日周四 15:20写道: > Thanks for the update! > > Looks good to me. > > Best, > Jingsong > > On Thu, Nov 24, 2022 at 3:07 PM Shengkai Fang wrote: > > > > Hi, Jingson

Re: [DISCUSS] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-23 Thread Jingsong Li
Thanks for the update! Looks good to me. Best, Jingsong On Thu, Nov 24, 2022 at 3:07 PM Shengkai Fang wrote: > > Hi, Jingsong. > > Thanks for your feedback! > > > Can we define classes at once so that the connector can be fully > implemented, but we will not pass changes of the nested column. >

Re: [DISCUSS] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-23 Thread Shengkai Fang
Hi, Jingsong. Thanks for your feedback! > Can we define classes at once so that the connector can be fully implemented, but we will not pass changes of the nested column. It's hard to achieve this. If a new need comes, we will add a new kind of TableChange. But I think the current proposal align

Re: [DISCUSS] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-21 Thread Jingsong Li
Thanks Shengkai for the proposal! This should be very useful! > In some cases, users might need to modify the nested column. Our proposal is > able to express the idea by introducing a new class named. My concern is that the connector needs to be implemented multiple times. Can we define classe

[DISCUSS] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-17 Thread Shengkai Fang
Hi, dev. I want to start a discussion about the FLIP-273: Improve Catalog API to Support ALTER TABLE syntax[1]. The motivation of the FLIP is the current Catalog API is difficult for some Catalog to alter the table. For example, the Catalog only exposes void alterTable(ObjectPath tablePath, C