Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
. Now, the FLIP looks good to me. Best regards, Yuxia 发件人: "zhangmang1" 收件人: luoyu...@alumni.sjtu.edu.cn 抄送: "dev" , "Martijn Visser" , imj...@gmail.com 发送时间: 星期二, 2022年 7 月 05日 上午 11:35:35 主题: Re:Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CR

Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread yuxia
ent atomic for ctas, we propose a interface for >> >> catalog >> >> >> to support serializing, then we name it to `AtomicCatalog`. At least, >> >> the >> >> >> interface is for the atomic of ctas. But if we want to implement other >> >>

Re:Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
gt;> catalog >> >> >> to support serializing, then we name it to `AtomicCatalog`. At least, >> >> the >> >> >> interface is for the atomic of ctas. But if we want to implement other >> >> >> features like isolate which may also

Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Jark Wu
should be careful about the name. > >> >> >Regarding the definition of the Catalog name, we have also discussed > >> the > >> >> name `SerializableCatalog`, which is too specific and does not relate to > >> >> the atomic functionality we want to e

Re:Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
;> >> > >> >> >Hope this answers your question. >> >> > >> >> > >> >> > >> >> > >> >> >-- >> >> > >> >> >Best regards, >> >> >Mang Zhang >> >> &g

Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Jark Wu
>> >>1: Also, the mixture of ctas and rtas confuses me as the FLIP talks > >> nothing about rtas but refer it in the configuration suddenly. And if > >> we're not to implement rtas in this FLIP, it may be better not to refer > it > >> and the `rtas` sh

Re:Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-30 Thread Mang Zhang
P as well? >> >>> >> >>>3) connector.type >> >>>"connector.type" has been deprecated since FLIP-95, could you replace >> them >> >>>with 'connector'? >> >>> >> >>>4) SupportsAtomicCata

Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-30 Thread Martijn Visser
opose a interface for catalog > to support serializing, then we name it to `AtomicCatalog`. At least, the > interface is for the atomic of ctas. But if we want to implement other > features like isolate which may also require serializable catalog in the > future, should we introduce

Re:Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-28 Thread Mang Zhang
AtomicCatalog`. At least, the >>interface is for the atomic of ctas. But if we want to implement other >>features like isolate which may also require serializable catalog in the >>future, should we introduce a new interface naming `IsolateCatalog`? Have you >>ever cons

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-28 Thread Mang Zhang
eCatalog`. As it's a public interface, maybe we >should be careful about the name. > > >Best regards, >Yuxia > >- 原始邮件 - >发件人: "Mang Zhang" >收件人: "dev" >抄送: imj...@gmail.com >发送时间: 星期一, 2022年 6 月 27日 下午 5:43:50 >主题: Re:Re: Re:

Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-27 Thread yuxia
: "Mang Zhang" 收件人: "dev" 抄送: imj...@gmail.com 发送时间: 星期一, 2022年 6 月 27日 下午 5:43:50 主题: Re:Re: Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS) Hi Jark, First of all, thank you for your very good advice! The RTAS point you mentioned is

Re:Re: Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-27 Thread Mang Zhang
;> >Looking forward to further feedback from others. >> > >> > >> > >> >-- >> > >> >Best regards, >> >Mang Zhang >> > >> > >> > >> > >> > >> >At 2022-06-24 19:52:58, "ron&q

Re: Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-25 Thread Jark Wu
; > > > > > > > > > > >At 2022-06-24 19:52:58, "ron" wrote: > >>Thanks for godfrey further feedback, your suggestions are very good to > me, the FLIP has updated according to your feedback. It will be very good > if you look at it a

Re:Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread Mang Zhang
ing forward to further feedback from others. >> >> >>> -原始邮件- >>> 发件人: "godfrey he" >>> 发送时间: 2022-06-24 17:00:51 (星期五) >>> 收件人: dev >>> 抄送: "Yun Gao" >>> 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT

Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread Mang Zhang
>> 发送时间: 2022-06-24 17:00:51 (星期五) >> 收件人: dev >> 抄送: "Yun Gao" >> 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE >> TABLE(CTAS) >> >> Hi all, >> >> Sorry for the late reply. >> >> >table.co

Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread ron
-06-24 17:00:51 (星期五) > 收件人: dev > 抄送: "Yun Gao" > 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE > TABLE(CTAS) > > Hi all, > > Sorry for the late reply. > > >table.cor-table-as-select.atomicity-enabled > Regarding `cor`, thi

Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread godfrey he
the JobMaster. > >The interface will also be marked as Internal. > > > >Best, > >Yun > > > > > >-- > >From:Mang Zhang > >Send Time:2022 May 25 (Wed.) 10:24 > >To:dev >

Re:Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-13 Thread Mang Zhang
to the JobGraph and executed in the JobMaster. >The interface will also be marked as Internal. > >Best, >Yun > > >-- >From:Mang Zhang >Send Time:2022 May 25 (Wed.) 10:24 >To:dev >Subject:Re:Re: [DISC

Re:Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-13 Thread Mang Zhang
JobStatusListener is designed to be used inside JM and is not >> serializable, thus we tend to add a new interface JobStatusHook, >> which could be attached to the JobGraph and executed in the JobMaster. >> The interface will also be marked as Internal. >> >> Best, >

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-03 Thread Jing Ge
ce will also be marked as Internal. > > Best, > Yun > > > -- > From:Mang Zhang > Send Time:2022 May 25 (Wed.) 10:24 > To:dev > Subject:Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE > TABLE(CTAS) > > Hi, Martijn > Thanks for

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-30 Thread Yun Gao
ublic interface to drop table, >> so what's the interface will look like? >> >> [1] https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html >> >> Best regards, >> Yuxia >> >> - 原始邮件 - >> 发件人: "Mang Zhang" >>

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Mang Zhang
drop table, >> so what's the interface will look like? >> >> [1] https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html >> >> Best regards, >> Yuxia >> >> - 原始邮件 - >> 发件人: "Mang Zhang" >> 收件人: "de

Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Jark Wu
> > >> > > >> > > >> > > >> > > >> > > >> > -- > >> > > >> > Best regards, > >> > Mang Zhang > >> > > >> > > >> > > >> > > >> > &g

Re:Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Mang Zhang
> > >> > >> > >> > At 2022-04-29 17:00:03, "yuxia" wrote: >> > >Thanks for for driving this work, it's to be a useful feature. >> > >About the flip-218, I have some questions. >> > > >> > >1: Does our C

Re:Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Mang Zhang
ata types in target table instead of always copy the source >> >table's schema. It'll be more flexible with this feature. >> >Btw, MySQL's "CREATE TABLE ... SELECT Statement"[1] support this feature. >> > >> >2: Seems it'll req

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-23 Thread godfrey he
t;> > Regarding the mechanism of cleanUp, people who are familiar with > >> the runtime module need to provide professional advice, which is what we > >> need to focus on. > >> > > >> > > >> > > >> > > >> > > >>

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-18 Thread Jark Wu
riving this work, it's to be a useful feature. >> > >About the flip-218, I have some questions. >> > > >> > >1: Does our CTAS syntax support specify target table's schema >> including column name and data type? I think it maybe a useful fature in >

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-18 Thread Jark Wu
s schema. It'll be more flexible with this feature. > > >Btw, MySQL's "CREATE TABLE ... SELECT Statement"[1] support this > feature. > > > > > >2: Seems it'll requre sink to implement an public interface to drop > table, so what's the in

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-17 Thread godfrey he
27;s "CREATE TABLE ... SELECT Statement"[1] support this feature. > > > >2: Seems it'll requre sink to implement an public interface to drop table, > >so what's the interface will look like? > > > >[1] https://dev.mysql.com/doc/refman/8.0/en/create-table-s

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-05 Thread Mang Zhang
hat's the interface will look like? > >[1] https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html > >Best regards, >Yuxia > >----- 原始邮件 - >发件人: "Mang Zhang" >收件人: "dev" >发送时间: 星期四, 2022年 4 月 28日 下午 4:57:24 >主题: [DISCUSS] FLI

Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-04 Thread Martijn Visser
e will look like? > > [1] https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html > > Best regards, > Yuxia > > - 原始邮件 ----- > 发件人: "Mang Zhang" > 收件人: "dev" > 发送时间: 星期四, 2022年 4 月 28日 下午 4:57:24 > 主题: [DISCUSS] FLIP-218: Support SELECT cla

Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-04-29 Thread yuxia
7;s the interface will look like? [1] https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html Best regards, Yuxia - 原始邮件 - 发件人: "Mang Zhang" 收件人: "dev" 发送时间: 星期四, 2022年 4 月 28日 下午 4:57:24 主题: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS) Hi

[DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-04-28 Thread Mang Zhang
Hi, everyone I would like to open a discussion for support select clause in CREATE TABLE(CTAS), With the development of business and the enhancement of flink sql capabilities, queries become more and more complex. Now the user needs to use the Create Table statement to create the target table