Re: [DISCUSS] FLIP-174: Improve the WithParam interface (Flink ML)

2021-10-29 Thread Dong Lin
Hi Jiangjie, Thanks for the review! Please find below my explanations. On Fri, Oct 29, 2021 at 8:49 PM Becket Qin wrote: > Hi Dong and Zhiping, > > Thanks for writing up the FLIP and sorry for the belated review. The FLIP > looks good to me overall. Just a few minor comments / questions about

Re: [DISCUSS] FLIP-174: Improve the WithParam interface (Flink ML)

2021-10-29 Thread Becket Qin
Hi Dong and Zhiping, Thanks for writing up the FLIP and sorry for the belated review. The FLIP looks good to me overall. Just a few minor comments / questions about WithParams. 1. Currently all the methods in the WithParams interface have a default implementation. It is not clear to me what exact

[DISCUSS] FLIP-174: Improve the WithParam interface (Flink ML)

2021-09-22 Thread Dong Lin
Hi all, Zhipeng and I have created FLIP-174: Improve the WithParam interface. Please find the FLIP wiki in the link https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181311361. The goal of this FLIP is to improve the experience of defining, saving and loading parameters of stages (