Re: [DISCUSS] Drop python 3.7 support in 1.19

Thank you all for the questions/suggestions! After some questions/clarifications there are only +1 on the discussion. Unless there are further questions/objections I'm intended to merge the related PR in 24 hours: https://github.com/apache/flink/pull/23359 G On Wed, Sep 6, 2023 at 10:53 AM Gabo

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Xingbo, Thanks for your support! I agree that multi-platform in general is a good idea. We start with ARM but this opens the door for all others. G On Wed, Sep 6, 2023 at 10:46 AM Xingbo Huang wrote: > Hi Gabor, > > Thanks a lot for the detailed explanation. Building a test environment wi

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Gabor, Thanks a lot for the detailed explanation. Building a test environment with multi-platforms is indeed what we have been lacking, not only for M1 users, but also for Windows users. At 1.16, I remember that Azure did not provide the m1 environment, and the github action just planned m1 in

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Xingbo, > So I guess you want to run ci tests on the m1 > environment, but the current version of miniconda cannot meet this > requirement, so there is a pre-step that must drop python 3.7? In short yes + local wheel build fix on the M1. In a bit more detailed please let me elaborate. You're

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Gyala and Gabor, Pyflink has provided arm64 wheel packages for Apple silicon since 1.16[1]. The use of Miniconda is only related to ci testing and packaging on linux platform, and building mac platform wheels are dependent on cibuildwheel[2]. So I guess you want to run ci tests on the m1 envir

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Xingbo, *Constraint:* I personally not found any miniconda version which provides arm64 support together with python 3.7. [image: image.png] At the moment I think new platform support means 3.7 drop. I fully to agree with Gyula, if we start now maybe we can release it in half a year however *

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Xingbo! I think we have to analyze what we gain by dropping 3.7 and upgrading to a miniconda version with a multiarch support. If this is what we need to get Apple silicon support then I think it's worth doing it already in 1.19. Keep in mind that 1.18 is not even released yet so if we delay t

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Gabor, Thanks for bringing this up. In my opinion, it is a bit aggressive to directly drop Python 3.7 in 1.19. Python 3.7 is still used a lot[1], and as far as I know, many Pyflink users are still using python 3.7 as their default interpreter. I prefer to deprecate Python 3.7 in 1.19 just like

Re: [DISCUSS] Drop python 3.7 support in 1.19

+1 @Dian should we add support of python 3.11 Best regards, Jing On Mon, Sep 4, 2023 at 3:39 PM Gabor Somogyi wrote: > Thanks for all the responses! > > Based on the suggestions I've created the following jiras and started to > work on them: > * https://issues.apache.org/jira/browse/FLINK-3302

Re: [DISCUSS] Drop python 3.7 support in 1.19

Thanks for all the responses! Based on the suggestions I've created the following jiras and started to work on them: * https://issues.apache.org/jira/browse/FLINK-33029 * https://issues.apache.org/jira/browse/FLINK-33030 The reason why I've split them is to separate the concerns and reduce the am

Re: [DISCUSS] Drop python 3.7 support in 1.19

+1, Thanks for looking into this. On Mon, Sep 4, 2023 at 8:38 AM Gyula Fóra wrote: > +1 > Thanks for looking into this. > > Gyula > > On Mon, Sep 4, 2023 at 8:26 AM Matthias Pohl .invalid> > wrote: > > > Thanks Gabor for looking into it. It sounds reasonable to me as well. > > > > +1 > > > > On

Re: [DISCUSS] Drop python 3.7 support in 1.19

+1 Thanks for looking into this. Gyula On Mon, Sep 4, 2023 at 8:26 AM Matthias Pohl wrote: > Thanks Gabor for looking into it. It sounds reasonable to me as well. > > +1 > > On Sun, Sep 3, 2023 at 5:44 PM Márton Balassi > wrote: > > > Hi Gabor, > > > > Thanks for bringing this up. Similarly to

Re: [DISCUSS] Drop python 3.7 support in 1.19

Thanks Gabor for looking into it. It sounds reasonable to me as well. +1 On Sun, Sep 3, 2023 at 5:44 PM Márton Balassi wrote: > Hi Gabor, > > Thanks for bringing this up. Similarly to when we dropped Python 3.6 due to > its end of life (and added 3.10) in Flink 1.17 [1,2], it makes sense to > p

Re: [DISCUSS] Drop python 3.7 support in 1.19

Hi Gabor, Thanks for bringing this up. Similarly to when we dropped Python 3.6 due to its end of life (and added 3.10) in Flink 1.17 [1,2], it makes sense to proceed to remove 3.7 and add 3.11 instead. +1. [1] https://issues.apache.org/jira/browse/FLINK-27929 [2] https://github.com/apache/flink/

[DISCUSS] Drop python 3.7 support in 1.19

Hi All, I've analyzed through part of the pyflink code and found some improvement possibilities. I would like to hear voices on the idea. Intention: * upgrade several python related versions to eliminate end-of-life issues and keep up with bugfixes * start to add python arm64 support Actual situ