Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-24 Thread Henry Saputra
Thanks for the response, all. @Max, yes I second that the duplicate class names, at least the ones not on client facing APIs, add more confusion and it does not help, or even make it worse, the lack of code documentation in some of the classes to figure out how they work together. Agree we can an

Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-24 Thread Max Michels
Totally agree with you Henry. Duplicate class names just add confusion. However, the actual problem is the lack of documentation for a lot of classes. It would be great if we could have a documentation sprint in the near future to at least add a doc string for every class. This might be some work b

Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-24 Thread Till Rohrmann
+1 for Henry's proposition. On Tue, Feb 24, 2015 at 9:55 AM, Kostas Tzoumas wrote: > I agree, at least for all non-user facing classes (e.g., the examples in > Scala/Java/Streaming etc may have the same names) > > Kostas > > On Tue, Feb 24, 2015 at 9:10 AM, Stephan Ewen wrote: > > > That is a g

Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-24 Thread Kostas Tzoumas
I agree, at least for all non-user facing classes (e.g., the examples in Scala/Java/Streaming etc may have the same names) Kostas On Tue, Feb 24, 2015 at 9:10 AM, Stephan Ewen wrote: > That is a good comment, Henry. > > Let's try and follow this rule... > Am 24.02.2015 02:28 schrieb "Henry Sapu

Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-24 Thread Stephan Ewen
That is a good comment, Henry. Let's try and follow this rule... Am 24.02.2015 02:28 schrieb "Henry Saputra" : > Just to be clear that I was not advocating flink to simplify the code > just for the sake of clarity :) > > Flink has a lot to offer by providing simple APIs by hiding complexity to >

Re: [DISCUSS] Discourage using the same class names even though in different packages

2015-02-23 Thread Henry Saputra
Just to be clear that I was not advocating flink to simplify the code just for the sake of clarity :) Flink has a lot to offer by providing simple APIs by hiding complexity to achieve performance. Which I think is one of the key differentiator compare to other general distributed processing platfo

[DISCUSS] Discourage using the same class names even though in different packages

2015-02-23 Thread Henry Saputra
Hi All, I am seeing some same class names, even though in different package names, that could confuse new contributors. One of the attractiveness of Spark that it is the code structure is simple to follow than Hadoop (or Hive for that matter). For example we have IntermediateResultPartition in bo