Re: [DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-09 Thread weijie guo
Hi All, Thank you for all your comments. If there is no further concern, I will create the umbrella JIRA and promote the smoke test of connectors. Best regards, Weijie weijie guo 于2023年1月9日周一 18:06写道: > Hi Hamdy and Martijn, > > Thanks for quickly reply. > > SmokeKafkaITCase is very enlighte

Re: [DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-09 Thread weijie guo
Hi Hamdy and Martijn, Thanks for quickly reply. SmokeKafkaITCase is very enlightening to me, and I totally agree with Martijn about introducing smoke test and testing Datastream/SQL at the same time. Maybe both SmokeXXXITCase or XXXSmokeTest is ok. I think we can create a umbrella ticket to revie

Re: [DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-09 Thread Martijn Visser
Hi Weijie, Thanks for bringing this up. Fabian, Arvid and I also discussed these things like a year ago when we thought about the externalization of connectors. I believe that in the end, you will need to have a 'Smoke Test' [1] for a connector for a DataStream API program and one for a Table/SQL

Re: [DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-09 Thread Hamdy, Ahmed
Hi Weijie I personally agree with the proposal, it guarantees keeping high standards across our repos. Speaking from AWS connectors side, we have maintained e2e tests for Kinesis and Firehose sql connectors, DDB to follow. Happy to coordinate regarding any new conventions or suggestions. On 0

[DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-08 Thread weijie guo
Hi devs, I'd like to start a discussion about adding sql-connector's uber jar e2e test for connectors. I know that some connectors like kafka and HBase have corresponding sql connector uber jar's test, which are located in SqlClientITCase and SQLClientHBaseITCase respectively. However, some sql