he
> > discussion
> > > > >> here
> > > > >> > is
> > > > >> > > > over.
> > > > >> > > >
> > > > >> > > > [1] https://github.com/apache/flink-web/pull/217
&
gt;
> > > >> > > > [1] https://github.com/apache/flink-web/pull/217
> > > >> > > >
> > > >> > > > On Fri, Jun 14, 2019 at 3:21 AM Kurt Young
> > > >> wrote:
> > > >> > > >
> > > >> > > > > Big +1 and thanks for preparing this.
> > > >> > > > >
> > > >> > > > > I t
und this topic has settled.
> > >> > >
> > >> > > I'm going to turn the Google Doc into a markdown file (maybe also
> > >> > multiple,
> > >> > > I'll try out different things) and then open a pull request for
> the
> > >> Flink
> > >> > > website.
> >
;
>> > >> > Best,
>> > >> > Stephan
>> > >> >
>> > >> >
>> > >> > On Fri, Jun 21, 2019 at 4:29 PM Robert Metzger <
>> rmetz...@apache.org>
>> > >> > wrote:
>> > >> &
ussion around this topic has settled.
> > >> > >
> > >> > > I'm going to turn the Google Doc into a markdown file (maybe also
> > >> > multiple,
> > >> > > I'll try out different things) and then open a pull request for
> the
> > >> Flink
> > >> &
t for the
> >> Flink
> >> > > website.
> >> > > I'll post a link to the PR here once I'm done.
> >> > >
> >> > > On Fri, Jun 14, 2019 at 9:36 AM zhijiang <
> wangzhijiang...@aliyun.com
> >> > > .invalid>
t;> > > On Fri, Jun 14, 2019 at 9:36 AM zhijiang > > > .invalid>
>> > > wrote:
>> > >
>> > > > Thanks for providing this useful guide for benefiting both
>> contributors
>> > > > and committers in consistency.
>> > > >
>&g
h covers a lot of
> > > > information. Wish it further categoried and put onto somewhere for
> > easily
> > > > traced future.
> > > >
> > > > Best,
> > > > Zhijiang
> > > > --
ed the whole doc which covers a lot of
> > > information. Wish it further categoried and put onto somewhere for
> easily
> > > traced future.
> > >
> > > Best,
> > > Zhijiang
> > > --
> > > From:Rob
nformation. Wish it further categoried and put onto somewhere for easily
> > traced future.
> >
> > Best,
> > Zhijiang
> > ----------
> > From:Robert Metzger
> > Send Time:2019年6月14日(星期五) 14:24
> > To
or easily
> traced future.
>
> Best,
> Zhijiang
> --
> From:Robert Metzger
> Send Time:2019年6月14日(星期五) 14:24
> To:dev
> Subject:Re: [DISCUSS] Adopting a Code Style and Quality Guide
>
> Thanks a lot for pu
--
From:Robert Metzger
Send Time:2019年6月14日(星期五) 14:24
To:dev
Subject:Re: [DISCUSS] Adopting a Code Style and Quality Guide
Thanks a lot for putting this together!
I'm in the process of reworking the "How to contribute" pages [1] and I
ing it and expose it to contributors.
> > > >
> > > > Even I think it's possible to put its link on the default description
> > of
> > > > pull request, so that the user has to see it when submits the code.
> > > >
> > > > Best, JingsongLee
> > > >
>
code.
> > >
> > > Best, JingsongLee
> > >
> > >
> > > --------------
> > > From:Piotr Nowojski
> > > Send Time:2019年6月13日(星期四) 16:03
> > > To:dev
> > > Subject:Re: [DISCUS
to put its link on the default description of
> > pull request, so that the user has to see it when submits the code.
> >
> > Best, JingsongLee
> >
> >
> > ----------
> > From:Piotr Nowojski
>
mits the code.
>
> Best, JingsongLee
>
>
> --
> From:Piotr Nowojski
> Send Time:2019年6月13日(星期四) 16:03
> To:dev
> Subject:Re: [DISCUSS] Adopting a Code Style and Quality Guide
>
> +1 for it and general content and thank everybody that was involved in
> c
ode.
Best, JingsongLee
--
From:Piotr Nowojski
Send Time:2019年6月13日(星期四) 16:03
To:dev
Subject:Re: [DISCUSS] Adopting a Code Style and Quality Guide
+1 for it and general content and thank everybody that was involved in creating
& wri
As for >add the guide to our repository<, it means check in
guide files under docs/, possibly docs/flinkDev. If we exclude
details of the guide from the doc site, maybe somewhere else.
Best,
tison.
Stephan Ewen 于2019年6月13日周四 下午3:54写道：
> This should definitely be split up into topics, agreed.
>
+1 for it and general content and thank everybody that was involved in creating
& writing this down.
+1 for splitting it up into some easily navigable topics.
Piotrek
> On 13 Jun 2019, at 09:54, Stephan Ewen wrote:
>
> This should definitely be split up into topics, agreed.
> And it should be
This should definitely be split up into topics, agreed.
And it should be linked form the "how to contribute" page or the PR
template to make contributors aware.
On Thu, Jun 13, 2019 at 9:51 AM Zili Chen wrote:
> Thanks for creating this guide Stephan. It is also
> a good start point to internals
Thanks for creating this guide Stephan. It is also
a good start point to internals doc.
One suggestion is we could finally separate the guide
into separated files each of which focus on a specific
topic. Besides, add the guide to our repository should
make contributors more aware of it.
Best,
tis
Thanks for the proposal, Stephan. Big +1 on this.
This is definitely helpful and indispensable for flink's code quality and
healthy community growth.
It would also benefit downstream project to integrate flink easier.
Till Rohrmann 于2019年6月13日周四 下午3:29写道：
> Thanks for creating this code style
Thanks for creating this code style and quality guide Stephan. I think
Flink can benefit from such a guide. Thus +1 for introducing and adhering
to it.
Cheers,
Till
On Thu, Jun 13, 2019 at 5:26 AM Bowen Li wrote:
> Hi Stephan,
>
> Definitely a good guide in principle IMO! I personally already f
Hi Stephan,
Definitely a good guide in principle IMO! I personally already find it
useful in practice to learn from it myself, and also promote and cultivate
a better coding habit around by referencing it. So big +1 to adopt it.
Also want to highlight that we need to make real use of it, and keep
Hi all!
I want to propose that we try and adopt a code style and quality guide. Its
a big endeavor, but I think it's worth trying :-)
The Apache Flink community and contributor base is growing quite a bit, new
committers and contributors are coming on board frequently. Everyone comes
from a diffe
25 matches
Mail list logo
