Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-26 Thread Chesnay Schepler
he.org Subject: Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec This will make it possible to replace the current rough implementation[1] with a common yaml parser. And then we could avoid some unexpected behaviors[2]. +1 [1]. https://github.com/apache/flink/blob/master

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-25 Thread Yun Tang
From: Chesnay Schepler Sent: Friday, September 23, 2022 21:02 To: dev@flink.apache.org ; Matthias Pohl Subject: Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec The PR contains a test now. This is a list of affected options and their new

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-23 Thread Chesnay Schepler
ISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec This will make it possible to replace the current rough implementation[1] with a common yaml parser. And then we could avoid some unexpected behaviors[2]. +1 [1]. https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-22 Thread Matthias Pohl
> From: Yang Wang > Sent: Thursday, September 22, 2022 11:00 > To: dev@flink.apache.org > Subject: Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML > spec > > This will make it possible to replace the current rough implementation[1] > with a common yaml p

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-21 Thread Yun Tang
: Yang Wang Sent: Thursday, September 22, 2022 11:00 To: dev@flink.apache.org Subject: Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec This will make it possible to replace the current rough implementation[1] with a common yaml parser. And then we could avoid some unexpected

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-21 Thread Yang Wang
This will make it possible to replace the current rough implementation[1] with a common yaml parser. And then we could avoid some unexpected behaviors[2]. +1 [1]. https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java#L179 [2].

Re: [DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-21 Thread Konstantin Knauf
Make sense to me. It is moving us in the right direction and makes it possible to drop these keys with Flink 2.0 if that ever happens :) Am Mi., 21. Sept. 2022 um 16:06 Uhr schrieb Chesnay Schepler < ches...@apache.org>: > Hi, > > we have a small number of options in Flink whose key is a prefix o

[DISCUSS][FLINK-29372] Add a suffix to keys that violate YAML spec

2022-09-21 Thread Chesnay Schepler
Hi, we have a small number of options in Flink whose key is a prefix of other keys. This violates the YAML spec; when you view the options as a tree only leaf nodes may have properties. While this is a minor issue from our side I think this can be quite annoying for users, since it means y