IIUC, the major purpose for not using the "rebase and merge" button is to
overcome the problems caused by concurrent mergings. Admittedly, the chance
such problems happen is higher approaching and during the release testing
phase, and the damage is also more significant. However, such problems can
It seems disabling the merge button was only proposed during the release
testing phase, which IMO doesn't
mean we can't use it forever.
Best,
Kurt
On Fri, Jul 2, 2021 at 3:01 PM Xintong Song wrote:
> It was part of the draft proposed in this mail [1]. And before that, it was
> brought up sever
It was part of the draft proposed in this mail [1]. And before that, it was
brought up several times in both ML discussions [2][3] and IIRC offline
release syncs.
If that is too implicit and there are objections, I'm open to keeping on
that discussion.
Thank you~
Xintong Song
[1]
https://lists
- SHOULD NOT use the GitHub UI to merge PRs
Where was this discussed?
On 7/2/2021 6:59 AM, Xintong Song wrote:
Hi Flink committers,
As previously discussed [1], the criteria for merging pull requests has
been updated.
A full version of guidelines can be found on the project wiki [2]. The
fo
Hi Flink committers,
As previously discussed [1], the criteria for merging pull requests has
been updated.
A full version of guidelines can be found on the project wiki [2]. The
following are some of the highlights.
- MUST make sure passing the CI tests before merging PRs
- SHOULD NOT use the Git
