[GitHub] flink-shaded issue #5: [FLINK-7026] Add flink-shaded-asm-5 module

2017-06-28 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink-shaded/pull/5 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink-shaded pull request #3: [FLINK-7007] Add README.md

2017-06-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/3#discussion_r124335176 --- Diff: README.md --- @@ -0,0 +1,28 @@ + + +# Apache Flink Shaded Dependencies + +This repository contains a number of shaded

[GitHub] flink-shaded issue #4: Add flink-shaded-netty module

2017-06-27 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink-shaded/pull/4 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink-shaded issue #1: [FLINK-6981] Add flink-shaded-guava module

2017-06-26 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink-shaded/pull/1 Thanks. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/1#discussion_r124035371 --- Diff: flink-shaded-guava-18/pom.xml --- @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/1#discussion_r124033232 --- Diff: flink-shaded-guava-18/pom.xml --- @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/1#discussion_r124032886 --- Diff: flink-shaded-guava-18/pom.xml --- @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/1#discussion_r124032645 --- Diff: flink-shaded-guava-18/pom.xml --- @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink-shaded issue #2: Include minor version / remove non-existing guava chi...

2017-06-26 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink-shaded/pull/2 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/2#discussion_r124002219 --- Diff: pom.xml --- @@ -30,10 +30,10 @@ under the License. org.apache.flink flink-shaded -1 +1.0 --- End

[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...

2017-06-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink-shaded/pull/2#discussion_r124001072 --- Diff: pom.xml --- @@ -30,10 +30,10 @@ under the License. org.apache.flink flink-shaded -1 +1.0 --- End