Re: FLINK-5734 : Code Generation for NormalizedKeySorter

2017-03-07 Thread pat.chormai
Hi all, We have almost finished implementing the functionalities. The implementation is available at [1]. Also, we have included the benchmark result of FLINK-3722 into the FLIP[2] as well as other implementation details We would be appreciated if you could give us feedback on this before actual

Re: FLINK-5734 : Code Generation for NormalizedKeySorter

2017-02-14 Thread pat.chormai
Hi [~greghogan] I have done the benchmark comparing between FLINK-3722 and our approaches. As you can see at *Score * column which represents sorting time, FLINK-3722 approach seems to be the fastest one. -- View this message in context: http://apache-flink-mailing-list-archive.1008284.n3.na

Re: FLINK-5734 : Code Generation for NormalizedKeySorter

2017-02-09 Thread pat.chormai
Hi Greg, Thanks for your feedback. I would like to answer your questions here. Q: Do I understand correctly that the generated code is only dependent on the length of the sort key? A: Yes, you're right. The generated code is mainly dependent on the length of the sort key. However, I'm not sure