[RESULT][VOTE]FLIP-296: Extend watermark-related features for SQL

2023-03-21 Thread Kui Yuan
(non-binding) - Hang Ruan (non-binding) There is no disapproving vote. Thanks. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-296%3A+Extend+watermark-related+features+for+SQL Best, Kui Yuan

[VOTE] FLIP-296: Extend watermark-related features for SQL

2023-03-15 Thread Kui Yuan
hours unless there is an objection or insufficient votes. Thank you all. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-296%3A+Extend+watermark-related+features+for+SQL [2] https://lists.apache.org/thread/d681bx4t935c30zl750gy6d41tfypbph Best, Kui Yuan

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-10 Thread Kui Yuan
I would consider those options intended for power users. Usually, > the data platform team should come up with well-defined watermark > semantics before exposing tables to SQL users. > > Regards, > Timo > > > On 07.03.23 13:15, Kui Yuan wrote: > > Hi Jing, > > >

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-07 Thread Kui Yuan
27;t know why it does not work even if they did everything right at Flink > SQL level. > > Best regards, > Jing > > > On Tue, Mar 7, 2023 at 6:36 AM Kui Yuan wrote: > > > Hi Jing, > > > > > > Thanks for the reminder. The aim of this flip is letting th

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-06 Thread Kui Yuan
or in the case of source splits. Best, Kui Yuan Jing Ge 于2023年3月7日周二 04:23写道: > Hi Kui, > > Thanks for pointing that out. I knew FLIP-217 which was done by an > engineer working in my team. As far as I am concerned, your FLIP should > answer the following questions: > > 1. H

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-06 Thread Kui Yuan
n't need to introduce such SQL option in this FLIP. Last but not least, with concerns about the changes to complied plan from @Timo and @Jark, I've also added a description of the public interface changes in the FLIP. Best, Kui Yuan Jark Wu 于2023年3月3日周五 16:39写道: > Hi Kui, > >

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-02 Thread Kui Yuan
ter reading the most up-to-date Flip, I didn't find any information if > this solution will support aligning splits/partitions/shards [1]. Did I > miss anything? Best Kui Yuan [1] the POC: https://github.com/yuchengxin/flink/tree/yuankui/watermark_params [2] FLIP-217: https://cwiki.ap

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-03-01 Thread Kui Yuan
Hi all, Thanks for all discussions! Anyone else have questions or suggestions? if not, I will start a vote thread later. Best Kui Yuan kui yuan 于2023年2月27日周一 20:21写道: > Hi Timo, > > Thanks for your advice. I totally agree with your suggestion of naming > convention, I will

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-27 Thread kui yuan
ptions should end up there. > Please also consider the changes to the CompiledPlan in your FLIP. This > change has implications on the JSON format as watermark strategy of > ExecNode becomes more complex, see WatermarkPushDownSpec Best Kui Yuan Timo Walther 于2023年2月27日周一 18:05写道: > Hi Ku

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-23 Thread kui yuan
ERMARK FOR user_action_time AS user_action_time - INTERVAL '5' SECOND ) WITH ( 'watermark.emit.strategy'='ON_PERIODIC', ... ); -- use 'OPTIONS' hint select ... from source_table /*+ OPTIONS('watermark.emit.strategy'= 'ON_PERIODIC') */ ``` Does ever

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-23 Thread kui yuan
r a table named "Orders" tableEnv.executeSql("CREATE TABLE Orders (`user` BIGINT, product STRING, amount INT) WITH ('watermark.emit.strategy'='ON_EVENT'...)"); ``` [1] https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sql/create/ Best Kui Y

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-22 Thread kui yuan
gt; OPTIONS('csv.ignore-parse-errors'='true') */', maybe we can enrich more > table option keys for watermark, e.g., /*+ > OPTIONS('watermark.emit-strategy'='ON_PERIODIC') */. > > > [1] > > https://nightlies.apache.org/flink/flink-docs-

[DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-21 Thread kui yuan
Hi devs, I'd like to start a discussion thread for FLIP-296[1]. This comes from an offline discussion with @Yun Tang, and we hope to enrich table API & SQL to support many watermark-related features which were only implemented at the datastream API level. Basically, we want to introduce waterma

RE: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread kui yuan
Strongly +1 On 2022/06/13 09:59:17 Lihe Ma wrote: > Hi, Everyone, > > I would like to open a discussion on setting incremental checkpoint as default behavior. > > Currently, the configuration of state.backend.incremental is set as false by default. Incremental checkpoint has been adopted widely in