Re: [DISCUSS] FLIP-523 - Handle TLS Certificate Renewal

2025-04-23 Thread Doğuşcan Namal
Hi Nicolas, thanks for the FLIP. I am fully supportive of the motivation and we should be supporting this feature. Here are couple of comments from my side: D1) Since you shared the implementation details on the FLIP as well, I would like to discuss whether using Java's WatchService is the best c

Re: [DISCUSS] FLIP-518: Introduce a community review process

2025-03-31 Thread Doğuşcan Namal
Yep, ship it. I don’t see any harm on start following the suggested process since it only adds a few labels to the existing PRs. We could learn more by time and improve the process on the way. QQ. Do the proposed flinkbot commands work already? On Fri, 21 Mar 2025 at 15:32, David Radley wrote:

Re: [VOTE] FLIP-509 Pluggable Batching For Async Sink

2025-03-11 Thread Doğuşcan Namal
Thanks for the FLIP Poorvank. We already had a discussion on the Google doc and thanks for addressing the comments. It looks good as is to me, +1(non-binding) On Tue, 11 Mar 2025 at 03:39, Poorvank Bhatia wrote: > Hi all, > > I would like to start a vote on FLIP-509 > < > https://cwiki.apache.o

Re: [DISCUSS] Pluggable Batching for Async Sink in Flink

2025-03-07 Thread Doğuşcan Namal
Hi Poorvank, thanks for the FLIP :) Added some comments on the Google doc. Some of them might be irrelevant since I am not that familiar with the codebase at the moment. Otherwise LGTM On Wed, 5 Mar 2025 at 06:14, Poorvank Bhatia wrote: > Hey everyone, > > Before raising a vote thread, can anyo