[jira] [Created] (FLINK-2654) Add JavaDoc to ParameterTool class

2015-09-10 Thread Behrouz Derakhshan (JIRA)
Behrouz Derakhshan created FLINK-2654: - Summary: Add JavaDoc to ParameterTool class Key: FLINK-2654 URL: https://issues.apache.org/jira/browse/FLINK-2654 Project: Flink Issue Type

Re: Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-10 Thread Behrouz Derakhshan
015 at 3:28 PM, Maximilian Michels wrote: > I think the primary concern was flink-examples but if you're on it, > you can also modify the other examples. > > On Thu, Sep 10, 2015 at 12:43 PM, Behrouz Derakhshan > wrote: > > Hi, > > > > So my understanding was t

Re: Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-10 Thread Behrouz Derakhshan
ignoring non-positional arguments. > > For the time being, it would also be ok with me if we ported all > examples to non-positional arguments. > > On Fri, Sep 4, 2015 at 2:46 PM, Behrouz Derakhshan > wrote: > > Yes, I was referring mostly to blog posts and other websites an

Re: Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-04 Thread Behrouz Derakhshan
ing very simplistic > parameter parsing. > > The PT tool also allows to show the input parameters in the web interface. > > So I'm voting for doing a breaking change and using parameters such as > "--input hdfs:/// --output hdfs:/// --iterations 15". > > On

[jira] [Created] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Behrouz Derakhshan (JIRA)
Behrouz Derakhshan created FLINK-2621: - Summary: Add support for positional arguments to ParameterTool Key: FLINK-2621 URL: https://issues.apache.org/jira/browse/FLINK-2621 Project: Flink

Re: Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-04 Thread Behrouz Derakhshan
n Fri, Sep 4, 2015 at 11:17 AM, Behrouz Derakhshan > wrote: > > Hi Max, > > > > What you said makes sense, for "ParameterTool doesn't seem to support > > positional arguments :) but we could fix that." should we create a > separate > > ticket or sho

Re: Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-04 Thread Behrouz Derakhshan
em to support positional > arguments :) but we could fix that. > > Cheers, > Max > > On Thu, Sep 3, 2015 at 5:50 PM, Behrouz Derakhshan > wrote: > > Hi, > > > > I had at look at this ticket FLINK-2021 > > <https://issues.apache.org/jira/browse/FLINK-

Advice on [FLINK-2021]: Rework examples to use new ParameterTool

2015-09-03 Thread Behrouz Derakhshan
Hi, I had at look at this ticket FLINK-2021 , there isn't much to do from a technical stand point and it kinda makes sense to use the new "ParameterTool", since it is being used in most of the other part of the code base. The only question is do we