Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Xintong Song
+1 (binding) - reviewed flink-web PR - verified checksum and signature - verified source archives don't contain binaries - built from source - tried example jobs on a standalone cluster, and everything looks fine Best, Xintong On Tue, Jul 30, 2024 at 12:13 AM Jing Ge wrote: > Thanks Weijie!

[DISCUSS] FLIP-455: Declare async state processing and checkpoint the in-flight requests

2024-07-29 Thread Zakelly Lan
Hi devs, I would like to initiate a discussion about FLIP-455: Declare async state processing and checkpoint the in-flight requests[1]. FLIP-423[2] and the related sub-FLIPs introduced the disaggregated state and async accessing model of state. However, the in-flight state requests (or records) s

Re: [DISCUSS] FLIP-468: Introducing StreamGraph-Based Job Submission.

2024-07-29 Thread Junrui Lee
Hi David, Thank you very much for your detailed explanation, which is crucial in helping to further improve this FLIP. This FLIP is applicable to both batch and stream processing. For batch processing, it can be used to optimize the StreamGraph (e.g., FLIP-469), while for streaming, we can use th

[jira] [Created] (FLINK-35925) Remove hive connector from Flink main repo

2024-07-29 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-35925: - Summary: Remove hive connector from Flink main repo Key: FLINK-35925 URL: https://issues.apache.org/jira/browse/FLINK-35925 Project: Flink Issue Type: Tech

Re: [DISCUSS] FLIP-471: Fixing watermark idleness timeout accounting

2024-07-29 Thread Zakelly Lan
Hi Piotr, I'd prefer to change the semantics of the existing `Clock`, as forcing the relative time and absolute time to run at the same speed limits the use of this clock. Anyway, I have no strong feelings. I understand your concern and introducing a new interface is also fine with me. Best, Zak

Re: [DISCUSS] FLIP-470: Support Adaptive Broadcast Join

2024-07-29 Thread Xia Sun
Hi Lincoln, Thank you for your input and participation in the discussion! Compared to introducing the 'table.optimizer.adaptive-join.enabled' option, introducing the "table.optimizer.adaptive.join.broadcast-threshold" can also cover the need to disable static broadcast optimization while only ena

[jira] [Created] (FLINK-35924) Improve the SourceReaderBase to support the RecordsWithSplitIds share internal buffer from SplitReader.

2024-07-29 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-35924: Summary: Improve the SourceReaderBase to support the RecordsWithSplitIds share internal buffer from SplitReader. Key: FLINK-35924 URL: https://issues.apache.org/jira/browse/FLINK-

[jira] [Created] (FLINK-35923) Add CompiledPlan annotations to BatchExecSort

2024-07-29 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-35923: -- Summary: Add CompiledPlan annotations to BatchExecSort Key: FLINK-35923 URL: https://issues.apache.org/jira/browse/FLINK-35923 Project: Flink Issue Type: Sub-tas

Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Jing Ge
Thanks Weijie! +1 (binding) - verified signatures - verified checksums - checked Github release tag - reviewed the PRs - checked the repo - started a local cluster, tried with WordCount, everything was fine. Best regards, Jing On Mon, Jul 29, 2024 at 1:47 PM Samrat Deb wrote: > Thank you Wei

Re: [DISCUSS] FLIP-470: Support Adaptive Broadcast Join

2024-07-29 Thread Lincoln Lee
+1 for this useful optimization! I have a question about the new optoin, do we really need two broadcast join thresholds? IIUC, this adaptive broadcast join is a complement to compile-time optimization, there is no need for the user to configure two different thresholds (not the off represented by

[jira] [Created] (FLINK-35922) Add configuration options related to hive

2024-07-29 Thread Qiu (Jira)
Qiu created FLINK-35922: --- Summary: Add configuration options related to hive Key: FLINK-35922 URL: https://issues.apache.org/jira/browse/FLINK-35922 Project: Flink Issue Type: Improvement Com

Re: [DISCUSS] FLINK-34440 Support Debezium Protobuf Confluent Format

2024-07-29 Thread David Mariassy
Hey all, Thanks for the ping Kevin! I put up a PR for the alternative implementation here: https://github.com/apache/flink/pull/25114, and would love to get this group's feedback! TIA! On Fri, Jul 19, 2024 at 2:17 PM Kevin Lam wrote: > Hi all, > > I had chimed >

Re: [DISCUSS] FLIP-468: Introducing StreamGraph-Based Job Submission.

2024-07-29 Thread David Morávek
Hi all, My main concern is the absence of a comprehensive vision for how we could make this work for both Batch and Streaming. Right now, it feels like the proposal is solely centered around very specific batch optimizations. I’m inclined to support submitting StreamGraph because it could already

Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Samrat Deb
Thank you Weijie for driving 1.20 release +1 (non-binding) - Verified checksums and sha512 - Verified signatures - Verified Github release tags - Build from source - Start the flink cluster locally run few jobs (Statemachine and word Count) Bests, Samrat On Mon, Jul 29, 2024 at 3:15 PM Ahmed H

[jira] [Created] (FLINK-35921) Flink SQL physical operator replacement support

2024-07-29 Thread Wang Qilong (Jira)
Wang Qilong created FLINK-35921: --- Summary: Flink SQL physical operator replacement support Key: FLINK-35921 URL: https://issues.apache.org/jira/browse/FLINK-35921 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-35920) Add PRINTF function

2024-07-29 Thread Dylan He (Jira)
Dylan He created FLINK-35920: Summary: Add PRINTF function Key: FLINK-35920 URL: https://issues.apache.org/jira/browse/FLINK-35920 Project: Flink Issue Type: Sub-task Components: Table

[jira] [Created] (FLINK-35919) The rowkind keyword option for MySQL connector metadata should be changed to the op_type keyword

2024-07-29 Thread Thorne (Jira)
Thorne created FLINK-35919: -- Summary: The rowkind keyword option for MySQL connector metadata should be changed to the op_type keyword Key: FLINK-35919 URL: https://issues.apache.org/jira/browse/FLINK-35919

[jira] [Created] (FLINK-35918) Migrate the Time to Duration for the flink-runtime module.

2024-07-29 Thread RocMarshal (Jira)
RocMarshal created FLINK-35918: -- Summary: Migrate the Time to Duration for the flink-runtime module. Key: FLINK-35918 URL: https://issues.apache.org/jira/browse/FLINK-35918 Project: Flink Issue

Re: [DISCUSS] FLIP-471: Fixing watermark idleness timeout accounting

2024-07-29 Thread Piotr Nowojski
Hi Arvid, > Yes, I think it would be sufficient to say that the relative time doesn't > need to move at the same speed as wall clock without going into details > such as backpressure (that should be moved to the doc of the WMContext). Makes sense. I've updated the FLIP. In the final PR I will try

Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Ahmed Hamdy
Thanks Weijie for driving +1 (non-binding) - Verified checksums - Verified signature matches Rui Fan's - Verified tag exists on Github - Build from source - Verified no binaries in source archive - Reviewed release notes PR (some nits) Best Regards Ahmed Hamdy On Thu, 25 Jul 2024 at 12:21, wei

Re: [VOTE] FLIP-468: Introducing StreamGraph-Based Job Submission

2024-07-29 Thread David Morávek
Hi everyone, I hope this message finds you well. I recently returned from a two-week vacation and apologize for the delay in my response. There are still a few crucial questions, especially regarding how this will work with streaming that need to be addressed. Therefore, I would like to temporari

[jira] [Created] (FLINK-35917) Failed to deserialize data of EventHeaderV4

2024-07-29 Thread wangkang (Jira)
wangkang created FLINK-35917: Summary: Failed to deserialize data of EventHeaderV4 Key: FLINK-35917 URL: https://issues.apache.org/jira/browse/FLINK-35917 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-35916) AbstractJdbcRowConverter: type conversion to string

2024-07-29 Thread Evgeniy (Jira)
Evgeniy created FLINK-35916: --- Summary: AbstractJdbcRowConverter: type conversion to string Key: FLINK-35916 URL: https://issues.apache.org/jira/browse/FLINK-35916 Project: Flink Issue Type: Improve

Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Rui Fan
+1(binding) - Reviewed the flink-web PR (Left some comments) - Checked Github release tag - Verified signatures - Verified sha512 (hashsums) - The source archives don't contain any binaries - Build the source with Maven 3 and java8 (Checked the license as well) - Start the cluster locally with jdk