Re: Re: Iceberg table maintenance

2024-05-03 Thread Péter Váry
Hi Flink Team, The Iceberg table maintenance proposal is on vote on the Iceberg dev list [1]. Non-binding votes are important too, so if you are interested, please vote. Thanks, Peter [1] - https://lists.apache.org/thread/qhz17ppdbb57ql356j49qqk3nyk59rvm On Tue, Apr 2, 2024, 08:35 Péter Váry

[jira] [Created] (FLINK-35288) Flink Restart Strategy does not work as documented

2024-05-03 Thread Keshav Kansal (Jira)
Keshav Kansal created FLINK-35288: - Summary: Flink Restart Strategy does not work as documented Key: FLINK-35288 URL: https://issues.apache.org/jira/browse/FLINK-35288 Project: Flink Issue Ty

Re: Question around Flink's AdaptiveBatchScheduler

2024-05-03 Thread Venkatakrishnan Sowrirajan
Jinrui and Xia Gentle ping for reviews. On Mon, Apr 29, 2024, 8:28 PM Venkatakrishnan Sowrirajan wrote: > Hi Xia and Jinrui, > > Filed https://github.com/apache/flink/pull/24736 to address the above > described issue. Please take a look whenever you can. > > Thanks > Venkat > > > On Thu, Apr 18

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #1

2024-05-03 Thread Jeyhun Karimov
Hi Qinsheng, Thanks for driving the release. +1 (non-binding) - No binaries in source - Verified Signatures - Github tag exists - Build source Regards, Jeyhun On Thu, May 2, 2024 at 10:52 PM Muhammet Orazov wrote: > Hey Qingsheng, > > Thanks a lot! +1 (non-binding) > > - Checked sha512sum has

Re: Discussion: Condition field in the CR status

2024-05-03 Thread Jeyhun Karimov
Hi Lajith, Thanks a lot for driving this FLIP. Please find my comments below: - I echo Gyula that including some examples and further explanations might ease reader's work. With the current version, the FLIP is a bit hard to follow. - Will the usage of Conditions be enabled by default? Or will t

Re: [VOTE] FLIP-454: New Apicurio Avro format

2024-05-03 Thread Jeyhun Karimov
+1 (non binding) Thanks for driving this FLIP David. Regards, Jeyhun On Fri, May 3, 2024 at 2:21 PM Mark Nuttall wrote: > +1, I would also like to see first class support for Avro and Apicurio > > -- Mark Nuttall, mnutt...@apache.org > Senior Software Engineer, IBM Event Automation > > On 2024

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-03 Thread Jeyhun Karimov
Hi Boto, Thanks for driving this FLIP. +1 for it. I would also ask to include a sample usage and changes for end-users in the FLIP. flink-connector-jdbc: The current module, which will be transformed to > shade all other modules and maintain backward compatibility. Also, in order to ensure the

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-03 Thread Péter Váry
> With regards to FLINK-35149, the fix version indicates a change at Flink CDC; is that indeed correct, or does it require a change in the SinkV2 interface? The fix doesn't need change in SinkV2, so we are good there. The issue is that the new SinkV2 SupportsCommitter/SupportsPreWriteTopology does

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-03 Thread João Boto
Hi, > > You can now update the derby implementation and the core independently and > > decide at your own will when to include the new derby in the core? Not really, we are talking about creating modules in the same repository, not about externalizing the database modules. That is, whenever ther

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-03 Thread João Boto
Hi Muhammet, While I generally agree, given our current usage, I'm struggling to discern any clear advantage. We already have abstract implementations that cover all necessary interfaces and offer essential functionality, complemented by a robust set of reusable tests to streamline implementati

Re: [VOTE] FLIP-454: New Apicurio Avro format

2024-05-03 Thread Mark Nuttall
+1, I would also like to see first class support for Avro and Apicurio -- Mark Nuttall, mnutt...@apache.org Senior Software Engineer, IBM Event Automation On 2024/05/02 09:41:09 David Radley wrote: > Hi everyone, > > I'd like to start a vote on the FLIP-454: New Apicurio Avro format > [1]. The d

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-03 Thread Martijn Visser
Hi Ferenc, You're right, 1.20 it is :) I've assigned the HBase one to you! Thanks, Martijn On Fri, May 3, 2024 at 1:55 PM Ferenc Csaky wrote: > Hi Martijn, > > +1 for the proposal. > > > targeted for Flink 1.19 > > I guess you meant Flink 1.20 here. > > Also, I volunteer to take updating the

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-03 Thread Ferenc Csaky
Hi Martijn, +1 for the proposal. > targeted for Flink 1.19 I guess you meant Flink 1.20 here. Also, I volunteer to take updating the HBase sink, feel free to assign that task to me. Best, Ferenc On Friday, May 3rd, 2024 at 10:20, Martijn Visser wrote: > > > Hi Peter, > > I'll add it

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-03 Thread Martijn Visser
Hi Peter, I'll add it for completeness, thanks! With regards to FLINK-35149, the fix version indicates a change at Flink CDC; is that indeed correct, or does it require a change in the SinkV2 interface? Best regards, Martijn On Fri, May 3, 2024 at 7:47 AM Péter Váry wrote: > Hi Martijn, > >

[jira] [Created] (FLINK-35287) Builder builds NetworkConfig for Elasticsearch connector 8

2024-05-03 Thread Mingliang Liu (Jira)
Mingliang Liu created FLINK-35287: - Summary: Builder builds NetworkConfig for Elasticsearch connector 8 Key: FLINK-35287 URL: https://issues.apache.org/jira/browse/FLINK-35287 Project: Flink