Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-12 Thread Lincoln Lee
Thanks Xuyang driving this work! It's great that everyone agrees with the work itself in this flip[1]! Regarding whether to split the flip or adjust the scope of this flip, I'd like to share some thoughts: 1. About the title of this flip, what I want to say is that flip-145[2] had marked the lega

[jira] [Created] (FLINK-33813) Improve time formatting for easier reading inside the autoscaler

2023-12-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33813: --- Summary: Improve time formatting for easier reading inside the autoscaler Key: FLINK-33813 URL: https://issues.apache.org/jira/browse/FLINK-33813 Project: Flink Issue

Re: [VOTE] FLIP-335: Deprecation and removal of Flink's Time classes in favor of Java's Duration

2023-12-12 Thread Xintong Song
+1 (binding) I guess I missed the FLIP discussion. But the FLIP LGTM. Thanks for driving this, Matthias. Best, Xintong On Tue, Dec 12, 2023 at 8:33 PM Jing Ge wrote: > +1(binding) > > Thanks. > > Best regards, > Jing > > On Tue, Dec 12, 2023 at 1:12 PM Zhu Zhu wrote: > > > +1 (binding) > >

[DISCUSS] Should Configuration support getting value based on String key?

2023-12-12 Thread Rui Fan
Hi devs, I'd like to start a discussion to discuss whether Configuration supports getting value based on the String key. In the FLIP-77[1] and FLINK-14493[2], a series of methods of Configuration are marked as @Deprecated, for example: - public String getString(String key, String defaultValue) -

[jira] [Created] (FLINK-33812) Autoscale not working for standalone application deployment

2023-12-12 Thread jrthe42 (Jira)
jrthe42 created FLINK-33812: --- Summary: Autoscale not working for standalone application deployment Key: FLINK-33812 URL: https://issues.apache.org/jira/browse/FLINK-33812 Project: Flink Issue Type

[jira] [Created] (FLINK-33811) The CI for frocksdb has broken

2023-12-12 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-33811: --- Summary: The CI for frocksdb has broken Key: FLINK-33811 URL: https://issues.apache.org/jira/browse/FLINK-33811 Project: Flink Issue Type: Bug Compon

[jira] [Created] (FLINK-33810) Propagate RecordAttributes that contains isProcessingBacklog status

2023-12-12 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-33810: -- Summary: Propagate RecordAttributes that contains isProcessingBacklog status Key: FLINK-33810 URL: https://issues.apache.org/jira/browse/FLINK-33810 Project: Flink

[jira] [Created] (FLINK-33809) HiveCatalog load hivemetastore.xml

2023-12-12 Thread Bo Cui (Jira)
Bo Cui created FLINK-33809: -- Summary: HiveCatalog load hivemetastore.xml Key: FLINK-33809 URL: https://issues.apache.org/jira/browse/FLINK-33809 Project: Flink Issue Type: Improvement Re

Re: Re: [DISCUSS] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

2023-12-12 Thread weijie guo
Thanks Wencong for the quick response, the updated FLIP LGTM. Best regards, Weijie Wencong Liu 于2023年12月12日周二 19:02写道: > Dear Weijie, > > Thanks for your feedback and the +1 on this feature. > > In response to your query, you are indeed correct. The > PartitionWindowedStream's > > upstream op

[jira] [Created] (FLINK-33808) Implement restore tests for WindowJoin node

2023-12-12 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33808: --- Summary: Implement restore tests for WindowJoin node Key: FLINK-33808 URL: https://issues.apache.org/jira/browse/FLINK-33808 Project: Flink Issue Type:

Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-12 Thread Sergey Nuyanzin
thanks for summarising Timo +1 for splitting it in different FLIPs and agree about having "SESSION Window TVF Aggregation" under FLIP-145 Moreover the task is already there, so no need to move it from one FLIP to another >And actually Sergey Nuyanzin wanted to work >in this if I remember correctl

[jira] [Created] (FLINK-33807) Update junit to 5.10.1

2023-12-12 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33807: --- Summary: Update junit to 5.10.1 Key: FLINK-33807 URL: https://issues.apache.org/jira/browse/FLINK-33807 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-33806) Async IO Allows Custom Action after Final Retry Failure

2023-12-12 Thread Lu Niu (Jira)
Lu Niu created FLINK-33806: -- Summary: Async IO Allows Custom Action after Final Retry Failure Key: FLINK-33806 URL: https://issues.apache.org/jira/browse/FLINK-33806 Project: Flink Issue Type: Impr

[jira] [Created] (FLINK-33805) Implement restore tests for OverAggregate node

2023-12-12 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33805: -- Summary: Implement restore tests for OverAggregate node Key: FLINK-33805 URL: https://issues.apache.org/jira/browse/FLINK-33805 Project: Flink Issue Type: Sub-ta

[jira] [Created] (FLINK-33804) Add Option to disable showing metrics in JobMananger UI

2023-12-12 Thread Lu Niu (Jira)
Lu Niu created FLINK-33804: -- Summary: Add Option to disable showing metrics in JobMananger UI Key: FLINK-33804 URL: https://issues.apache.org/jira/browse/FLINK-33804 Project: Flink Issue Type: Impro

Re: [DISCUSS] Release Flink 1.18.1

2023-12-12 Thread Martijn Visser
Hi Jing, The only thing that was brought to my attention today was https://issues.apache.org/jira/browse/FLINK-33793. I've marked it as a Critical (I think we should have working checkpointing with GCS), but could also be considered a Blocker. There is a PR open for it, but I don't think it's the

[jira] [Created] (FLINK-33803) Add observedGeneration to Operator's status spec

2023-12-12 Thread Ryan van Huuksloot (Jira)
Ryan van Huuksloot created FLINK-33803: -- Summary: Add observedGeneration to Operator's status spec Key: FLINK-33803 URL: https://issues.apache.org/jira/browse/FLINK-33803 Project: Flink

Re: Flink Kubernetes Operator Observed Generation

2023-12-12 Thread Gyula Fóra
Hi Ryan! If you think this is useful/required to integrate with some tooling, I don't really see a problem. We already have a concept of reconciled generation as part of the lastReconciledSpec status field but that is semantically a bit different. Cheers, Gyula

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-12 Thread Krzysztof Zarzycki
Hello, I'm super excited that Flink CDC will join the Flink project! It will be so much easier to bring it into Flink-based projects we run. As I understand you're thinking with Flink CDC 3.0 to make the project broader than CDC, as more "Streaming Integration" framework. This will resemble Kafka

Flink Kubernetes Operator Observed Generation

2023-12-12 Thread Ryan van Huuksloot
Hi Everyone, Thoughts on adding the observedGeneration status field to the Kubernetes Operator? I saw this issue https://issues.apache.org/jira/browse/FLINK-30858 which is useful but the traditional thing would be to just update the observedGeneration when the reconciliation is complete. There is

Re: [VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

2023-12-12 Thread Rodrigo Meneses
+1 On Tue, Dec 12, 2023 at 6:58 AM Maximilian Michels wrote: > +1 (binding) > > On Tue, Dec 12, 2023 at 2:23 PM Peter Huang > wrote: > > > > +1 Non-binding > > > > > > Peter Huang > > > > Őrhidi Mátyás 于2023年12月12日 周二下午9:14写道: > > > > > +1 > > > Matyas > > > > > > On Mon, Dec 11, 2023 at 10:26 

Re: [VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

2023-12-12 Thread Maximilian Michels
+1 (binding) On Tue, Dec 12, 2023 at 2:23 PM Peter Huang wrote: > > +1 Non-binding > > > Peter Huang > > Őrhidi Mátyás 于2023年12月12日 周二下午9:14写道: > > > +1 > > Matyas > > > > On Mon, Dec 11, 2023 at 10:26 PM Gyula Fóra wrote: > > > > > +1 > > > > > > Gyula > > > > > > On Mon, Dec 11, 2023 at 1:26 P

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-12 Thread Lincoln Lee
+1 Thanks Leonard and all CDC contributors for the great work! Best, Lincoln Lee Dian Fu 于2023年12月12日周二 19:11写道: > Big +1 for this! Thanks for driving this effort! > > Regards, > Dian > > On Mon, Dec 11, 2023 at 4:48 PM Leonard Xu wrote: > > > > Hey all, > > > > I want to extend my gratitude

Re: [VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

2023-12-12 Thread Peter Huang
+1 Non-binding Peter Huang Őrhidi Mátyás 于2023年12月12日 周二下午9:14写道: > +1 > Matyas > > On Mon, Dec 11, 2023 at 10:26 PM Gyula Fóra wrote: > > > +1 > > > > Gyula > > > > On Mon, Dec 11, 2023 at 1:26 PM Gabor Somogyi > > > wrote: > > > > > Hi All, > > > > > > I'd like to start a vote on FLIP-401:

Re: [VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

2023-12-12 Thread Őrhidi Mátyás
+1 Matyas On Mon, Dec 11, 2023 at 10:26 PM Gyula Fóra wrote: > +1 > > Gyula > > On Mon, Dec 11, 2023 at 1:26 PM Gabor Somogyi > wrote: > > > Hi All, > > > > I'd like to start a vote on FLIP-401: REST API JSON response > > deserialization unknown field tolerance [1] which has been discussed in >

Re: [VOTE] FLIP-335: Deprecation and removal of Flink's Time classes in favor of Java's Duration

2023-12-12 Thread Jing Ge
+1(binding) Thanks. Best regards, Jing On Tue, Dec 12, 2023 at 1:12 PM Zhu Zhu wrote: > +1 (binding) > > Thanks, > Zhu > > Matthias Pohl 于2023年12月12日周二 01:32写道: > > > Hi everyone, > > I'd like to start a vote on FLIP-335 [1]. It covers the deprecation (and > > Flink 2.0-related removal) of Fl

Re: [VOTE] FLIP-335: Deprecation and removal of Flink's Time classes in favor of Java's Duration

2023-12-12 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Matthias Pohl 于2023年12月12日周二 01:32写道: > Hi everyone, > I'd like to start a vote on FLIP-335 [1]. It covers the deprecation (and > Flink 2.0-related removal) of Flink's Time classes in favor of Java's > Duration class. > > The related discussion thread can be found in [2

[jira] [Created] (FLINK-33802) ActiveResourceManagerFactoryTest failed with 239 exit code

2023-12-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33802: - Summary: ActiveResourceManagerFactoryTest failed with 239 exit code Key: FLINK-33802 URL: https://issues.apache.org/jira/browse/FLINK-33802 Project: Flink

Snowflake JDBC dialect

2023-12-12 Thread Boris Litvak
I’d like to contribute Snowflake dialect to JDBC, could you please assign the ticket to me? AFAIU, I cannot file a PR without this.

Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-12 Thread Timo Walther
Hi Xuyang, thanks for proposing this FLIP. In my opinion the FLIP touches too many topics at the same time and should be split into multiple FLIPs. We should stay focused on what is needed for Flink 2.0. Let me summarizing the topics: 1) SESSION Window TVF Aggregation This has been agreed i

Re: [DISCUSS] Change the default restart-strategy to exponential-delay

2023-12-12 Thread Maximilian Michels
Thank you Rui! I think a 1.5 multiplier is a reasonable tradeoff between restarting fast but not putting too much pressure on the cluster due to restarts. -Max On Tue, Dec 12, 2023 at 8:19 AM Rui Fan <1996fan...@gmail.com> wrote: > > Hi Maximilian and Mason, > > Thanks a lot for your feedback! >

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-12 Thread Dian Fu
Big +1 for this! Thanks for driving this effort! Regards, Dian On Mon, Dec 11, 2023 at 4:48 PM Leonard Xu wrote: > > Hey all, > > I want to extend my gratitude for the positive feedback we've received, > particularly from voices in other communities. It is an honor for the Flink > CDC communit

Re:Re: [DISCUSS] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

2023-12-12 Thread Wencong Liu
Dear Weijie, Thanks for your feedback and the +1 on this feature. In response to your query, you are indeed correct. The PartitionWindowedStream's upstream operator must utilize a Forward type partitioner. Consequently, the framework will apply a POINTWISE edge connection pattern between the u

Re:Re: [DISCUSS] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

2023-12-12 Thread Wencong Liu
Dear Yuxin, Thank you for your support and for raising those insightful queries. Indeed, the full window processing aligns more naturally with batch scenarios. The primary reason we've limited it to batch processing is due to state management considerations in a streaming context. If we were

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

2023-12-12 Thread Lincoln Lee
+1 (binding) Thanks for driving this! Best, Lincoln Lee Yun Tang 于2023年12月12日周二 17:52写道: > Thanks for Matthias driving this work! > > +1 (binding) > > Best > Yun Tang > > From: Yangze Guo > Sent: Tuesday, December 12, 2023 16:12 > To: dev@flink.apache.org >

Re: Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-12 Thread Jane Chan
Hi Xuyang, Thank you for the clarification. I now have a clear understanding of the issue. Actually the work that supports unaligned window in window agg operator is > included in this flip. We will always try to implement > features in window agg operator first and then consider falling back to

[jira] [Created] (FLINK-33801) Revert to last scaling when job becomes unhealthy after scaling

2023-12-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33801: --- Summary: Revert to last scaling when job becomes unhealthy after scaling Key: FLINK-33801 URL: https://issues.apache.org/jira/browse/FLINK-33801 Project: Flink Issue

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

2023-12-12 Thread Yun Tang
Thanks for Matthias driving this work! +1 (binding) Best Yun Tang From: Yangze Guo Sent: Tuesday, December 12, 2023 16:12 To: dev@flink.apache.org Subject: Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastr

Re: [DISCUSS] Release Flink 1.18.1

2023-12-12 Thread Jing Ge
Hi All, Thank you for your feedback! Since FLINK-33523[1] is done(thanks Martijn for driving it) and there are no other concerns or objections. Currently I am not aware of any unresolved blockers. There is one critical task[2] whose PR still has some checkstyle issues. I will try to include it in

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

2023-12-12 Thread Yangze Guo
+1 (binding) Best, Yangze Guo On Tue, Dec 12, 2023 at 3:51 PM Yuxin Tan wrote: > > +1 (non binding) > Thanks for the effort. > > Best, > Yuxin > > > Samrat Deb 于2023年12月12日周二 15:25写道: > > > +1 (non binding) > > Thanks for driving > > > > On Tue, 12 Dec 2023 at 11:59 AM, Sergey Nuyanzin > > wro