Fang Yong created FLINK-32665:
-
Summary: Support read null value for csv format
Key: FLINK-32665
URL: https://issues.apache.org/jira/browse/FLINK-32665
Project: Flink
Issue Type: Bug
Co
+1 (no-binding)
Zhu Zhu 于2023年7月25日周二 10:07写道：
> +1 (binding)
>
> Thanks,
> Zhu
>
> Xintong Song 于2023年7月25日周二 09:46写道：
> >
> > +1 (binding)
> >
> > Best,
> >
> > Xintong
> >
> >
> >
> > On Mon, Jul 24, 2023 at 11:58 PM Jing Ge
> wrote:
> >
> > > +1
> > >
> > > On Mon, Jul 24, 2023 at 11:43 PM
Congratulations, Yong Fang
Mang Zhang 于2023年7月25日周二 12:08写道：
> Congratulations, Yong Fang!
>
>
> --
>
> Best regards,
> Mang Zhang
>
>
>
>
>
> 在 2023-07-25 10:30:24，"Jark Wu" 写道：
> >Congratulations, Yong Fang!
> >
> >Best,
> >Jark
> >
> >On Mon, 24 Jul 2023 at 22:11, Wencong Liu wrote:
> >
> >
Hi Alex,
Providing a longer supporting period for the last 1.x minor release makes
sense to me.
I think we need to be more specific about what LTS means here.
- IIUC, that means for the last 1.x minor release, we will keep
providing 1.x.y / 1.x.z bugfix release. This is a stronger support
Same as I proposed in the FLIP-352 thread, the phasing out of the query
parameters may also benefit from a REST API version bump.
Best,
Xintong
On Mon, Jul 24, 2023 at 6:43 PM Chesnay Schepler wrote:
> The jar handlers currently accept a variety of parameters both as query
> parameters and v
+1
Best,
Xintong
On Mon, Jul 24, 2023 at 6:25 PM Chesnay Schepler wrote:
> To properly reflect the state of the rocksdb statebackend I propose to
> move all classes in the state-backend-rocksdb module under the classes
> to o.a.f.state.rocksdb package.
>
>
>
> https://cwiki.apache.org/conflu
Congratulations, Yong Fang!
--
Best regards,
Mang Zhang
在 2023-07-25 10:30:24，"Jark Wu" 写道：
>Congratulations, Yong Fang!
>
>Best,
>Jark
>
>On Mon, 24 Jul 2023 at 22:11, Wencong Liu wrote:
>
>> Congratulations!
>>
>> Best,
>> Wencong Liu
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> 在 20
+1, it’s pretty necessary especially we deprecated so many APIs in 1.18 and
plan to remove in 2.0.
The 1.19 should be a proper version for LTS Release.
Best,
Leonard
> On Jul 25, 2023, at 3:30 AM, Alexander Fedulov
> wrote:
>
> Hello everyone,
>
> Recently, there were a lot of discussions
Hi David,
Thank you for the detailed comments and the suggestion of this alternative
approach.
I agree with you that this alternative can also address the target use-case
with the same correctness. In comparison to the current FLIP, this
alternative indeed introduces much less complexity to the F
Hi Jane,
Thanks for driving this! Overall the proposed annotations looks good to me.
Some comments for the table[1]:
For the `DynamicFilteringEvent`, tend to keep it 'internal' since it's a
concreate implementation of `SourceEvent`(and other two implementers are
not public ones) .
For the `Looku
Hi Jane,
Thanks for kicking off this work and collecting the detailed list.
+1 to add the missing annotation.
This often confuses me whether the class can be modified without breaking
the compatibility
when looking at classes in table-common and table-api. Explicitly mark the
visibility can be
>
> we should treat these cases as errors
>
Looking at the fields listed in the FLIP, I'd agree with this argument. And
based on this, shouldn't we fail the request with e.g., a status code 500,
rather than responding with a fallback value silently?
Best,
Xintong
On Tue, Jul 25, 2023 at 12:22
Congratulations, Yong Fang!
Best,
Jark
On Mon, 24 Jul 2023 at 22:11, Wencong Liu wrote:
> Congratulations!
>
> Best,
> Wencong Liu
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 在 2023-07-24 11:03:30，"Paul Lam" 写道：
> >Congrats, Shammon!
> >
> >Best,
> >Paul Lam
> >
> >> 2023年7月24日 10:56，Jingsong Li 写道：
> >>
I think adding the convention to our code-style guidelines [1] makes sense.
In addition, I wonder if this can be enforced with some code-style checking
tools.
What impact (if any) will there be on existing users?
Virtually every tooling against the REST API will break. Users that
> generated a cl
+1 (binding)
Thanks,
Zhu
Xintong Song 于2023年7月25日周二 09:46写道：
>
> +1 (binding)
>
> Best,
>
> Xintong
>
>
>
> On Mon, Jul 24, 2023 at 11:58 PM Jing Ge wrote:
>
> > +1
> >
> > On Mon, Jul 24, 2023 at 11:43 PM Chesnay Schepler
> > wrote:
> >
> > > I update the endpoint in the FLIP.
> > >
> > > On
+1 (binding)
Best,
Xintong
On Mon, Jul 24, 2023 at 11:26 PM Jing Ge wrote:
> +1(binding)
>
> On Mon, Jul 24, 2023 at 8:55 PM Matthias Pohl
> wrote:
>
> > +1 (binding)
> >
> > On Mon, Jul 24, 2023 at 2:24 PM Konstantin Knauf
> > wrote:
> >
> > > +1 (binding)
> > >
> > > Am Mo., 24. Juli 202
+1 (binding)
Best,
Xintong
On Mon, Jul 24, 2023 at 11:58 PM Jing Ge wrote:
> +1
>
> On Mon, Jul 24, 2023 at 11:43 PM Chesnay Schepler
> wrote:
>
> > I update the endpoint in the FLIP.
> >
> > On 24/07/2023 14:28, Matthias Pohl wrote:
> > > I should have mentioned it in the discussion thread
Sergey Nuyanzin created FLINK-32664:
---
Summary:
TableSourceJsonPlanTest.testReuseSourceWithoutProjectionPushDown is failing
Key: FLINK-32664
URL: https://issues.apache.org/jira/browse/FLINK-32664
Pro
Sergey Nuyanzin created FLINK-32663:
---
Summary:
RescalingITCase.testSavepointRescalingInPartitionedOperatorStateList fails on
AZP
Key: FLINK-32663
URL: https://issues.apache.org/jira/browse/FLINK-32663
Sergey Nuyanzin created FLINK-32662:
---
Summary: JobMasterTest.testRetrievingCheckpointStats fails with
NPE on AZP
Key: FLINK-32662
URL: https://issues.apache.org/jira/browse/FLINK-32662
Project: Flin
Sergey Nuyanzin created FLINK-32661:
---
Summary: OperationRelatedITCase.testOperationRelatedApis fails on
AZP
Key: FLINK-32661
URL: https://issues.apache.org/jira/browse/FLINK-32661
Project: Flink
Hello everyone,
Recently, there were a lot of discussions about the deprecation of various
APIs for the upcoming 2.0 release. It appears there are two main motivations
with opposing directions, causing these discussions to remain unsettled. On
one hand, there's a desire to finally trim a wide rang
I'm delighted to see interest in developing support for
processing-time temporal joins.
The proposed implementation seems rather complex, and I'm not
convinced this complexity is justified/necessary. I'd like to outline
a simpler alternative that I think would satisfy the key objectives.
Key idea
Hi casel,
Thank you for initiating the discussion about RowKind meta. I believe that
in certain scenarios, it is necessary to expose RowKind. We also have
similar situations internally:
In simple terms, we need to be able to control the behavior of RowKind in
both Source and Sink:
- When reading
Hi Chen,
Thanks for the reply. Yes we have a very low interval. But our jobs usually
have 10-20 independent Kafka topics. When we perform scaling we stop
reading from all. Do you think we can implement partial failover to
calculate Kafka Partition assignments? Or rather than sending an
interrupted
We might consider using 0 as null for values that never return 0. But null
is still not equal to 0 and it will be very difficult to let every
contributor in this community follow this rule, especially for future
unknown APIs, which means there will be some cases that still need null.
Personally, I
+1
On Mon, Jul 24, 2023 at 11:43 PM Chesnay Schepler
wrote:
> I update the endpoint in the FLIP.
>
> On 24/07/2023 14:28, Matthias Pohl wrote:
> > I should have mentioned it in the discussion thread but I missed going
> over
> > that ML thread earlier: We might want to update the FLIP to refer t
camel case is the standard code convention in Java since day one[1]. We
don't need to describe it again for Flink. Legacy hyphens might be coded by
contributors with other language backgrounds. If we really care about it,
it might make sense to add the reference.
It would be great if the FLIP coul
The downside to null is that it again forces users to handle this case
themselves.
The reality is that there is no good default value.
Ideally we fix all cases where we return such values, such that the
fallback to 0 isn't even used.
Arguably the same could be said for null, but I'd think that
I update the endpoint in the FLIP.
On 24/07/2023 14:28, Matthias Pohl wrote:
I should have mentioned it in the discussion thread but I missed going over
that ML thread earlier: We might want to update the FLIP to refer to the
actual endpoint /jobs/:jobid/rescaling (AFAIU) with the corresponding
agree, since we want to try our best to deprecate APIs in 1.18, it makes
sense.
Best regards,
Jing
On Mon, Jul 24, 2023 at 12:11 PM Wencong Liu wrote:
> Hi Jing and Matthias,
>
>
> I believe it is reasonable to examine all classes that implement the
> IOReadableWritable
> interface and sum
+1
On Mon, Jul 24, 2023 at 5:08 PM Timo Walther wrote:
> +1
>
> Regards,
> Timo
>
>
> On 24.07.23 04:00, liu ron wrote:
> > +1
> >
> > Best,
> > Ron
> >
> > Lincoln Lee 于2023年7月21日周五 16:09写道：
> >
> >> +1
> >>
> >> Best,
> >> Lincoln Lee
> >>
> >>
> >> Leonard Xu 于2023年7月21日周五 16:07写道：
> >>
> >
+1(binding)
On Mon, Jul 24, 2023 at 8:55 PM Matthias Pohl
wrote:
> +1 (binding)
>
> On Mon, Jul 24, 2023 at 2:24 PM Konstantin Knauf
> wrote:
>
> > +1 (binding)
> >
> > Am Mo., 24. Juli 2023 um 14:15 Uhr schrieb Martijn Visser <
> > martijnvis...@apache.org>:
> >
> > > +1 (binding)
> > >
> > >
I agree that it's a bit strange to have 0 as a fallback value because it
can also naturally occur for many metrics.
If we want to omit the value null would be probably better as Matthias
suggested.
Gyula
On Mon, Jul 24, 2023 at 4:02 PM Matthias Pohl
wrote:
> What was the reason you decided to g
Hi devs,
FLIP-346 [1] has been accepted and voted through this thread [2].
There are five approving votes, four of which are binding:
- Leonard Xu (binding)
- Lincoln Lee (binding)
- Liu Ron (non-binding)
- Timo Walther (binding)
- Yuxia Luo (binding)
And there is no disapproval.
Congratulations!
Best,
Wencong Liu
在 2023-07-24 11:03:30，"Paul Lam" 写道：
>Congrats, Shammon!
>
>Best,
>Paul Lam
>
>> 2023年7月24日 10:56，Jingsong Li 写道：
>>
>> Shammon
>
What was the reason you decided to go for 0 as the fallback value instead
of null? Wouldn't that be a more reasonable value for error cases?
On Mon, Jul 24, 2023 at 12:51 PM Chesnay Schepler
wrote:
> There are a number of cases where the REST API can return infinity or
> NaN for certain double f
Do we have conventions on how the REST API should be formatted written down
somewhere?
Checking our coding conventions [1] didn't reveal anything.
We could refer to a style guide like [2] to cover this topic. That would
also include the camel-cased JSON fields.
[1]
https://flink.apache.org/how-to
Congratulations, Yong Fang
Best,
Lincoln Lee
Kelu Tao 于2023年7月24日周一 20:45写道：
> Congratulations, Shammon!
>
>
> On 2023/07/24 02:56:47 Jingsong Li wrote:
> > Hi, everyone
> >
> > On behalf of the PMC, I'm very happy to announce Yong Fang (Shammon)
> > (zjur...@gmail.com) as a new Flink Committe
+1 (binding)
On Mon, Jul 24, 2023 at 2:24 PM Konstantin Knauf wrote:
> +1 (binding)
>
> Am Mo., 24. Juli 2023 um 14:15 Uhr schrieb Martijn Visser <
> martijnvis...@apache.org>:
>
> > +1 (binding)
> >
> > On Mon, Jul 24, 2023 at 1:08 PM Chesnay Schepler
> > wrote:
> >
> > > Hello,
> > >
> > > I'
Congratulations, Shammon!
On 2023/07/24 02:56:47 Jingsong Li wrote:
> Hi, everyone
>
> On behalf of the PMC, I'm very happy to announce Yong Fang (Shammon)
> (zjur...@gmail.com) as a new Flink Committer.
>
> Yong is an old flinker, he has been contributing to Flink since 2017.
>
> He actively
I should have mentioned it in the discussion thread but I missed going over
that ML thread earlier: We might want to update the FLIP to refer to the
actual endpoint /jobs/:jobid/rescaling (AFAIU) with the corresponding cause
being FLINK-12312 [1].
But that's just a minor thing.
+1 (binding)
[1]
+1 (binding)
Am Mo., 24. Juli 2023 um 14:15 Uhr schrieb Martijn Visser <
martijnvis...@apache.org>:
> +1 (binding)
>
> On Mon, Jul 24, 2023 at 1:10 PM Chesnay Schepler
> wrote:
>
> > Hello,
> >
> > I'd like to start a vote on FLIP-340.
> >
> > Discussion thread:
> > https://lists.apache.org/thre
+1 (binding)
Am Mo., 24. Juli 2023 um 14:15 Uhr schrieb Martijn Visser <
martijnvis...@apache.org>:
> +1 (binding)
>
> On Mon, Jul 24, 2023 at 1:08 PM Chesnay Schepler
> wrote:
>
> > Hello,
> >
> > I'd like to start a vote on FLIP-336.
> >
> > Discussion thread:
> > https://lists.apache.org/thre
+1 (binding)
On Mon, Jul 24, 2023 at 1:08 PM Chesnay Schepler wrote:
> Hello,
>
> I'd like to start a vote on FLIP-336.
>
> Discussion thread:
> https://lists.apache.org/thread/ms3sk0p21n7q2oq0fjtq43koqj2pmwv4
> FLIP:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263424789
>
+1 (binding)
On Mon, Jul 24, 2023 at 1:10 PM Chesnay Schepler wrote:
> Hello,
>
> I'd like to start a vote on FLIP-340.
>
> Discussion thread:
> https://lists.apache.org/thread/zkslk0qzttwgs8j3s951rht3v1tsyqqk
> FLIP:
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-340%3A+Remove+resca
Hi Timo,
Thanks for you reply. I think adding an empty OpenContext to keep the signature
is
reasonable. I'll modify the FLIP at a later time.
Best,
Wencong Liu
At 2023-07-24 17:11:44, "Timo Walther" wrote:
>+1
>
>But instead we should add a OpenContext there to keep the signa
Ferenc Csaky created FLINK-32660:
Summary: Support external file systems in FileCatalogStore
Key: FLINK-32660
URL: https://issues.apache.org/jira/browse/FLINK-32660
Project: Flink
Issue Type:
Aitozi created FLINK-32659:
--
Summary: DB connection may leak if exception is thrown in
JdbcOutputFormat#close
Key: FLINK-32659
URL: https://issues.apache.org/jira/browse/FLINK-32659
Project: Flink
Rui Fan created FLINK-32658:
---
Summary: State should not be silently removed when
ignore-unclaimed-state is false
Key: FLINK-32658
URL: https://issues.apache.org/jira/browse/FLINK-32658
Project: Flink
Hello,
I'd like to start a vote on FLIP-340.
Discussion thread:
https://lists.apache.org/thread/zkslk0qzttwgs8j3s951rht3v1tsyqqk
FLIP:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-340%3A+Remove+rescale+REST+endpoint
Regards,
Chesnay
Hello,
I'd like to start a vote on FLIP-336.
Discussion thread:
https://lists.apache.org/thread/ms3sk0p21n7q2oq0fjtq43koqj2pmwv4
FLIP:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263424789
Regards,
Chesnay
Make the REST API more consistent and easier to work with from the UI.
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425799
There are a number of cases where the REST API can return infinity or
NaN for certain double fields.
This is problematic because the JSON spec does not allow such values,
and tooling working against that spec may run into issues when
encountering such a value.
Specifically we've seen this be
The jar handlers currently accept a variety of parameters both as query
parameters and via the request body.
While it is primarily a problem for sending program args as query
parameters, because it's a nightmare with escaping parameters, the
remaining parameters should follow suite for consist
To properly reflect the state of the rocksdb statebackend I propose to
move all classes in the state-backend-rocksdb module under the classes
to o.a.f.state.rocksdb package.
https://cwiki.apache.org/confluence/display/FLINK/FLIP-349%3A+Move+RocksDB+statebackend+classes+to+o.a.f.state.rocksdb+p
Timo Walther created FLINK-32657:
Summary: Revert upgrading ExecNode versions for StateMetadata
Key: FLINK-32657
URL: https://issues.apache.org/jira/browse/FLINK-32657
Project: Flink
Issue Ty
+1
But instead we should add a OpenContext there to keep the signature
stable but still be able to add parameters.
Regards,
Timo
On 21.07.23 12:24, Jing Ge wrote:
+1
On Fri, Jul 21, 2023 at 10:22 AM Yuxin Tan wrote:
+1
Best,
Yuxin
Xintong Song 于2023年7月21日周五 12:04写道：
+1
Best,
Xint
+1
Regards,
Timo
On 24.07.23 04:00, liu ron wrote:
+1
Best,
Ron
Lincoln Lee 于2023年7月21日周五 16:09写道：
+1
Best,
Lincoln Lee
Leonard Xu 于2023年7月21日周五 16:07写道：
+1
Best,
Leonard
On Jul 21, 2023, at 4:02 PM, yuxia
wrote:
+1（binging）
Best regards,
Yuxia
- 原始邮件 -
发件人: "Jane C
Congrats, Yong Fang!
Best,
Yuepeng Pan
在 2023-07-24 16:51:08，"Dan Zou" 写道：
>Congrats, Yong Fang!
>
>Best,
>Dan Zou
>
>
>
>
>
>> 2023年7月24日 15:41，Matt Wang 写道：
>>
>> Yong Fang
>
Congrats, Yong Fang!
Best,
Dan Zou
> 2023年7月24日 15:41，Matt Wang 写道：
>
> Yong Fang
Jane Chan created FLINK-32656:
-
Summary: Deprecate ManagedTable related APIs
Key: FLINK-32656
URL: https://issues.apache.org/jira/browse/FLINK-32656
Project: Flink
Issue Type: Sub-task
Congratulations, Yong Fang
Best,
Rui Fan
On Mon, Jul 24, 2023 at 3:42 PM Matt Wang wrote:
> Congratulations, Yong Fang
>
>
> --
>
> Best,
> Matt Wang
>
>
> Replied Message
> | From | Feng Jin |
> | Date | 07/24/2023 15:27 |
> | To | |
> | Cc | Shammon FY |
> | Subject | Re: [ANNOUNCE
Congratulations, Yong Fang
--
Best,
Matt Wang
Replied Message
| From | Feng Jin |
| Date | 07/24/2023 15:27 |
| To | |
| Cc | Shammon FY |
| Subject | Re: [ANNOUNCE] New Apache Flink Committer - Yong Fang |
Congratulations, Yong Fang
Best,
Feng
On Mon, Jul 24, 2023 at 3:12 PM Leo
Ming Li created FLINK-32655:
---
Summary: RecreateOnResetOperatorCoordinator did not forward
notifyCheckpointAborted to the real OperatorCoordinator
Key: FLINK-32655
URL: https://issues.apache.org/jira/browse/FLINK-32655
Zhu Zhu created FLINK-32654:
---
Summary: Deprecate ExecutionConfig#canEqual(obj)
Key: FLINK-32654
URL: https://issues.apache.org/jira/browse/FLINK-32654
Project: Flink
Issue Type: Technical Debt
Congratulations, Yong Fang
Best,
Feng
On Mon, Jul 24, 2023 at 3:12 PM Leonard Xu wrote:
> Congratulations, Yong Fang
>
> Best,
> Leonard
>
> > On Jul 24, 2023, at 2:01 PM, yuxia wrote:
> >
> > Congrats, Shammon!
> >
> > Best regards,
> > Yuxia
> >
> > - 原始邮件 -
> > 发件人: "Benchao Li"
>
Congratulations, Yong Fang
Best,
Leonard
> On Jul 24, 2023, at 2:01 PM, yuxia wrote:
>
> Congrats, Shammon!
>
> Best regards,
> Yuxia
>
> - 原始邮件 -
> 发件人: "Benchao Li"
> 收件人: "dev"
> 抄送: "Shammon FY"
> 发送时间: 星期一, 2023年 7 月 24日 下午 1:23:55
> 主题: Re: [ANNOUNCE] New Apache Flink Committ
68 matches
Mail list logo
