Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Weihua Hu
Thanks for driving this. +1 for Mockito and Junit4. A clarity checkstyle will be of great help to new developers. Best, Weihua On Wed, Apr 26, 2023 at 1:47 PM Jing Ge wrote: > This is a great idea, thanks for bringing this up. +1 > > Also +1 for Junit4. If I am not mistaken, it could only be

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Jing Ge
This is a great idea, thanks for bringing this up. +1 Also +1 for Junit4. If I am not mistaken, it could only be done after the Junit5 migration is done. @Chesnay thanks for the hint. Do we have any doc about it? If not, it might deserve one. WDYT? Best regards, Jing On Wed, Apr 26, 2023 at 5:1

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Xintong Song
Thanks all for the positive feedback. @Martijn If we want to have that roadmap, should we consolidate this into a > dedicated Confluence page over storing it in a Google doc? > Having a dedicated wiki page is definitely a good way for the roadmap discussion. I haven't created one yet because it'

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Lijie Wang
Thanks for driving this. +1 for the proposal. Can we also prevent Junit4 usage in new code by this way?Because currently we are aiming to migrate our codebase to JUnit 5. Best, Lijie Piotr Nowojski 于2023年4月25日周二 23:02写道: > Ok, thanks for the clarification. > > Piotrek > > wt., 25 kwi 2023 o 16

Re: [ANNOUNCE] New Apache Flink PMC Member - Qingsheng Ren

2023-04-25 Thread Shengkai Fang
Congratulations, Qingsheng! Best regards, Shengkai Qingsheng Ren 于2023年4月24日周一 19:53写道: > Thank you all! I'm so honored and happy to work with all contributors in > the Apache Flink community. Let's make Flink better together! > > Cheers, > Qingsheng > > On Mon, Apr 24, 2023 at 3:39 PM Jing Ge

Re: [ANNOUNCE] New Apache Flink PMC Member - Leonard Xu

2023-04-25 Thread Shengkai Fang
Congratulations, Leonard! Best regards, Shengkai Zakelly Lan 于2023年4月24日周一 15:36写道: > Congratulations, Leonard! > > > Best regards, > Zakelly > > On Mon, Apr 24, 2023 at 3:25 PM Jing Ge > wrote: > > > > Congrats! Leonard! > > > > > > > > Best regards, > > > > Jing > > > > On Mon, Apr 24, 2023

[jira] [Created] (FLINK-31943) Multiple t_env cause class loading problem

2023-04-25 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-31943: -- Summary: Multiple t_env cause class loading problem Key: FLINK-31943 URL: https://issues.apache.org/jira/browse/FLINK-31943 Project: Flink Issue Type: Bug

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread ConradJam
Thanks Xintong and Jark for kicking off the great discussion! I checked the list carefully. The plans are detailed and most of the problems are covered Some of the ideas Chesnay mentioned, I think we should iterate in small steps and collect feedback in time Looking forward to the start of the wor

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread eric xiao
Wow, thank you all for the responses! I have opened a PR [1] to address this ticket, would appreciate any feedback - still relatively new to the codebase, so please let me know if I have overlooked anything obvious 😃. [1] https://github.com/apache/flink/pull/22438 On Tue, Apr 25, 2023 at 1:34 PM

[jira] [Created] (FLINK-31942) Support Conditional Writes in DynamoDB connector

2023-04-25 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-31942: --- Summary: Support Conditional Writes in DynamoDB connector Key: FLINK-31942 URL: https://issues.apache.org/jira/browse/FLINK-31942 Project: Flink Issue

[jira] [Created] (FLINK-31941) Not backwards compatible naming for some kubernetes resources

2023-04-25 Thread Eric Xiao (Jira)
Eric Xiao created FLINK-31941: - Summary: Not backwards compatible naming for some kubernetes resources Key: FLINK-31941 URL: https://issues.apache.org/jira/browse/FLINK-31941 Project: Flink Issu

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Jing Ge
Thanks Xingtong and Jark for kicking off and driving the discussion! It is really good to see we finally start talking about Flink 2.0. There are so many great ideas that require breaking API changes and so many tech debts need to be cleaned up. With the Flink 2.0 ahead, we will be more fast-paced

[jira] [Created] (FLINK-31940) DataStreamCsvITCase#CityPojo should be public

2023-04-25 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-31940: Summary: DataStreamCsvITCase#CityPojo should be public Key: FLINK-31940 URL: https://issues.apache.org/jira/browse/FLINK-31940 Project: Flink Issue T

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread Maximilian Michels
+1 On Tue, Apr 25, 2023 at 5:24 PM David Morávek wrote: > > Hi Eric, > > this sounds reasonable, there are definitely cases where you need to limit > sink parallelism for example not to overload the storage or limit the > number of output files > > +1 > > Best, > D. > > On Sun, Apr 23, 2023 at 1:

[jira] [Created] (FLINK-31939) ClassNotFoundException on org.apache.beam.runners.flink.translation.wrappers.SourceInputFormat when running Flink 1.14 and up with Beam 2.46.0

2023-04-25 Thread AmitK (Jira)
AmitK created FLINK-31939: - Summary: ClassNotFoundException on org.apache.beam.runners.flink.translation.wrappers.SourceInputFormat when running Flink 1.14 and up with Beam 2.46.0 Key: FLINK-31939 URL: https://issues.apa

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread David Morávek
Hi Eric, this sounds reasonable, there are definitely cases where you need to limit sink parallelism for example not to overload the storage or limit the number of output files +1 Best, D. On Sun, Apr 23, 2023 at 1:09 PM Weihua Hu wrote: > Hi, Eric > > Thanks for bringing this discussion. > I

[jira] [Created] (FLINK-31938) Failing Unit Test: FlinkConnectionTest.testCatalogSchema "Failed to get response for the operation"

2023-04-25 Thread Kurt Ostfeld (Jira)
Kurt Ostfeld created FLINK-31938: Summary: Failing Unit Test: FlinkConnectionTest.testCatalogSchema "Failed to get response for the operation" Key: FLINK-31938 URL: https://issues.apache.org/jira/browse/FLINK-3193

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Piotr Nowojski
Ok, thanks for the clarification. Piotrek wt., 25 kwi 2023 o 16:38 Chesnay Schepler napisał(a): > The checkstyle rule would just ban certain imports. > We'd add exclusions for all existing usages as we did when introducing > other rules. > So far we usually disabled checkstyle rules for a speci

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Chesnay Schepler
The checkstyle rule would just ban certain imports. We'd add exclusions for all existing usages as we did when introducing other rules. So far we usually disabled checkstyle rules for a specific files. On 25/04/2023 16:34, Piotr Nowojski wrote: +1 to the idea. How would this checkstyle rule w

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread Piotr Nowojski
+1 to the idea. How would this checkstyle rule work? Are you suggesting to start with a number of exclusions? On what level will those exclusions be? Per file? Per line? Best, Piotrek wt., 25 kwi 2023 o 13:18 David Morávek napisał(a): > Hi Everyone, > > A long time ago, the community decided n

[jira] [Created] (FLINK-31937) Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak"

2023-04-25 Thread Kurt Ostfeld (Jira)
Kurt Ostfeld created FLINK-31937: Summary: Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak" Key: FLINK-31937 URL: https://issues.apache.org/jira/browse/FLINK-31937 Project:

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Chesnay Schepler
This is definitely a good discussion so have. Some thoughts: One aspect that wasn't mentioned is what this release means going forward. I already waited a decade for 2.0; don't really want to wait another one to see Flink 3.0. We should discuss how regularly we will ship major releases from no

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Martijn Visser
Hi all, I think it's a great idea to have a concrete planning and roadmap discussion on Flink 2.0. I've also thought on this topic previously and would like to volunteer as one of the release managers. A couple of initial thoughts: * I'm assuming that as a desired outcome of this discussion thre

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Becket Qin
Hi Xintong and Jark, Thanks for starting the discussion about Flink 2.0. This is indeed something that people talk about all the time but without material actions taken. It is good timing to kick off this effort, so we can bring Flink to the next stage and move faster. I'd also volunteer to be a

Re: [DISCUSS] Planning Flink 2.0

2023-04-25 Thread Leonard Xu
Thanks Xintong and Jark for kicking off the great discussion! The time goes so fast, it is already the 10th anniversary of Flink as an Apache project. Although I haven't gone through the proposal carefully, +1 for the perfect release time and the release managers candidates. Best, Leonard >

[jira] [Created] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-31936: - Summary: Support setting scale up max factor Key: FLINK-31936 URL: https://issues.apache.org/jira/browse/FLINK-31936 Project: Flink Issue Type: Improvement

[DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-25 Thread David Morávek
Hi Everyone, A long time ago, the community decided not to use Mockito-based tests because those are hard to maintain. This is already baked in our Code Style and Quality Guide [1]. Because we still have Mockito imported into the code base, it's very easy for newcomers to unconsciously introduce

[DISCUSS] Planning Flink 2.0

2023-04-25 Thread Xintong Song
Hi everyone, I'd like to start a discussion on planning for a Flink 2.0 release. AFAIK, in the past years this topic has been mentioned from time to time, in mailing lists, jira tickets and offline discussions. However, few concrete steps have been taken, due to the significant determination and

Inconsistent Display Formats of TIMESTAMP_LTZ

2023-04-25 Thread Paul Lam
Hi team, I found the string representation of TIMESTAMP_LTZ kind of confusing. SQL client doesn’t display the zone part of TIMESTAMP_LTZ[1], while the serializers do[2]. I did some searching and found that plenty of db clients would display the zone part (handled implicitly), such as Beeline a

[jira] [Created] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-25 Thread Jira
David Morávek created FLINK-31935: - Summary: The new resource requirements REST API is only available for session clusters Key: FLINK-31935 URL: https://issues.apache.org/jira/browse/FLINK-31935 Proje

[jira] [Created] (FLINK-31934) Remove mocking in RocksDB tests

2023-04-25 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-31934: Summary: Remove mocking in RocksDB tests Key: FLINK-31934 URL: https://issues.apache.org/jira/browse/FLINK-31934 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-31933) Remove Whitebox usage in ExpressionKeysTest

2023-04-25 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-31933: Summary: Remove Whitebox usage in ExpressionKeysTest Key: FLINK-31933 URL: https://issues.apache.org/jira/browse/FLINK-31933 Project: Flink Issue Typ

Re:Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-04-25 Thread Mang Zhang
Hi Jing, Yes, the atomic CTAS will be only supported for bounded data, but the execution modes can be stream or batch. I introduced the isStreamingMode parameter in the twoPhaseCreateTable API to make it easier for users to provide different levels of atomicity implementation depending on the ca