[VOTE] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-08 Thread Jing Ge
Hi, I'd like to start a vote on FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode. The discussion can be found at [1]. The vote will last for at least 72 hours (Jan 12th at 9:00 GMT) unless there is an objection or insufficient votes.

Re: [DISCUSS] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-08 Thread Jing Ge
Hi Shammon, Thanks for the feedback. Yes, it will work just like you wished. :) Best regards, Jing On Mon, Jan 9, 2023 at 6:31 AM Shammon FY wrote: > Hi @Jing Ge > > Thanks for the proposal and sorry for joining the discussion late. I met > the same problem when I performed a batch query on sq

[jira] [Created] (FLINK-30603) CompactActionITCase in table store is unstable

2023-01-08 Thread Shammon (Jira)
Shammon created FLINK-30603: --- Summary: CompactActionITCase in table store is unstable Key: FLINK-30603 URL: https://issues.apache.org/jira/browse/FLINK-30603 Project: Flink Issue Type: Bug

[DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-08 Thread weijie guo
Hi devs, I'd like to start a discussion about adding sql-connector's uber jar e2e test for connectors. I know that some connectors like kafka and HBase have corresponding sql connector uber jar's test, which are located in SqlClientITCase and SQLClientHBaseITCase respectively. However, some sql

Re: [DISCUSS] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-08 Thread Shammon FY
Hi @Jing Ge Thanks for the proposal and sorry for joining the discussion late. I met the same problem when I performed a batch query on sql-client and it could not print the whole line of results. I think the FLIP is nice, just one comment: Can users set the parameter dynamically on sql-client wi

[jira] [Created] (FLINK-30602) Remove FileStoreTableITCase in table store

2023-01-08 Thread Shammon (Jira)
Shammon created FLINK-30602: --- Summary: Remove FileStoreTableITCase in table store Key: FLINK-30602 URL: https://issues.apache.org/jira/browse/FLINK-30602 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-08 Thread Jing Ge
Hi Dev, I let the discussion open for a longer time because of the holiday session. It seems there are no concerns about this proposal. I will start a voting thread. Thanks! Best regards, Jing On Fri, Dec 16, 2022 at 11:09 AM Jing Ge wrote: > Hi Dev, > > I'd like to start a discussion about FL

[jira] [Created] (FLINK-30601) Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-08 Thread Lijie Wang (Jira)
Lijie Wang created FLINK-30601: -- Summary: Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance Key: FLINK-30601 URL: https://issues.apache.org/jira/browse/FLINK-30601 Pr

Re: [VOTE]FLIP-266: Simplify network memory configurations for TaskManager

2023-01-08 Thread Yuxin Tan
Hi all, There are 3 bindings, and 1 non-bindings. Based on the result, I have closed the vote with the thread[1]. Thanks again. [1] https://lists.apache.org/thread/m0nt12pvoczlf924bry464ltwdm75lok Best, Yuxin Lijie Wang 于2023年1月4日周三 22:46写道: > +1 (binding) > > Best, > Lijie > > 17610775726 <

Re: [DISCUSS] Adding a option for planner to decide which join reorder rule to choose

2023-01-08 Thread godfrey he
Hi Yunhong, Thanks for driving this discuss! This option looks good to me, and looking forward to contributing this rule back to Apache Calcite. Best, Godfrey yh z 于2023年1月5日周四 15:32写道: > > Hi Benchao, > > Thanks for your reply. > > Since our existing test results are based on multiple perfo

[jira] [Created] (FLINK-30600) Merge flink-table-store-kafka to flink-table-store-connector

2023-01-08 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30600: Summary: Merge flink-table-store-kafka to flink-table-store-connector Key: FLINK-30600 URL: https://issues.apache.org/jira/browse/FLINK-30600 Project: Flink

Re: Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Dong Lin
Hi Martijn, By saying "Each connector defines their own metrics at the moment", what FLIP-33 intends to avoid is that connectA defines a metric named numRecordsIn and connectB defines a metric named numOfRecordsIn. In this case, these two metrics would have the same semantic meaning but different

Re: CDC from Oracle database reading directly logs - integration with OpenLogReplicator

2023-01-08 Thread Adam Leszczyński
Hi Gunnar, Thank you very much for help. I really appreciate it. I believe you might be right. But still Flink has it’s own connector to Oracle which does not require Debezium. I’m not an expert and don’t have a wider view how most customer sites work. My intention was just to clearly shot what

Re: Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Martijn Visser
Hi Dong, In the proposal from Wencong is stated "If source reader want to report to metric by self, it can set source.reader.metric.num_records_in.override to true, which disables the registration of numRecordsIn in SourceReaderBase and let the actual implementation to report the metric instead."

[jira] [Created] (FLINK-30599) Publish SBOM for k8s operator

2023-01-08 Thread Jira
Márton Balassi created FLINK-30599: -- Summary: Publish SBOM for k8s operator Key: FLINK-30599 URL: https://issues.apache.org/jira/browse/FLINK-30599 Project: Flink Issue Type: Sub-task

Re: flink add multiple sink in sequence

2023-01-08 Thread Martijn Visser
Correct. If you want to have guarantees between Sink1 and Sink2, you need to create a combined sink Op zo 8 jan. 2023 om 15:57 schreef Great Info > Does it mean sequence of writing is not guaranteed between these > independent Sink1 and Sink2? > > > > > On Fri, 6 Jan 2023, 10:44 am Shammon FY,

Re: flink add multiple sink in sequence

2023-01-08 Thread Great Info
Does it mean sequence of writing is not guaranteed between these independent Sink1 and Sink2? On Fri, 6 Jan 2023, 10:44 am Shammon FY, wrote: > Hi @Great > > I think the two sinks in your example are equivalent and independent. If > there are some logical relationships between two sinks, you

Re: Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Dong Lin
Hi Martijn, I think the change proposed in this thread would *not* break the idea in FLIP-33. FLIP-33 standardized metrics such as numRecordsIn, by specifying the name/type/semantics of those metrics so that all connectors can follow. The name/type/semantics of numRecordsIn metric would be the sam

[jira] [Created] (FLINK-30598) Wrong code generated for WatermarkGenerator because of inconsistent source type info when deserialized from exec plan

2023-01-08 Thread lincoln lee (Jira)
lincoln lee created FLINK-30598: --- Summary: Wrong code generated for WatermarkGenerator because of inconsistent source type info when deserialized from exec plan Key: FLINK-30598 URL: https://issues.apache.org/jira/b

Re: Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Martijn Visser
Hi all, This feels like we purposely want to abandon the idea that was introduced with FLIP-33 on standardizing metrics [1]. From this proposal, I don't see why we want to abandon that idea. Next to that, if you override the numRecordsIn logic, you also touch on the other metrics that rely on this

Re:Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Wencong Liu
Thanks for the discussion, Dong and John Considering the extra cost of method calls, the approach of adding an extra SourceReaderBase constructor should be a better choice. If there is no further discussion, I will follow this plan. Best, Wencong At 2023-01-08 01:05:07, "Joh

[jira] [Created] (FLINK-30597) Refactor FlinkProjectJoinTransposeRule and FlinkPruneEmptyRules

2023-01-08 Thread Bo Cui (Jira)
Bo Cui created FLINK-30597: -- Summary: Refactor FlinkProjectJoinTransposeRule and FlinkPruneEmptyRules Key: FLINK-30597 URL: https://issues.apache.org/jira/browse/FLINK-30597 Project: Flink Issue Ty