Re: Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations! Cheers, Yufei On Sat, 13 Nov 2021 at 10:10, Yun Gao wrote: > Congratulations Leonard! > > Best, > Yun > > > -- > Sender:Zakelly Lan > Date:2021/11/12 21:09:48 > Recipient: > Theme:Re: [ANNOUNCE] New Apache Flink Co

Re: Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations Leonard! Best, Yun -- Sender:Zakelly Lan Date:2021/11/12 21:09:48 Recipient: Theme:Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu Congratulations :D Best, Zakelly On Fri, Nov 12, 2021 at 5:03 PM Piotr Nowo

Re: Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations Yangze! Best, Yun -- Sender:Piotr Nowojski Date:2021/11/12 17:02:12 Recipient:dev Theme:Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo Congratulations :) Piotrek pt., 12 lis 2021 o 09:43 Lincoln Lee napi

Re: [DISCUSS] Update Policy for old releases

Hi Stephan, Thanks for your email! I agree your points about compatibility and the upgrade experience should be smooth. The problem raised by Pitor is that, even if we officially support two latest versions, many users stay in an early version end-of-support. So the downside "no one ends up using

[jira] [Created] (FLINK-24890) FLIP-189: SQL Client Usability Improvements

Sergey Nuyanzin created FLINK-24890: --- Summary: FLIP-189: SQL Client Usability Improvements Key: FLINK-24890 URL: https://issues.apache.org/jira/browse/FLINK-24890 Project: Flink Issue Type:

Re: [VOTE] FLIP-189: SQL Client Usability Improvements

Hi everyone, I'm happy to announce that we have unanimously approved this FLIP. There are 9 approved votes, 4 of which are binding: Timo Walther (binding) Martijn Visser (non-binding) Konstantin Knauf (binding) Ingo Bürk (non-binding) Till Rohrmann (binding) Jark Wu (binding) Yuepeng Pan (non-bi

Re: [DISCUSS] Update Policy for old releases

I am of a bit different opinion here, I don't think LTS is the best way to go. To my understanding, the big issue faced by users is that an upgrade is simply too hard. Too many things change in subtle ways, you cannot just take the previous application and configuration and expect it to run the sa

[jira] [Created] (FLINK-24889) Flink SQL Client should print corrently multisets

Sergey Nuyanzin created FLINK-24889: --- Summary: Flink SQL Client should print corrently multisets Key: FLINK-24889 URL: https://issues.apache.org/jira/browse/FLINK-24889 Project: Flink Issue

Re: [VOTE] FLIP-188 Introduce Built-in Dynamic Table Storage

Hi everyone, even though the DISCUSS thread was open for 2 weeks. I have the feeling that the VOTE was initiated to quickly. At least a final "I will start the vote soon. Last call for comments." would have been nice. I also added some comments in the DISCUSS thread. Let's hope we can resolv

Re: [DISCUSS] FLIP-188: Introduce Built-in Dynamic Table Storage

Hi everyone, sorry for the delay in joining this thread. I went through the FLIP and have some comments (maybe overlapping with Stephan's comments, which I haven't read yet): a. > More importantly, in order to solve the cognitive bar... It would be great if we can add not only `Receive any t

Re: [DISCUSS] Conventions on assertions to use in tests

JUnit5 migration is currently mostly prepared. The rules are being migrated [1] and Hang and Qingsheng have migrated most tests in their branch afaik (Kudos to them!). Using assertj would make migration easier as it's independent of the JUnit version. But the same can be said about hamcrest, albei

Re: [VOTE] FLIP-188 Introduce Built-in Dynamic Table Storage

Hi all! I have a few questions on the design still, posted those in the [DISCUSS] thread. It would be great to clarify those first before concluding this vote. Thanks, Stephan On Fri, Nov 12, 2021 at 7:22 AM Jark Wu wrote: > +1 (binding) > > Thanks for the great work Jingsong! > > Best, > Jar

Re: [DISCUSS] FLIP-188: Introduce Built-in Dynamic Table Storage

Hi all! Thank you for the writeup of this feature. I like the general direction a lot. There are some open questions and confusing details still, which I think we need to clarify first to make this feature really good. Below are questions/suggestions on the FLIP: Best, Stephan ===

Re: [DISCUSS] Conventions on assertions to use in tests

Thanks for starting this discussion Francesco. I think there is a lot of value in consistency because it makes it a lot easier to navigate and contribute to the code base. The testing tools are definitely one important aspect of consistency. It is a bit unfortunate that we have tests that follow d

Re: [DISCUSS] Conventions on assertions to use in tests

I agree on AssertJ being so much more expressive that I think it would be worth switching. However, we should be careful not to solve the issue of too many assertion frameworks by adding another one on top of everything (but also realizing that we cannot easily migrate all tests in one go). On Fri

Re: [DISCUSS] Conventions on assertions to use in tests

For what it's worth, I recently rewrote all of the tests in flink-training to use assertj, removing a mixture of junit4 assertions and hamcrest in the process. I chose assertj because I found it to be more expressive and made the tests more readable. +1 from me David On Fri, Nov 12, 2021 at 10:0

Re: [DISCUSS] Creating an external connector repository

Hi everyone, I created the flink-connectors repo [1] to advance the topic. We would create a proof-of-concept in the next few weeks as a special branch that I'd then use for discussions. If the community agrees with the approach, that special branch will become the master. If not, we can reiterate

[jira] [Created] (FLINK-24888) Run jobgraph deserialization in separate thread

Chesnay Schepler created FLINK-24888: Summary: Run jobgraph deserialization in separate thread Key: FLINK-24888 URL: https://issues.apache.org/jira/browse/FLINK-24888 Project: Flink Issue

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations :D Best, Zakelly On Fri, Nov 12, 2021 at 5:03 PM Piotr Nowojski wrote: > Congratulations :) > > Piotrek > > pt., 12 lis 2021 o 09:44 Lincoln Lee napisał(a): > > > Congratulations! > > > > > > Best, > > Lincoln Lee > > > > > > > > Dian Fu 于2021年11月12日周五 下午4:35写道： > > > > > Cong

[jira] [Created] (FLINK-24887) Retrying savepoints may cause early cluster shutdown

Chesnay Schepler created FLINK-24887: Summary: Retrying savepoints may cause early cluster shutdown Key: FLINK-24887 URL: https://issues.apache.org/jira/browse/FLINK-24887 Project: Flink

[jira] [Created] (FLINK-24886) flink flame args bug, may we need to modify TimeUtils to supports m

jackylau created FLINK-24886: Summary: flink flame args bug, may we need to modify TimeUtils to supports m Key: FLINK-24886 URL: https://issues.apache.org/jira/browse/FLINK-24886 Project: Flink

[jira] [Created] (FLINK-24885) ProcessElement Interface parameter Collector : java.lang.NullPointerException

wangbaohua created FLINK-24885: -- Summary: ProcessElement Interface parameter Collector : java.lang.NullPointerException Key: FLINK-24885 URL: https://issues.apache.org/jira/browse/FLINK-24885 Project: F

[DISCUSS] Conventions on assertions to use in tests

Hi all, I wonder If we have a convention of the testing tools (in particular assertions) to use in our tests. If not, are modules free to decide on a convention on their own? In case of table, we have a mixed bag of different assertions of all kinds, sometimes mixed even in the same test: - A

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations :) Piotrek pt., 12 lis 2021 o 09:44 Lincoln Lee napisał(a): > Congratulations! > > > Best, > Lincoln Lee > > > > Dian Fu 于2021年11月12日周五 下午4:35写道： > > > Congratulations, Leonard! > > > > Regards, > > Dian > > > > On Fri, Nov 12, 2021 at 4:19 PM Martijn Visser > > wrote: > > > >

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations :) Piotrek pt., 12 lis 2021 o 09:43 Lincoln Lee napisał(a): > Congratulations Yangze! > > Best, > Lincoln Lee > > > Martijn Visser 于2021年11月12日周五 下午4:19写道： > > > Congratulations! > > > > Best regards, > > > > Martijn > > > > On Fri, 12 Nov 2021 at 07:49, Jark Wu wrote: > > > >

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations! Best, Lincoln Lee Dian Fu 于2021年11月12日周五 下午4:35写道： > Congratulations, Leonard! > > Regards, > Dian > > On Fri, Nov 12, 2021 at 4:19 PM Martijn Visser > wrote: > > > Well deserved, congratulations Leonard! > > > > Best regards, > > > > Martijn > > > > On Fri, 12 Nov 2021 at

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations & well deserved, Leonard! Best, Yun Tang Get Outlook for Android From: Dian Fu Sent: Friday, November 12, 2021 4:34:35 PM To: dev Subject: Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu Congratulations, Leonard!

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations Yangze! Best, Lincoln Lee Martijn Visser 于2021年11月12日周五 下午4:19写道： > Congratulations! > > Best regards, > > Martijn > > On Fri, 12 Nov 2021 at 07:49, Jark Wu wrote: > > > Congratulations Yangze! > > > > Best, > > Jark > > > > On Fri, 12 Nov 2021 at 14:06, JING ZHANG wrote: > >

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations, Yangze! Best, Yun Tang Get Outlook for Android From: Dian Fu Sent: Friday, November 12, 2021 4:34:53 PM To: dev Subject: Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo Congratulations! Regards, Dian On Fri, No

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations! Regards, Dian On Fri, Nov 12, 2021 at 4:34 PM Till Rohrmann wrote: > Congratulations! > > Cheers, > Till > > On Fri, Nov 12, 2021 at 9:19 AM Martijn Visser > wrote: > > > Congratulations! > > > > Best regards, > > > > Martijn > > > > On Fri, 12 Nov 2021 at 07:49, Jark Wu wrot

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations, Leonard! Regards, Dian On Fri, Nov 12, 2021 at 4:19 PM Martijn Visser wrote: > Well deserved, congratulations Leonard! > > Best regards, > > Martijn > > On Fri, 12 Nov 2021 at 08:44, Caizhi Weng wrote: > > > Congrats, Leonard! > > > > Shuo Cheng 于2021年11月12日周五 下午3:12写道： > > >

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Congratulations! Cheers, Till On Fri, Nov 12, 2021 at 9:19 AM Martijn Visser wrote: > Well deserved, congratulations Leonard! > > Best regards, > > Martijn > > On Fri, 12 Nov 2021 at 08:44, Caizhi Weng wrote: > > > Congrats, Leonard! > > > > Shuo Cheng 于2021年11月12日周五 下午3:12写道： > > > > > Congr

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations! Cheers, Till On Fri, Nov 12, 2021 at 9:19 AM Martijn Visser wrote: > Congratulations! > > Best regards, > > Martijn > > On Fri, 12 Nov 2021 at 07:49, Jark Wu wrote: > > > Congratulations Yangze! > > > > Best, > > Jark > > > > On Fri, 12 Nov 2021 at 14:06, JING ZHANG wrote: >

Re: [ANNOUNCE] New Apache Flink Committer - Leonard Xu

Well deserved, congratulations Leonard! Best regards, Martijn On Fri, 12 Nov 2021 at 08:44, Caizhi Weng wrote: > Congrats, Leonard! > > Shuo Cheng 于2021年11月12日周五 下午3:12写道： > > > Congrats, Leonard! > > > > On Fri, Nov 12, 2021 at 2:35 PM godfrey he wrote: > > > > > Congrats & well deserved, L

Re: [ANNOUNCE] New Apache Flink Committer - Yangze Guo

Congratulations! Best regards, Martijn On Fri, 12 Nov 2021 at 07:49, Jark Wu wrote: > Congratulations Yangze! > > Best, > Jark > > On Fri, 12 Nov 2021 at 14:06, JING ZHANG wrote: > > > Congrats! > > > > Best, > > Jing Zhang > > > > Lijie Wang 于2021年11月12日周五 下午1:25写道： > > > > > Congrats Yangz

Re: [DISCUSS] Update Policy for old releases

Thanks for bringing this up for discussion Piotr. One the one hand I think it's a good idea, because of the reasons you've mentioned. On the other hand, having an LTS version will remove an incentive for some users to upgrade, which will result in fewer Flink users who will test new features becaus