[jira] [Created] (FLINK-23161) Cannot have more than one execute() or executeAsync() call in a single environment.

2021-06-25 Thread roberto hashioka (Jira)
roberto hashioka created FLINK-23161: Summary: Cannot have more than one execute() or executeAsync() call in a single environment. Key: FLINK-23161 URL: https://issues.apache.org/jira/browse/FLINK-23161

Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-25 Thread Wenhao Ji
Thanks Stephan and Piotr for your replies. It seems that there is no problem or concern about this feature. If there is no further objection, I will start a vote thread for FLIP-172. Thanks, Wenhao On Wed, Jun 23, 2021 at 3:41 PM Piotr Nowojski wrote: > > Hi, > > +1 from my side on this idea. I

[RESULT][VOTE] FLIP-171: Async Sink

2021-06-25 Thread Hausmann, Steffen
Hi there, The voting time of FLIP-171 [1] has passed. I'm closing the vote now. There were four +1 votes, all of which are binding: - Arvid Heise (binding) - Danny Cranmer (binding) - 刘建刚 (binding) - Piotr Nowojski (binding) Poitr had some smaller comments on the implementation details of the s

Re: [DISCUSS] FLIP-171: Async Sink

2021-06-25 Thread Hausmann, Steffen
Hi Piotr, I’m happy to take your guidance on this. I need to think through your proposals and I’ll follow-up on Monday with some more context so that we can close the discussion on these details. But for now, I’ll close the vote. Thanks, Steffen From: Piotr Nowojski Date: Friday, 25. June 202

[jira] [Created] (FLINK-23160) upgrade kafka-schema-registry-client to 6.1.2 for Flink-avro-confluent-registry

2021-06-25 Thread Lian Jiang (Jira)
Lian Jiang created FLINK-23160: -- Summary: upgrade kafka-schema-registry-client to 6.1.2 for Flink-avro-confluent-registry Key: FLINK-23160 URL: https://issues.apache.org/jira/browse/FLINK-23160 Project:

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-25 Thread Piotr Nowojski
Thanks for the clarification Till. +1 for what you have written. Piotrek pt., 25 cze 2021 o 16:00 Till Rohrmann napisał(a): > One quick note for clarification. I don't have anything against builds > running on your personal Azure account and this is not what I understood > under "local environm

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-25 Thread Till Rohrmann
One quick note for clarification. I don't have anything against builds running on your personal Azure account and this is not what I understood under "local environment". For me "local environment" means that someone runs the test locally on his machine and then says that the tests have passed loca

Re: [DISCUSS] Incrementally deprecating the DataSet API

2021-06-25 Thread Etienne Chauchot
Hi everyone, @Timo, my comments are inline for steps 2, 4 and 5, please tell me what you think. Best Etienne On 23/06/2021 15:27, Chesnay Schepler wrote: If we want to publicize this plan more shouldn't we have a rough timeline for when 2.0 is on the table? On 6/23/2021 2:44 PM, Stephan

Re: [VOTE] FLIP-171: Async Sink

2021-06-25 Thread Piotr Nowojski
+1 (binding) vote with one remark that I posted in the discussion thread. Best, Piotrek pt., 25 cze 2021 o 05:00 刘建刚 napisał(a): > A common base for implementing sink is really helpful. > +1 (binding) > > Thanks > liujiangang > > Danny Cranmer 于2021年6月24日周四 下午7:10写道: > > > Looking forward to s

Re: [DISCUSS] FLIP-171: Async Sink

2021-06-25 Thread Piotr Nowojski
Hey, I've just synced with Arvid about a couple of more remarks from my side and he shared mine concerns. 1. I would very strongly recommend ditching `CompletableFuture ` from the `protected abstract CompletableFuture submitRequestEntries(List requestEntries);` in favor of something like `org.a

[jira] [Created] (FLINK-23159) Correlated sql subquery on the source created via fromValues() failed to compile

2021-06-25 Thread Yun Gao (Jira)
Yun Gao created FLINK-23159: --- Summary: Correlated sql subquery on the source created via fromValues() failed to compile Key: FLINK-23159 URL: https://issues.apache.org/jira/browse/FLINK-23159 Project: Flink

[jira] [Created] (FLINK-23158) Source transformation is not added to the StreamExecutionEnvironment explicitly

2021-06-25 Thread Yun Gao (Jira)
Yun Gao created FLINK-23158: --- Summary: Source transformation is not added to the StreamExecutionEnvironment explicitly Key: FLINK-23158 URL: https://issues.apache.org/jira/browse/FLINK-23158 Project: Flink

[jira] [Created] (FLINK-23157) Fix missing comma in SQL example in "Versioned Table" page

2021-06-25 Thread HanWei (Jira)
HanWei created FLINK-23157: -- Summary: Fix missing comma in SQL example in "Versioned Table" page Key: FLINK-23157 URL: https://issues.apache.org/jira/browse/FLINK-23157 Project: Flink Issue Type: Im

[jira] [Created] (FLINK-23156) Change the reference of 'docs/dev/table/sql/queries'

2021-06-25 Thread zoucao (Jira)
zoucao created FLINK-23156: -- Summary: Change the reference of 'docs/dev/table/sql/queries' Key: FLINK-23156 URL: https://issues.apache.org/jira/browse/FLINK-23156 Project: Flink Issue Type: Improvem

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-25 Thread Piotr Nowojski
+1 for the general idea, however I have concerns about a couple of details. > I would first try to not introduce the exception for local builds. > It makes it quite hard for others to verify the build and to make sure that the right things were executed. I would counter Till's proposal to ignore