Re: [VOTE] Release 1.6.1, release candidate #1

2018-09-19 Thread shimin yang
-1 Could you merge the FLINK-10243 into release 1.6.1. I think the configurable latency metrics will be quite useful and not much work to merge. Best, Shimin vino yang 于2018年9月20日周四 下午2:08写道： > +1 > > I checked the new Flink version in the root pom file. > I checked the announcement blog post

Re: [VOTE] Release 1.6.1, release candidate #1

2018-09-19 Thread vino yang
+1 I checked the new Flink version in the root pom file. I checked the announcement blog post and make sure the version number is right. I checked out the source code and ran mvn package (without test) Thanks, vino. Fabian Hueske 于2018年9月20日周四 上午4:54写道： > +1 binding > > * I checked the diffs

[jira] [Created] (FLINK-10373) CoGroup Window support lateness

2018-09-19 Thread huangzhenhua (JIRA)
huangzhenhua created FLINK-10373: Summary: CoGroup Window support lateness Key: FLINK-10373 URL: https://issues.apache.org/jira/browse/FLINK-10373 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-10372) There is no API to configure the timer state backend

2018-09-19 Thread Elias Levy (JIRA)
Elias Levy created FLINK-10372: -- Summary: There is no API to configure the timer state backend Key: FLINK-10372 URL: https://issues.apache.org/jira/browse/FLINK-10372 Project: Flink Issue Type:

Re: [VOTE] Release 1.5.4, release candidate #1

2018-09-19 Thread Fabian Hueske
+1 binding * I checked the diffs and did not find any added dependencies or updated dependency versions. * I checked the sha hash and signatures of all release artifacts. Best, Fabian 2018-09-15 23:26 GMT+02:00 Till Rohrmann : > Hi everyone, > Please review and vote on the release candidate #1

Re: [VOTE] Release 1.6.1, release candidate #1

2018-09-19 Thread Fabian Hueske
+1 binding * I checked the diffs and did not find any added dependencies or updated dependency versions. * I checked the sha hash and signatures of all release artifacts. Best, Fabian 2018-09-19 11:43 GMT+02:00 Gary Yao : > +1 (non-binding) > > Ran test suite from the flink-jepsen project on AW

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Thomas Weise
Follow-up regarding the PR template that pops up when opening a PR: I think what we have now is a fairly big blob of text that jumps up a bit unexpectedly for a first time contributor and is also cumbersome to deal with in the small PR description window. Perhaps we can improve it a bit: * Instea

[jira] [Created] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-19 Thread Johannes Dillmann (JIRA)
Johannes Dillmann created FLINK-10371: - Summary: Allow to enable SSL mutual authentication on REST endpoints by configuration Key: FLINK-10371 URL: https://issues.apache.org/jira/browse/FLINK-10371

[jira] [Created] (FLINK-10370) DistributedCache does not work in job cluster mode.

2018-09-19 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-10370: Summary: DistributedCache does not work in job cluster mode. Key: FLINK-10370 URL: https://issues.apache.org/jira/browse/FLINK-10370 Project: Flink I

***UNCHECKED*** [jira] [Created] (FLINK-10369) Enable YARNITCase

2018-09-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10369: - Summary: Enable YARNITCase Key: FLINK-10369 URL: https://issues.apache.org/jira/browse/FLINK-10369 Project: Flink Issue Type: Improvement Compone

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread 陈梓立
Hi, I would prefer the integrated idea and could help to concrete it. Posting a review template once a pull request created. This is regarded as the formal process reviews to follow. Posting a checklist in form and make it editable for maintainer. [ ] Reach consensus [ ] Implementation architect

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Fabian Hueske
Hi, I'd like to suggest that we keep this thread focused on discussing Stephan's proposal, i.e., introducing a structured PR review process. Tison and Piotr raised some good points related to PR reviews that are definitely worth discussing, but I think we should do that on different threads and mo

[jira] [Created] (FLINK-10368) 'Kerberized YARN on Docker test' instable

2018-09-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10368: - Summary: 'Kerberized YARN on Docker test' instable Key: FLINK-10368 URL: https://issues.apache.org/jira/browse/FLINK-10368 Project: Flink Issue Type: Bug

Re: [VOTE] Release 1.6.1, release candidate #1

2018-09-19 Thread Gary Yao
+1 (non-binding) Ran test suite from the flink-jepsen project on AWS EC2 without issues. Best, Gary On Sat, Sep 15, 2018 at 11:32 PM, Till Rohrmann wrote: > Hi everyone, > Please review and vote on the release candidate #1 for the version 1.6.1, > as follows: > [ ] +1, Approve the release > [

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread 陈梓立
Hi Piotr, I strongly agree with your idea. Since we work on a huge project, diff in the PR becomes hard to review if there is too much noise. Just to clarify the process. Do you mean that a pull request should go into the way below? Separated commits during the implement, mainly distinguish feat

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Piotr Nowojski
Hi, I would like to rise one more issue. Often contributions are very heavy and difficult to review. They have one big commit that changes multiple things which is difficult to review. Instead I would be in favour of implementing a rule, that a single commit should never do more then one thing.

***UNCHECKED*** [jira] [Created] (FLINK-10367) Avoid recursion stack overflow during releasing SingleInputGate

2018-09-19 Thread zhijiang (JIRA)
zhijiang created FLINK-10367: Summary: Avoid recursion stack overflow during releasing SingleInputGate Key: FLINK-10367 URL: https://issues.apache.org/jira/browse/FLINK-10367 Project: Flink Issu