Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread 陈梓立
Put some good cases here might be helpful. See how a contribution of runtime module be proposed, discussed, implemented and merged from https://github.com/apache/flink/pull/5931 to https://github.com/apache/flink/pull/6132. 1. #5931 fix a bug, but remains points could be improved. Here sihuazhou

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread 陈梓立
Maybe a little rearrange to the process would help. (1). Does the contributor describe itself well? (1.1) By whom this contribution should be given attention. This often shows by its title, "[FLINK-XXX] [module]", the module part infer. (1.2) What the purpose of this contribution is. Done by t

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread Stephan Ewen
On the template discussion, some thoughts *PR Template* I think the PR template went well. We can rethink the "checklist" at the bottom, but all other parts turned out helpful in my opinion. With the amount of contributions, it helps to ask the contributor to take a little more work in order for

Re: CEP & checkpoints/savepoints

2018-09-18 Thread Dawid Wysakowicz
Hi Ron, Fabian is absolutely right. CEP library uses standard checkpointing mechanisms of Flink. You do not need any additional configuration. The only consideration one has to think of is that if you change some conditions in your Pattern, and restart from checkpoint/savepoint you might get some

Re: Watermark alignment during unit tests

2018-09-18 Thread Kostas Kloudas
Hi Eugen, It is true that for ITcases this can be difficult and this should be improved in Flink’s testing infrastructure, but for this specific PR, what you need to check is if the allowedLateness parameter is propagated correctly throughout the translation process. The window operator with all

[jira] [Created] (FLINK-10366) Create a shared base for S3 file systems

2018-09-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10366: Summary: Create a shared base for S3 file systems Key: FLINK-10366 URL: https://issues.apache.org/jira/browse/FLINK-10366 Project: Flink Issue Type: Improvem

Watermark alignment during unit tests

2018-09-18 Thread Евгений Юшин
Hi devs During the work on https://issues.apache.org/jira/browse/FLINK-10050 I've found unstable behaviour of unit tests for unioned streams (which are used in CoGroupedStream/JoinedStream under the hood). Let's assume we have late elements in one of the stream. The thing is we have no guarantees

[jira] [Created] (FLINK-10365) Consolidate shaded Hadoop classes for filesystems

2018-09-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10365: Summary: Consolidate shaded Hadoop classes for filesystems Key: FLINK-10365 URL: https://issues.apache.org/jira/browse/FLINK-10365 Project: Flink Issue Type:

[jira] [Created] (FLINK-10364) Test instability in NonHAQueryableStateFsBackendITCase#testMapState

2018-09-18 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-10364: --- Summary: Test instability in NonHAQueryableStateFsBackendITCase#testMapState Key: FLINK-10364 URL: https://issues.apache.org/jira/browse/FLINK-10364 Project: Flink

[jira] [Created] (FLINK-10363) S3 FileSystem factory prints secrets into logs

2018-09-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10363: Summary: S3 FileSystem factory prints secrets into logs Key: FLINK-10363 URL: https://issues.apache.org/jira/browse/FLINK-10363 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-10362) Bundles S3 connectors load wrong Hadoop config

2018-09-18 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10362: Summary: Bundles S3 connectors load wrong Hadoop config Key: FLINK-10362 URL: https://issues.apache.org/jira/browse/FLINK-10362 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-10361) Elasticsearch (v6.3.1) sink end-to-end test instable

2018-09-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10361: - Summary: Elasticsearch (v6.3.1) sink end-to-end test instable Key: FLINK-10361 URL: https://issues.apache.org/jira/browse/FLINK-10361 Project: Flink Issue