[jira] [Created] (FLINK-2535) Fixed size sample algorithm optimization

Chengxiang Li created FLINK-2535: Summary: Fixed size sample algorithm optimization Key: FLINK-2535 URL: https://issues.apache.org/jira/browse/FLINK-2535 Project: Flink Issue Type: Improvemen

[jira] [Created] (FLINK-2534) Improve execution code in CompactingHashTable.java

Huang Wei created FLINK-2534: Summary: Improve execution code in CompactingHashTable.java Key: FLINK-2534 URL: https://issues.apache.org/jira/browse/FLINK-2534 Project: Flink Issue Type: Improvem

[jira] [Created] (FLINK-2533) Gap based random sample optimization

Chengxiang Li created FLINK-2533: Summary: Gap based random sample optimization Key: FLINK-2533 URL: https://issues.apache.org/jira/browse/FLINK-2533 Project: Flink Issue Type: Improvement

Re: [NOTICE] Reporting and fixing minor issues

+1 as well. This is a great follow-up from my previous email about adding details in JIRA, which also being echoed by Fabian. - Henry On Sun, Aug 16, 2015 at 3:45 PM, Fabian Hueske wrote: > +1 from me as well. > > I'd like to add that there are many relevant issues in listed in JIRA that > repo

Re: [NOTICE] Reporting and fixing minor issues

+1 from me as well. I'd like to add that there are many relevant issues in listed in JIRA that report bugs or describe interesting / important improvements of the system. Working on one of these issues would be a great contribution to Flink. Cheers, Fabian 2015-08-16 18:30 GMT+02:00 Sachin Goel

Re: [Proposal] Addition to Gelly

I think skewed graphs can be considered quite common, i.e., not a corner case. So if there is code to significantly speed up computations on such graphs, this would definitely be interesting for Gelly, IMO. Would it be possible to integrate your approach with existing library algorithms and offer

Re: [ANNOUNCEMENT] Please add more Description and information to JIRA issues

+1 for what Henry said. Recently, several JIRA issues were opened without a detailed description but which were immediately addressed by a pull request. This is probably because our coding guidelines state that each PR should refer to a JIRA issue [1]. The rational behind this guideline is to have

Re: [FAILING TEST] BlobLibraryCacheManagerTest

Looks like a rare race between the cleanup (two changes) and the test validating both changes. I'll push a fix to make the test more reliable. On Sun, Aug 16, 2015 at 11:04 PM, Matthias J. Sax < mj...@informatik.hu-berlin.de> wrote: > Hi, > > I hit a failing test in flink-runtime. Not sure if it

[FAILING TEST] BlobLibraryCacheManagerTest

Hi, I hit a failing test in flink-runtime. Not sure if it is known already: > Failed tests: > CheckpointCoordinatorTest.testCheckpointTimeoutIsolated:594 expected:<0> but > was:<1> Please see: https://travis-ci.org/mjsax/flink/jobs/75847501 -Matthias signature.asc Description: OpenPGP digi

Re: [NOTICE] Reporting and fixing minor issues

I agree! A good place to start would be to write an extensive JIRA guidelines page, an example would be https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark. This is quite crisp and clear. Further, right now the corresponding guidelines for Flink are on the cwiki page, but the ma

Re: Code style guideline for Scala

+1 for formatting templates for Eclipse and IntelliJ. On Sun, Aug 16, 2015 at 6:06 PM, Sachin Goel wrote: > We should also write up a matching configuration file to be used in the > IDEs and provide it with the source. This might help in reducing any style > mistakes due to a reformat, which is

Re: Code style guideline for Scala

We should also write up a matching configuration file to be used in the IDEs and provide it with the source. This might help in reducing any style mistakes due to a reformat, which is actually very helpful with spaces around braces and operators. Especially with Scala, indentations and continuation

[NOTICE] Reporting and fixing minor issues

Hi all! Henry raised the point about non.descriptive bug reports earlier. I would like to bring this to everyone's mind again and add some additional thoughts: We are seeing a lot of issues reported right now, and a lot of pull requests opened right now, for issues that are not really a problem.

Re: Code style guideline for Scala

Hi! I very much support that. A bit stricter rules in the style checkers lead to more uniform and better readable code. We can have stricter rules both in Java and Scala. Note that the hardest part of adding the style checks is actually adjusting all the existing code that violates the style. Th

Code style guideline for Scala

Hi All, I’m reviewing some pull requests written in Scala. While reviewing, I think that scala style checker is too loose and documentation about code style guideline in wiki [1] is poor. The code style for Scala doesn’t seems unified as that for Java. I suggest upgrading version of scalastyle

[jira] [Created] (FLINK-2532) The function name and the variable name are same, it is confusing

zhangrucong created FLINK-2532: -- Summary: The function name and the variable name are same, it is confusing Key: FLINK-2532 URL: https://issues.apache.org/jira/browse/FLINK-2532 Project: Flink

[ANNOUNCEMENT] Please add more Description and information to JIRA issues

Hi All, Apology for the cross-posting. Please remember to add detail Description in the JIRA ticket to help reproduce and prioritize the issues. Assume that some other people will try to solve and reproduce the issues. Adding information in JIRA issues is to help describe the issue and steps to

[jira] [Created] (FLINK-2531) combining the "if" branch to improve the performance

zhangrucong created FLINK-2531: -- Summary: combining the "if" branch to improve the performance Key: FLINK-2531 URL: https://issues.apache.org/jira/browse/FLINK-2531 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-2530) optimize equal() of AcknowledgeCheckpoint

fangfengbin created FLINK-2530: -- Summary: optimize equal() of AcknowledgeCheckpoint Key: FLINK-2530 URL: https://issues.apache.org/jira/browse/FLINK-2530 Project: Flink Issue Type: Bug