Right now it's mostly under-the-hood changes but you can look at the
progress here: https://github.com/aljoscha/flink/tree/stream-api-rework
The commit is going to change, so if you do put your work on top of it you
might have to rebase.
On Wed, 29 Jul 2015 at 07:26 Matthias J. Sax
wrote:
> My
My current work depends on a clean design of those. Otherwise, my own
code would get very messy. I would like to apply some changes in my own
PR (not opened yet). Do you thinks this is feasible? I don't want get in
a messy state. What kind of changes are you going to apply in FLINK-2398?
-Matthias
Ufuk Celebi created FLINK-2424:
--
Summary: InstantiationUtil.serializeObject(Object) does not close
output stream
Key: FLINK-2424
URL: https://issues.apache.org/jira/browse/FLINK-2424
Project: Flink
I think no one here is adamant about reverting anything for the sake of
reverting. Adding the test now is just fine.
The issue was declaring something as fixed and pushing the responsibility
for testing that away. I agree with Robert that this is not the type of
example by which we should lead the
Sounds reasonable to me.
In addition to the test-inclusion guideline, we should also pay more
attention to our single-change-per-PR rule (or commit in case of push
without PR) to avoid discussions about unrelated changes in the future.
Cheers, Fabian
2015-07-28 22:44 GMT+02:00 Gyula Fóra :
> H
Hey,
I think there is no reason for making a more serious issue out of this than
it already is :)
I have opened a pull request that adds the missing test for FLINK-2419:
https://github.com/apache/flink/pull/947
There everyone can verify that my commit has actually fixed the problem.
This should h
Yes, very good points. I think we will be fixing these when we do the API
cleanups that we discussed on the wiki design docs. In fact, the work I'm
doing on https://issues.apache.org/jira/browse/FLINK-2398 can be seen as
preparation for making these changes possible/easier.
On Tue, 28 Jul 2015 at
Hi,
I am a little bit confused about the class hierarchy of DataStream. It
has three subclasses: KeyedDataStream, SingleOutputStreamOperator, and
SplitDataStream.
1) Why is the name "SingleOutputStreamOperator" (why OPERATOR ??)
2) Is it correct, that a SplitDataStream emit multiple logical outp
On Tue, Jul 28, 2015 at 9:09 PM, Gyula Fóra wrote:
> I agree that consensus should be reached in all changes to the system.
>
>
Then Robert and you should reach consensus on FLINK-2419.
> What is not clear to me is what is the subject of consensus in this case.
>
> As for FLINK-2423, this is cl
To properly abstract the resource manager behind an interface, it would be
good to see what the common overlap of the YARN integration, and the
pending mesos integration is.
Can anyone working on this chime in?
On Tue, Jul 28, 2015 at 1:08 PM, Stephan Ewen wrote:
> I think what MaGuoWei is lo
Good idea!
On Mon, Jul 27, 2015 at 10:31 AM, Maximilian Michels wrote:
> We could open a pull request against the linguist repository which holds
> the exclusion rules for the graph. It already has rules to exclude minified
> Javascript files. We might be able to exclude ours too if its name fol
I agree that consensus should be reached in all changes to the system.
What is not clear to me is what is the subject of consensus in this case.
As for FLINK-2423, this is clearly an issue, and the only question here is
whether my solution solves it or not. I think it is fair to say that this
is
I am not familiar with this part of the code, but this is perhaps a good
thing, as this is a matter of policy, not who introduced which bug (I
suspect that the policy issue was Robert's motivation for starting a thread
at the dev list)
So, I think we have two issues:
(1) Pull request https://gith
What concerns me here is that for FLINK-2419 I clearly indicated that there
is a test in my other PR, and since the fix was actually trivial, which
didn't break the current functionality according my test, I wanted to push
it in before my PR because that is pending on something else. I could have
a
Hey,
I am sorry that you feel bad about this, I only did not add a test
case for FLINK-2419
because I am adding a test in my upcoming PR which verified the behaviour.
As for FLINK-2423, it is actually very bad that issue is still there. You
introduced this in your PR https://github.com/apache/fli
I'm probably lacking a bit of context, but by reading your conversation at
JIRA it seems to me that commit
https://github.com/apache/flink/commit/78fd2146dd00da1130910d9f23f09e2504854ef7
does not contain a test, and Robert is asking for a test which means that
we do not have consensus. If this wa
Hi,
I'm a bit unhappy how we were handling
https://issues.apache.org/jira/browse/FLINK-2419 today.
I raised a concern in the JIRA because the commit for the fix didn't
contain any tests. Our coding guidelines [1] imply that every feature
should have tests. Apparently there were not enough tests f
Sounds very good, thanks Vasia!
+1
On Tue, Jul 28, 2015 at 5:48 PM, Till Rohrmann wrote:
> Sounds reasonable to me. +1
>
> On Tue, Jul 28, 2015 at 4:14 PM, Vasiliki Kalavri <
> vasilikikala...@gmail.com
> > wrote:
>
> > Hello squirrels,
> >
> > adding Gelly examples has been a great way to let
Gyula Fora created FLINK-2423:
-
Summary: Properly test checkpoint notifications
Key: FLINK-2423
URL: https://issues.apache.org/jira/browse/FLINK-2423
Project: Flink
Issue Type: Improvement
Sounds reasonable to me. +1
On Tue, Jul 28, 2015 at 4:14 PM, Vasiliki Kalavri wrote:
> Hello squirrels,
>
> adding Gelly examples has been a great way to let in new contributors and
> we have had quite a big number of contributions!
> However, I think it's about time we re-organize and clean the
Robert Metzger created FLINK-2422:
-
Summary: Web client is showing a blank page if "Meta refresh" is
disabled
Key: FLINK-2422
URL: https://issues.apache.org/jira/browse/FLINK-2422
Project: Flink
Stephan Ewen created FLINK-2421:
---
Summary: StreamRecordSerializer incorrectly duplicates and misses
tests
Key: FLINK-2421
URL: https://issues.apache.org/jira/browse/FLINK-2421
Project: Flink
I
Hello squirrels,
adding Gelly examples has been a great way to let in new contributors and
we have had quite a big number of contributions!
However, I think it's about time we re-organize and clean them up a bit.
We currently have 13 examples.
- 5 examples simply use vertex-centric library metho
Gyula Fora created FLINK-2419:
-
Summary: DataStream sinks lose key information
Key: FLINK-2419
URL: https://issues.apache.org/jira/browse/FLINK-2419
Project: Flink
Issue Type: Bug
Compo
Stephan Ewen created FLINK-2420:
---
Summary: OutputFlush thread in stream writers does not propagate
exceptions
Key: FLINK-2420
URL: https://issues.apache.org/jira/browse/FLINK-2420
Project: Flink
Stephan Ewen created FLINK-2418:
---
Summary: Add an end-to-end streaming fault tolerance test for the
Checkpointed interface
Key: FLINK-2418
URL: https://issues.apache.org/jira/browse/FLINK-2418
Project:
I think what MaGuoWei is looking for is "intra-job" YARN elasticity.
Adding these hooks is going to be important also to trigger streaming jobs
to scale in/out during runtime.
On Tue, Jul 28, 2015 at 3:27 AM, MaGuoWei wrote:
> thanks all you guys.Now I know I can achieve this goal by creating a
Sachin Goel created FLINK-2417:
--
Summary: Travis build failure on flink-tachyon
Key: FLINK-2417
URL: https://issues.apache.org/jira/browse/FLINK-2417
Project: Flink
Issue Type: Bug
R
Yeah, go ahead.
On Tue, Jul 28, 2015 at 10:52 AM, Sachin Goel
wrote:
> Should I open a JIRA for this?
>
> -- Sachin Goel
> Computer Science, IIT Delhi
> m. +91-9871457685
>
> On Tue, Jul 28, 2015 at 2:16 PM, Stephan Ewen wrote:
>
> > I have seen that issue before.
> >
> > Since Flink only tes
If it's a bug in Hadoop or Tachyon, then we can hardly do anything about it.
On Tue, Jul 28, 2015 at 10:52 AM, Sachin Goel
wrote:
> Should I open a JIRA for this?
>
> -- Sachin Goel
> Computer Science, IIT Delhi
> m. +91-9871457685
>
> On Tue, Jul 28, 2015 at 2:16 PM, Stephan Ewen wrote:
>
> >
Should I open a JIRA for this?
-- Sachin Goel
Computer Science, IIT Delhi
m. +91-9871457685
On Tue, Jul 28, 2015 at 2:16 PM, Stephan Ewen wrote:
> I have seen that issue before.
>
> Since Flink only tests using Tachyon via the Hadoop connector, this is
> either a bug in the Hadoop connector or
I have seen that issue before.
Since Flink only tests using Tachyon via the Hadoop connector, this is
either a bug in the Hadoop connector or in Tachyon. Since Tachyon probably
uses Unsafe as well, it may just be a bug that causes a segfault...
On Tue, Jul 28, 2015 at 10:16 AM, Sachin Goel
wrote
Piotr Godek created FLINK-2416:
--
Summary: Expose vertex using with the new URL scheme
Key: FLINK-2416
URL: https://issues.apache.org/jira/browse/FLINK-2416
Project: Flink
Issue Type: Improvement
Yes. I've never encountered this type of build failure.
-- Sachin Goel
Computer Science, IIT Delhi
m. +91-9871457685
On Jul 28, 2015 1:41 PM, "Till Rohrmann" wrote:
> This might be a Travis hick-up. Was it the first time this happened?
>
> Cheers,
> Till
>
> On Mon, Jul 27, 2015 at 9:47 PM, Sach
This might be a Travis hick-up. Was it the first time this happened?
Cheers,
Till
On Mon, Jul 27, 2015 at 9:47 PM, Sachin Goel
wrote:
> A recent travis build[Job 3] on my forked repo failed with the following
> error:
>
> Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2
35 matches
Mail list logo
