Re: Semantic Properties and Functions with Iterables

2015-03-08 Thread Fabian Hueske
I added you comment and an answer to FLINK-1656: "Right, that's a good point. +1 limiting to key fields. That's much easier to reason about for users. However, I am not sure how it is implemented right now. I guess secondary sort info is already removed by the property filtering, but I need to v

[DISCUSS] Issues with heterogeneity of the code

2015-03-08 Thread Stephan Ewen
Hi everyone! I would like to start an open discussion about some issue with the heterogeneity of the Flink code base. We have, since the beginning in Apache (and even since we started the predecessor project, Stratosphere) refrained from strictly enforcing conventions like formatting, style, or l

Re: Semantic Properties and Functions with Iterables

2015-03-08 Thread Stephan Ewen
Any other thoughts in this? On Fri, Mar 6, 2015 at 12:12 PM, Stephan Ewen wrote: > I think the order of emitting elements is not part of the forward field > properties, but would rather be a separate one that we do not have right > now. > > At the moment, we would assume that all group operation

Re: Website documentation minor bug

2015-03-08 Thread Stephan Ewen
I agree, it is not optimal. What would be a better way to do this? Have the main navigation (currently on the left) at the top, and the per-page navigation on the side? Do you want to take a stab at this? On Sun, Mar 8, 2015 at 7:08 PM, Hermann Gábor wrote: > Hey, > > Currently following an an

Website documentation minor bug

2015-03-08 Thread Hermann Gábor
Hey, Currently following an anchor link (e.g. #transformations ) results in the header occupying the top of the page, thus the title and some of the first lines cannot be seen. This is not a big deal, but

Re: "Validate" (commons) versus "checkArgument" (guava)

2015-03-08 Thread Aljoscha Krettek
+1 I also tend to use guava. On Sun, Mar 8, 2015 at 3:21 PM, Ufuk Celebi wrote: > > On 08 Mar 2015, at 15:05, Stephan Ewen wrote: > >> Different parts of the code currently use different utilities to validate >> the arguments. >> >> - Some parts use Guava (checkNotNull, checkArgument) >> - Oth

Re: "Validate" (commons) versus "checkArgument" (guava)

2015-03-08 Thread Ufuk Celebi
On 08 Mar 2015, at 15:05, Stephan Ewen wrote: > Different parts of the code currently use different utilities to validate > the arguments. > > - Some parts use Guava (checkNotNull, checkArgument) > - Other parts use Validate from Apache commons-lang(3). > > How about we use one consistently,

"Validate" (commons) versus "checkArgument" (guava)

2015-03-08 Thread Stephan Ewen
Different parts of the code currently use different utilities to validate the arguments. - Some parts use Guava (checkNotNull, checkArgument) - Other parts use Validate from Apache commons-lang(3). How about we use one consistently, at least for all new code additions? In choosing one, I hav

Re: Running example in IntelliJ

2015-03-08 Thread Stephan Ewen
If you run it from the IDE, the logging depends on whether you have a "log4j.properties" file in your classpath. The simplest way to do this is to copy on of the existing ones temporarily into the projects "src/main/resources" folder. I usually use the one in "flink-runtime/src/test/resources/log4