[GitHub] flex-sdk pull request: [Module asc] Cleanup code 1st step

2015-10-17 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/21 [Module asc] Cleanup code 1st step This PR is the first step on the path to good condition code of compiler. I hope that you will take it and then I can make the new PR. You can merge this

[GitHub] flex-sdk pull request: [Module asc] Cleanup code 1st step

2015-10-17 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-17 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/22 [Module asc] Cleanup code - 1st step This PR is the first step on the path to good condition code of compiler. I hope that you will take it and then I can make the new PR. You can merge this

[GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-20 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Replace with chained append() calls

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/24 Replace with chained append() calls You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature

[GitHub] flex-sdk pull request: Remove unnecessary intern() on String const...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/23 Remove unnecessary intern() on String constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature

[GitHub] flex-sdk pull request: Remove unnecessary boxing

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/25 Remove unnecessary boxing You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_boxing Alternatively

[GitHub] flex-sdk pull request: Remove unnecessary semicolon

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/27 Remove unnecessary semicolon You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_semicolon

[GitHub] flex-sdk pull request: Remove unnecessary unboxing

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/26 Remove unnecessary unboxing You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_unboxing

[GitHub] flex-sdk pull request: Replace 'String.indexOf(value) > -1' by 'St...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/28 Replace 'String.indexOf(value) > -1' by 'String.contains(value)' You can merge this pull request into a Git repository by running: $ git pull https://github.com/Sl

[GitHub] flex-sdk pull request: Remove unnecessary enum modifier

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/29 Remove unnecessary enum modifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_enum_modifier

[GitHub] flex-sdk pull request: Remove unnecessary interface modifier

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/30 Remove unnecessary interface modifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature

[GitHub] flex-sdk pull request: Remove redundant castings

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/31 Remove redundant castings You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_redundant_casting Alternatively

[GitHub] flex-sdk pull request: Simplify boolean constructor call

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/32 Simplify boolean constructor call You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/boolean_constructor_call

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/33 Manual array copy replace with System.arraycopy You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/manual_array_copy

[GitHub] flex-sdk pull request: Manual array to collection copy replace wit...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/34 Manual array to collection copy replace with Collections.addAll You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread SlavaRa
Github user SlavaRa commented on the pull request: https://github.com/apache/flex-sdk/pull/33#issuecomment-149929667 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flex-sdk pull request: Remove unnecessary String.toString()

2015-10-22 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/35 Remove unnecessary String.toString() You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature

[patch] FLEX-34946

2015-10-23 Thread SlavaRa
From 086a61665cf5814a2561db8ac62ad92f1056bdef Mon Sep 17 00:00:00 2001 From: SlavaRa Date: Wed, 21 Oct 2015 16:08:47 +0300 Subject: [PATCH] Replace with chained append() calls --- .../asc/src/java/adobe/abc/GlobalOptimizer.java| 6 +-- .../macromedia/asc/embedding/LintEvaluator.java

[GitHub] flex-sdk pull request: Replace string concatenation as argument St...

2015-10-25 Thread SlavaRa
Github user SlavaRa commented on the pull request: https://github.com/apache/flex-sdk/pull/24#issuecomment-150963665 https://issues.apache.org/jira/browse/FLEX-34946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flex-sdk pull request: Replace string concatenation as argument St...

2015-10-30 Thread SlavaRa
Github user SlavaRa commented on the pull request: https://github.com/apache/flex-sdk/pull/24#issuecomment-152467858 I would like to help in the development of the compiler. But there is no desire to work with code that looks bad to say the least. Using string concatenation

[GitHub] flex-sdk pull request: Replace string concatenation as argument St...

2015-10-30 Thread SlavaRa
Github user SlavaRa commented on the pull request: https://github.com/apache/flex-sdk/pull/24#issuecomment-152506154 "I think "looks bad" is a personal preference." Perhaps, but in this situation, combined the two approaches StringBuffer.append and string conc

[GitHub] flex-sdk pull request: Remove unnecessary String.toString()

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove redundant castings

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary interface modifier

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Manual array to collection copy replace wit...

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Simplify boolean constructor call

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary semicolon

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary enum modifier

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary boxing

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary unboxing

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Replace 'String.indexOf(value) > -1' by 'St...

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Replace string concatenation as argument St...

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flex-sdk pull request: Remove unnecessary intern() on String const...

2015-10-31 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is