RE: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3

2017-11-13 Thread Yishay Weiss
I’m getting this: gpg: Can't check signature: No public key Where can I get the public key? From: Piotr Zarzycki Sent: Sunday, November 12, 2017 10:49:54 PM To: dev@flex.apache.org Subject: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3 Hi Folks, Thi

RE: [Discuss] Release Apache Flex SDK Installer 3.3 - RC3*

2017-11-13 Thread Yishay Weiss
When running the ant approve script I get this: gpg: Can't check signature: No public key Where can I get the public key? From: Piotr Zarzycki Sent: Sunday, November 12, 2017 10:51:23 PM To: dev@flex.apache.org Subject: [Discuss] Release Apache Flex SDK Insta

Re: [Discuss] Release Apache Flex SDK Installer 3.3 - RC3*

2017-11-13 Thread Piotr Zarzycki
Hi Yishay, The public keys you can find here [1]. Not sure if it helps. Let me know. [1] https://github.com/apache/flex-sdk/blob/develop/KEYS Thanks for looking into that! Piotr On Mon, Nov 13, 2017, 09:33 Yishay Weiss wrote: > When running the ant approve script I get this: > > gpg: Can't ch

RE: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3

2017-11-13 Thread Yishay Weiss
[echo] [echo] +1 [echo] Package https://dist.apache.org/repos/dist/dev/flex/installer/3.3/rc3/apache-flex-sdk-installer-3.3.0-src.zip [echo] Java 1.8 [echo] OS: Windows 10 amd64 10.0 [echo] Source kit signatures match: y [echo] Source kit builds: y [echo] RE

Re: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3

2017-11-13 Thread Harbs
+1 Package https://dist.apache.org/repos/dist/dev/flex/installer/3.3/rc3/apache-flex-sdk-installer-3.3.0-src.tar.gz Java 1.8 OS: Mac OS X x86_64 10.10.5 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved license

Re: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3

2017-11-13 Thread Carlos Rovira
+1 Package https://dist.apache.org/repos/dist/dev/flex/installer/3.3/rc3/binaries/ Java 1.8.0_102 OS: Mac OS X x86_64 10.13.1 Tested to download 4.16 and nightly. All worked flawlessly Best Carlos 2017-11-13 15:28 GMT+01:00 Harbs : > +1 > Package https://dist.apache.org/repos/dist/dev/flex/i

Re: [VOTE] Release Apache Flex SDK Installer 3.3 - RC3

2017-11-13 Thread Alex Harui
+1 Package https://dist.apache.org/repos/dist/dev/flex/installer/3.3/rc3/apache-flex-s dk-installer-3.3.0-src.zip Java 1.8 OS: Windows 10 amd64 10.0 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
I spent some time checking out the release. The line-ending problem is a non-issue. Prior releases are set up this way as well. The "release" target fixes up the line endings when building the binary kit. I think the main build does not so it doesn't inject changes into the sources in a repo.

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, > What is a problem with the release is that the files do not appear to be > UTF-8 encoded. Which would effect the locale files i.e. the Chinese and Japanese and probably French and other european language locales would be broken. And perhaps some of the keyboard handling code? Thanks,

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, > Which would effect the locale files i.e. the Chinese and Japanese and > probably French and other european language locales would be broken. Confirmed it’s an issue and I would also vote -1 binding because of that. To reproduce just view a DateChooser and you’ll see it has some ? in it’s

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
Is the DateChooser problem from your local build of the sources or from the RC binary artifacts? I don't doubt that the locale files are not right, but I would have expected them to be compiled into bundles correctly on the RM's machine. -Alex On 11/13/17, 4:17 PM, "Justin Mclean" wrote: >Hi,

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, > Is the DateChooser problem from your local build of the sources or from > the RC binary artifacts? A local built from the compiled source bundled I've not tested the binary yet but given it was made from the source release I would expect it to show the same issues. Or are you saying that

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi Justin, Could you please post screenshot what is wrong cause I don't understand. - I wanted to compare results of tests between those two RCs. I will cut another RC, but not because of the issue above, but because I couldn't run sh script either on my Mac which is not good itself. I would like

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, CCed to you just in case it doesn’t show up on the list as it tends to reject email with images. What it should look like: What 4.16.1 gives: There are other similar issues cause by the same issue as well. Code to replicate: http://ns.adobe.com/mxml/2009";

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
I think I just verified that the binary artifacts are ok regarding the non-ascii characters. I think that's because they are correct in the repo, and were compiled into bundles from that repo source. I'm not sure when the files get screwed up. I think it is when Ant copies the files to the temp

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
On 11/13/17, 6:27 PM, "Justin Mclean" wrote: >Hi, > >> Is the DateChooser problem from your local build of the sources or from >> the RC binary artifacts? > >A local built from the compiled source bundled I've not tested the binary >yet but given it was made from the source release I would expe

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, I would guess that all the issue are git config issues. git config —list will give you a list of your settings. > I think I just verified that the binary artifacts are ok regarding the > non-ascii characters. I think that's because they are correct in the > repo, and were compiled into bund

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
.gitattributes file might be created in git repo to unify settings ... On Tue, Nov 14, 2017 at 1:59 PM, Justin Mclean wrote: > Hi, > > I would guess that all the issue are git config issues. > > git config —list will give you a list of your settings. > > > I think I just verified that the binary

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi, I just pushed RC2 [1]. Can you check whether you have the same problem ? [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/ Piotr 2017-11-14 7:59 GMT+01:00 Justin Mclean : > Hi, > > I would guess that all the issue are git config issues. > > git config —list will give you a l

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
Just have tried to run `bin/*` files under Ubuntu Only errors related to missing environment variables are reported On Tue, Nov 14, 2017 at 2:01 PM, Piotr Zarzycki wrote: > Hi, > > I just pushed RC2 [1]. Can you check whether you have the same problem ? > > [1] https://dist.apache.org/repos/dist

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Alex, I understand what is all about with chmod as it was in FlexJS (not sure which file should be converted), but I would like to leave it as is now. Unfortunately I don't understand your last sentence: "I was hoping the source files would be valid on Windows, but I just checked and even there t

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi Maxim, Long time no see! :) Thanks for looking into that! Piotr 2017-11-14 8:15 GMT+01:00 Maxim Solodovnik : > Just have tried to run `bin/*` files under Ubuntu > Only errors related to missing environment variables are reported > > On Tue, Nov 14, 2017 at 2:01 PM, Piotr Zarzycki > > wrote

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
I read through almost all emails, Unfortunately have not much time to contribute more :(( On Tue, Nov 14, 2017 at 2:23 PM, Piotr Zarzycki wrote: > Hi Maxim, > > Long time no see! :) Thanks for looking into that! > > Piotr > > > 2017-11-14 8:15 GMT+01:00 Maxim Solodovnik : > > > Just have tried t

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
If the RC build was run on files that weren't utf-8 encoded, the build would have failed, since the build runs checkintests and that's where it first notices the encoding differences. And then I would expect the binaries in the RC would be incorrect, which it appears they aren't. Files are being

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, > The binaries are not created by first creating the source package, > unpacking it and compiling it. You were a Flex SDK RM at least once, did > you not understand what you were signing? Every time I made the release I made it from the source on my local machine on a clean tagged branch. I

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi, > I just pushed RC2 [1]. Can you check whether you have the same problem ? > > [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/ Yes I can confirm that the scripts have execute bits. The files do not have the correct line endings (for instance look at LICENSE) Re UTF-8 it doe

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
Piotr, If you look at your repo's copy of frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you should see: "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]); Note the character before "(U+5DDD)". It should look like 1 curved line followed by 2 straight lines.

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
On 11/13/17, 11:34 PM, "Justin Mclean" wrote: >Hi, > >> The binaries are not created by first creating the source package, >> unpacking it and compiling it. You were a Flex SDK RM at least once, >>did >> you not understand what you were signing? > >Every time I made the release I made it from