Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

My suggestion was to copy it and prune the ones that are not used. > On Jun 29, 2017, at 9:49 AM, Justin Mclean wrote: > > Hi, > >> AllCSSValuesImpl - is not enough performant cause of lack of strict >> comparison ? > > Just the large number of styles.When Harbs added it he said "It has a LOT

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

And it was about AllCSSStyles and not AllCSSValuesImpl. I see no reason to not use that one. > On Jun 29, 2017, at 10:14 AM, Harbs wrote: > > My suggestion was to copy it and prune the ones that are not used. > >> On Jun 29, 2017, at 9:49 AM, Justin Mclean wrote: >> >> Hi, >> >>> AllCSSValu

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, But you did agreed that the code in question should stay in CSSValuesImpl. From you last email in that thread: "I agree with Justin on this. I don’t see why numeric font weights is different than backgroundImage for example. Not every app uses backgroundImage, but it should work if used. T

[FLEXJS][FALCONJX] Variable Initialization, equality, etc.

Now that the release is out, I spent some more time looking into the issue of what variables should be initialized and thus, how we should handle equality testing (==, ===, etc). My conclusion remains the same: there is no one right answer. But I saw some interesting things. I started with the

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

That was before his response. Sorry I never responded to Alex, but once he explained himself, I do agree with what he wrote. Considering we have AllCSSValuesImpl, I think that should be the default for apps which are expecting HTML CSS. Just swap that out in your app, and everything should be f

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > Considering we have AllCSSValuesImpl, I think that should be the default for > apps which are expecting HTML CSS. It’s not about HTTML CSS. This code: Will compile with no warnings but fail to work without the fix. Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

A font weight of 600 will fail in Flash. It’s CSS that only works in HTML. > On Jun 29, 2017, at 10:49 AM, Justin Mclean wrote: > > Hi, > >> Considering we have AllCSSValuesImpl, I think that should be the default for >> apps which are expecting HTML CSS. > > It’s not about HTTML CSS. > > Th

Re: [FlexJS] Failed to download nightly build FlexJS 0.9.0

Alex, Now it's working! Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Failed-to-download-nightly-build-FlexJS-0-9-0-tp62664p62679.html Sent from the Apache Flex Development mailing lis

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > A font weight of 600 will fail in Flash. It compiles with no warnings and displays the text correctly. There is no run time error but if you mean by “fail” it doesn't set the text to font weight to 600 then that’s correct. That is expected as 600 is not a supported value for font weight

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

Hi Alex, Thanks for looking into that. This is the hottest subject after the release and sadly to say arguable. Let's resolve it in this thread. My results Chrome [1], Firefox [2] - Windows 7. 1) Strict equality - I'm for revert the to the previous version of code (hopefully Harbs will merge tlf

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

I’m not sure what your point is. That’s why you should use SimpleCSSValuesImpl is supposed to be a simple implementation which works the same in Flash and HTML. AllCSSValuesImpl is supposed to be an implementation which works with valid HTML CSS. Thanks, Harbs > On Jun 29, 2017, at 11:34 AM,

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

Hi, > The JS version of the test is here: > http://home.apache.org/~aharui/FlexJS/FLEX35330/bin/js-release/ > > The SWF version of the test is here: > http://home.apache.org/~aharui/FlexJS/FLEX35330/bin-debug/ > > For me, the SWF

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > That’s why you should use You can’t in this case as it doesn’t compile with the following error: This tag could not be resolved to an ActionScript class. It will be ignored. So somehow you need to include one on one platform and one on the other in MXML I’m not sure if our co

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

I ran it multiple times on multiple browsers and I did not see a repeatable pattern. The different comparisons were sometimes faster but on the next run, the faster one might have been slower. No matter what pattern is used, there’s no significant difference. The only thing that was constant wa

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

No. It’s there. Make sure you have commit af1f5c9 in your build of Core. > On Jun 29, 2017, at 12:21 PM, Justin Mclean wrote: > > Hi, > >> That’s why you should use > > You can’t in this case as it doesn’t compile with the following error: > > This tag could not be resolved to an ActionScri

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

> On Jun 29, 2017, at 12:19 PM, Justin Mclean wrote: > > Hi, > >> The JS version of the test is here: >> http://home.apache.org/~aharui/FlexJS/FLEX35330/bin/js-release/ >> >> The SWF version of the test is here: >> http://home.a

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, The class is there I’m on the latest version of develop of all 3 repos and I’m still getting that compile error. Did you actually try using that class / compiling it? Thanks, Justin

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

HI, > There are tests for both, and you DON’T get type conversions unless it’s > required. Browsers are smarter than that. See [1] and follow the path if x in undefined and y is a boolean and true. Compare this with [2] Thanks, Justin 1. https://es5.github.io/#x11.9.3

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Check your basic-manifest.xml for Core. Do you see

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

Right. Using the spec is a poor way of knowing how JS engines actually implement the functionality. If they can get functionally equivalent results that perform better by using slightly different steps, they will. Based on the tests, it looks like browsers do NOT do type conversions: j = 0 if

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Yes. > On Jun 29, 2017, at 12:54 PM, Justin Mclean wrote: > > Did you actually try using that class / compiling it?

Re: [DRAFT] Apache FlexJS 0.8.0 and Apache Flex FalconJX 0.8.0 Released

It's more specific than that. It works in Chrome, but only if you launch using the VSCode debugger. If I could make it work in Chrome's dev tools without VSCode, I'd agree with your suggestion. However, I feel that most people aren't going to be able to make this work. - Josh On Wed, Jun 28, 2017

Re: git commit: [flex-asjs] [refs/heads/tlf] - Made the SingleSelectionDragSourceBead and SingleSelectionDropTargetBead a bit more generic to work with DataGrid as well as List. Added dragStartObject

Hi Peter, Could you please update version to 0.9.0 in the comments. Thanks, Piotr 2017-06-29 17:20 GMT+02:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/tlf c89b3a11e -> 38d7d38a5 > > > Made the SingleSelectionDragSourceBead and SingleSelectionDropTargetBead a > bit more generi

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

On 6/29/17, 4:08 AM, "Harbs" wrote: > >The question that I think Alex is looking at, is whether the compiler can >handle boolean comparisons without initialization so it would do the >right thing without a performance hit. I’d be interested in hearing his >findings. > I think my test shows that