/**
* @param {string} type
* @param {!EventListener|(function(!Event): (boolean|undefined))| null}
listener
* @param {boolean=} opt_useCapture
*/
SVGElementInstance.prototype.addEventListener = function(type, listener,
opt_useCapture){};
/**
* @param {string} type
* @param {!EventListener
Hi,
> I assume this is from the patch.
Yep that’s in the patch.
/**
* @param {string} type
- * @param {!EventListener|(function(Event): (boolean|undefined))| null}
listener
+ * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
listener
* @param {boolean=} opt_useCapture
*/
S
Quite frankly, I don’t know how to read patch files, and I don’t know what it’s
supposed to be doing.
I’m going to leave this to someone who understands this better than I do to
figure out… ;-)
> On Jun 14, 2017, at 12:12 PM, Justin Mclean wrote:
>
> Hi,
>
>> I assume this is from the patch.
It's worth noting that we already have a release branch, and it is named
release0.8.0. While the Maven release instructions that Chris wrote say
that you should create a release/version branch, that's for future releases
where a branch doesn't already exist.
- Josh
On Wed, Jun 14, 2017 at 6:45 AM
Josh,
I thought that we need to do this instead. I didn't find options where I can
use existing branch to use that process.
What do you suggest ? Leave release for Maven and go with current release ?
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http
Josh,
For me that was point of that discussion - make Maven release. Cause of we
missed that people voted -1. Even if we need to create another branch, merge
everything etc.
If you understand differently give me your thoughts.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
V
It looks to me like there are two things that need to be done because we
already have a release branch that wasn't created with Maven.
1) The develop branch should be updated to 0.9.0-SNAPSHOT. You've already
done this, and that seems fine.
2) Start at step 4 with our existing release0.8.0 branch
I'm not saying that we shouldn't make a Maven release. I'm saying that the
process that Chris suggested needs to be modified one time because we've
already done some of the things manually.
- Josh
On Wed, Jun 14, 2017 at 6:46 AM, piotrz wrote:
> Josh,
>
> For me that was point of that discussio
Ok I will change only typedefs manually without creating branch.
As for the step 4 it look like I need to wait for fix for this problem in
[Discuss] thread. - If I'm not right let me know.
Thanks for help!
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
Yeah, I think we need a fix for the SVG patch issue before we can create
RC2.
- Josh
On Wed, Jun 14, 2017 at 6:55 AM, piotrz wrote:
> Ok I will change only typedefs manually without creating branch.
>
> As for the step 4 it look like I need to wait for fix for this problem in
> [Discuss] thread
I think I did update develop branch to 0.9.-SNAPSHOT. Build of compiler and
typedefs went fine, but FlexJS is failing and I'm not sure why.
It's searching this some swc [1] but with version + date:
Could not find artifact
org.apache.flex.flexjs.typedefs:flexjs-typedefs-parent:pom:0.9.0-20170614.1
I forgot to post link, from pipeline [1]
[1]
https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/develop/75/console
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/DISCUSS-Discuss-Re
I just ran the curl command (sorry if my Outlook has munged the URL). I
got the same hash. When I open it up, I see:
/**
* @param {string} type
* @param {!EventListener|(function(Event): (boolean|undefined))| null}
listener
* @param {boolean=} opt_useCapture
*/
SVGElementInstance.prototype.a
Alex, fyi if I delete the target directory inside flex-typedefs (to be sure
it is 'clean', although I am quite sure mvn clean does this also) , then
run mvn clean compile, i get the following in svg.js inside downloads:
/**
* @param {string} type
* @param {!EventListener|(function(!Event): (bool
A possible clue:
I can see the patched file in :
C:\Users\Greg\.m2\repository\.cache\maven-download-plugin
On Thu, Jun 15, 2017 at 11:25 AM, Greg Dove wrote:
> Alex, fyi if I delete the target directory inside flex-typedefs (to be
> sure it is 'clean', although I am quite sure mvn clean does
I just manually emptied the file cache in .m2\repository\.
cache\maven-download-plugin
And typedefs built fine via maven.
So my guess is that the download plugin is caching the files after they
have been patched and next time it is 'downloading' the patched file
On Thu, Jun 15, 2017 at 11:40 AM,
Greg,
The Maven build will download and patch the svg.js file so when I look at
my copy after running "mvn clean install", svg.js does have
"function(!Event)" as it should. IOW, the Ant and Maven build should
download svg.js with "function(Event)" and change it to
"function(!Event)". It happens
Yeah, I think this might be some caching of the downloaded file and
possibly is not a reliable repro.
I just checked now and the cached file for svg.js in my .m2\repository\.
cache\maven-download-plugin after my latest build is not patched. But it
definitely was before. So it might be a bit 'random
That's interesting. But now that you've run Maven again, what version of
svg.js got cached? The svg.js in my cache does need patching.
-Alex
On 6/14/17, 4:54 PM, "Greg Dove" wrote:
>I just manually emptied the file cache in .m2\repository\.
>cache\maven-download-plugin
>
>And typedefs built f
"But now that you've run Maven again, what version of
svg.js got cached? The svg.js in my cache does need patching."
I think we crossed email replies because I already added comments about
that -see my previous post if you did not already.
To verify, I copied the downloaded and patched version o
20 matches
Mail list logo
