Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

2017-06-11 Thread Harbs
+1 Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/apache-flex-falconjx-0.8.0-src.tar.gz Java 1.8 OS: Mac OS X x86_64 10.10.5 Source kit signatures match: y Source kit builds: y README is ok: y README_JX is ok: y RELEASE_NOTES is ok: y RELEASE_NOTES_JX is ok: y NOTICE is ok: y

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread Harbs
I did not see anything that would preclude a release, but the readme does not have anything that mentions Maven. The prerequisites only mention ANT and environment variables. It would be a good idea that for the next release, we should add installation instructions for Maven as well. (and proba

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Alex Harui
I never said it wasn't important/serious. I did not say it is an optimization issue. The changes you made look fine. Seems like eventually we'll have to initialize other types as well. It makes every variable be like every airline passenger going through the metal detector. Safe, but inefficie

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread Justin Mclean
Hi, > I did not see anything that would preclude a release, but the readme does not > have anything that mentions Maven. The prerequisites only mention ANT and > environment variables. Falcon has this [1] should be easy enough to do similar. Thanks, Justin 1. https://github.com/apache/flex-fa

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Justin Mclean
Hi, > The changes you made look fine. Do you want them as the default and an option to turn them off? I’m assuming you will you at some later point add other switches to turn other optimisations (whatever they may be) on? > Seems like eventually we'll have to initialize other types as well. I

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
It seems like the general case is better to have the initialization. Thanks for implementing that. It would probably be nice for the compiler to be intelligent and only initialize if the code does not initialize too. So: var val:Boolean; // further down before val is actually accessed val = tr

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
var start = Date.now(); var val; for(var i=0;i<100;i++){ val=false; val=false; } console.log(Date.now()-start); V8 (Node.js and Chrome) seems to optimize this loop out, so you can do a billion iterations really fast. Firefox gives a more realistic indication of performance:

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Justin Mclean
Hi, > But I don’t see this as critical for now. This is probably not required as the google compiler take care of this for us. Code like this: function test() { var a = false; a = b; if (a) { Console.log("got here"); } } Becomes: function test(){b&&Console.log("got here”)} In this

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread piotrz
Hi, +1 (binding) - Can build sources by Maven - Can build sources by Ant through ApproveFlexJS script - Can build real world application using RC1 downloaded by installer Package http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs_release_branch/lastSuccessfulBuild/artifact/out/apache-flex-fl

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread Justin Mclean
Hi, Currently the RC1 fails to compile with maven with this error: [ERROR] org.apache.flex.flexjs.typedefs:flexjs-typedefs-js:swc:0.8.0-SNAPSHOT [ERROR] [ERROR] from the specified remote repositories: [ERROR] apache-release (https://repository.apache.org/content/repositories/releases, releases=t

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Alex Harui
Yep. We are introducing "just-in-case" code. These changes are not PAYG, until we get more of these optimizations in. I'm still interested in how many of these cases there are. Some day I'll find out. But probably not right away. -Alex On 6/11/17, 1:21 AM, "Harbs" wrote: >It seems like the

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
Justin seems to have observed the Google compiler stripping these out. It seems like a good idea to do some research on how extensively it does so. If we can rely on goog to do this work for us, then I’m fine with that. Either way, the performance implications one way or the other are miniscule.

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread piotrz
Hi Justin, I didn't get it and I was building by Maven straight from the sources downloaded by ApproveFlexJS script. Can you try build typedefs and later SDK - what will happen ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-