Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

2017-06-09 Thread Greg Dove
I happened to be testing against FlexJSStore at the time I discovered the need for this, and there is some removing going on. I think I improved performance compared to how it was originally by removing coercion in js and using local references for some of the repeat listener references/avoiding r

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread Josh Tynjala
I suspect that the if(b == true) and if(b == false) patterns aren't out of the ordinary in real-world code. I hope the default will be to initialize Booleans to false and that you'll need to opt into the other behavior. - Josh On Fri, Jun 9, 2017 at 3:38 PM, Alex Harui wrote: > Thanks for point

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread Justin Mclean
Hi, > If a variable is of type Boolean in AS (not JS), is there a > difference between these three patterns. No as a boolean can only have the values of true and false and defaults to false in AS. If you take the same code and run it in the browser it can now have three values, true, false and

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-09 Thread OmPrakash Muppirala
Please note that I will be traveling for the next few days. In any case I will be waiting for the artifacts to be propagated through the mirrors before pushing a FlexJS npm release. Hopefully the timelines will coincide. Worst case, there will be a bit of a lag for the npm release. Thanks, Om

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread justin
Hi, And this particular rabbit hole goes a lot deeper. Any guesses what these two expression give? false && undefined undefined && false If you expect them to have the same answer you would be incorrect. Does this matter? Well try this code on both platforms: var a:Boolean; var b:Boolean = fa

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread Alex Harui
The general principle is optimization. Optimization looks for specific patterns. What you wrote below is not one of the patterns. Would be fun to see how often that pattern exists though. IMO, it would not make sense to initialize every boolean because 1% of the boolean expressions require opti

Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

2017-06-09 Thread Alex Harui
Yes, thanks for removing unnecessary coercions. While debugging examples, I also noted the removal of Layout in Panel. Makes me wonder if we our container architecture/lifecycle is designed properly. The base classes may need to have a pattern for "proxies" and "wrappers", which may be the essenc

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread Justin Mclean
HI, > The general principle is optimization. Optimization looks for specific > patterns. What you wrote below is not one of the patterns. Not one of what patterns? BTW Initialising the Boolean to false also optimises the seed by a factor of two. i.e. twice as fast. > Would be fun to see how

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread justin
Hi, I think we may be talking cross purposes here to be clear - IMO this is not an optimisation issue this it’s a serious bug. Justin

Re: [FlexJS] List reordering

2017-06-09 Thread piotrz
Hi Harbs, I haven't touch subject, but one question - Do you have in mind Basic List or MDL List ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-List-reordering-tp62261p62262.html Sent from th

Re: [FlexJS] List reordering

2017-06-09 Thread Harbs
Basic. > On Jun 9, 2017, at 9:47 AM, piotrz wrote: > > Hi Harbs, > > I haven't touch subject, but one question - Do you have in mind Basic List > or MDL List ? > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: > http://apache-flex-de

Re: [FlexJS] List reordering

2017-06-09 Thread Josh Tynjala
I played around with the HTML drag and drop API not too long ago. It was pretty intuitive and easy to work with. https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API - Josh On Thu, Jun 8, 2017 at 11:46 PM, Harbs wrote: > Has anyone done any work on reordering items in lists

Re: [FlexJS] List reordering

2017-06-09 Thread Alex Harui
FlexJSStore example uses DragDrop to drag from what looks like a TileList to a regular List, but neither are actually based on List. But there might be code in there you can leverage. HTH, -Alex On 6/9/17, 6:19 AM, "Josh Tynjala" wrote: >I played around with the HTML drag and drop API not too l

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-06-09 Thread Alex Harui
In case anybody is wondering, I'm having computer troubles and family stuff that is delaying the RC. -Alex On 6/8/17, 11:04 AM, "piotrz" wrote: >I just run Maven build [1] and it's blue, so from my point we are ready! >:) > >[1] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-06-09 Thread Harbs
As long as it’s computer troubles and not family troubles… ;-) > On Jun 9, 2017, at 5:30 PM, Alex Harui wrote: > > In case anybody is wondering, I'm having computer troubles and family > stuff that is delaying the RC. > > -Alex > > On 6/8/17, 11:04 AM, "piotrz" wrote: > >> I just run Maven b

[FlexJS] Compiler options / VSCode config

2017-06-09 Thread Olaf Krueger
Hi, after some weeks being technically offline at home, I'm hopefully back in the game now;-) I've just downloaded the nightly build using the installer and tried to compile my little test app with no success [1]. I noticed that the target folder contains just a weird javascript file. I've already

Re: [FlexJS] Compiler options / VSCode config

2017-06-09 Thread Josh Tynjala
Did you delete your ./target/javascript directory before compiling with the new SDK? I don't see why that would cause this problem, but it's worth a try. Good to get in the habit when switching SDKs anyway, since some old framework JS files might get stale. I've seen some issues with the format of

Re: [FlexJS] Compiler options / VSCode config

2017-06-09 Thread Olaf Krueger
Josh Tynjala wrote > Did you delete your ./target/javascript directory before compiling with > the > new SDK? I'm pretty sure that I've done that all the time without any success. After I've changed the "output" option as you mentioned the first time including deleting the target folder it works

[VOTE] Release Apache Flex FalconJX 0.8.0 RC1

2017-06-09 Thread Alex Harui
Hi, This is vote for the 0.8.0 release of the FalconJX (and Falcon) compilers. There is no separate Falcon-only release package at this time. The only purpose of the FalconJX packages are to serve as upstream packages for the FlexJS release. The release candidate can be found here; https://dist

[DISCUSS] Discuss Release Apache Flex FalconJX 0.8.0 RC1

2017-06-09 Thread Alex Harui
This is the discussion thread. Changes in this RC include: Thanks, Alex Harui

[VOTE] Release Apache FlexJS 0.8.0 RC1

2017-06-09 Thread Alex Harui
Hi, This is vote for the 0.8.0 release of Apache FlexJS. The release candidate can be found here; https://dist.apache.org/repos/dist/dev/flex/flexjs/0.8.0/rc1/ Before voting please review the section,'What are the ASF requirements on approving a release?', at: http://www.apache.org/dev/release.h

[DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-09 Thread Alex Harui
This is the discussion thread. Thanks, Alex Harui

Re: [FlexJS] more on undefined / non initialised values

2017-06-09 Thread Alex Harui
Thanks for pointing it was == and not ===, but I must still be missing something. If a variable is of type Boolean in AS (not JS), is there a difference between these three patterns: If (b) If (b == true) If (b === true) Or these three? If (!b) If (b == false) If (b === false) I don't think th

Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

2017-06-09 Thread Alex Harui
I guess I don't believe that removing beads is so common that every app needs to carry this code around. I wonder if there is a way to inject removability as needed. Having a RemovableXXXLayout could override the strand setter and remove listeners if the handlers are protected. Thoughts? -Alex