Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
HI, > 1) I see following warnings [1]. The warnings are fine or rather the compiler shouldn’t be warning there - this has been discussed before on the list. > 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see > Null Pointer Exception in SimpleCSSValuesImpl. That I’ll

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread piotrz
Justin, It it was discussed and the other were agree for the warnings can you raise a jira to remove them later on ? Additional things I was speaking a bit with colleagues from JS team in my company and asking them about checking "undefined" things. They were saying that they are checking such th

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
Hi, > if(typeof a !== 'undefined') { > } > > And of course if we consider null: > > if(typeof a !== 'undefined' && null !== a) { > } > > Thoughts ? It’s really going to depend on the context / code. In some case it will be obvious with one to check. In others we may need to change the code t

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread piotrz
I'm not sure whether I understand your answer. I don't actually talking about checking between null or undefined - cause it's obvious it is depends on scenario. I'm talking about a way in which we are doing it - What do you thing to use this "typeof a". ? Thanks, Piotr - Apache Flex PMC

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
You seem to be missing the most important part of my proposal. The compiler will put the "bin" directory in the parent of the main source folder, regardless of whether it's named "src", "source", "alex-is-cool" or *any* name whatsoever. I put some pseudo-code to explain that in one of my emails, bu

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
OK, sorry, I did miss that. I thought you were the one who wanted the output in the same folder, but I was mistaken. Keep in mind that: 1) The SWF compiler (MXMLC for both the regular Flex SDK and FlexJS) defaults to putting the output in the same folder. So, if you have: /projects/SomeProject

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
If I need to set an option, then I might as well set -output or -js-output. I simply wouldn't use -outputFolderMap. - Josh On Fri, Jun 2, 2017 at 8:25 AM, Alex Harui wrote: > OK, sorry, I did miss that. I thought you were the one who wanted the > output in the same folder, but I was mistaken.

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
I would modify my flex-config.xml, so I don't have to modify every project. -Alex On 6/2/17, 8:38 AM, "Josh Tynjala" wrote: >If I need to set an option, then I might as well set -output or >-js-output. >I simply wouldn't use -outputFolderMap. > >- Josh > >On Fri, Jun 2, 2017 at 8:25 AM, Alex Ha

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
That's a perfectly valid solution for some people. I prefer to work with unmodified SDKs so that I don't accidentally release any projects that break for other people because their SDKs are not modified like mine. - Josh On Fri, Jun 2, 2017 at 8:42 AM, Alex Harui wrote: > I would modify my flex

Re: [FlexJS] Accordion broken

2017-06-02 Thread Peter Ent
Hi, It looks like this is the last thing to be resolved before we can make FlexJS 0.8 release. I'm seeing two title bars per item in the Accordion. Any suggestions for how to resolve this, based on the information I've given below? Thanks, Peter On 6/1/17, 3:49 PM, "Peter Ent" wrote: >I've ch

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
Agreed. So I think with the defaults I propose we will implement what you propose and I can tweak it for my needs? -Alex On 6/2/17, 8:55 AM, "Josh Tynjala" wrote: >That's a perfectly valid solution for some people. I prefer to work with >unmodified SDKs so that I don't accidentally release any

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
Oh, I didn't realize that you wanted to add -outputFolderMap in addition to my proposal. That sounds good to me! - Josh On Fri, Jun 2, 2017 at 9:03 AM, Alex Harui wrote: > Agreed. So I think with the defaults I propose we will implement what you > propose and I can tweak it for my needs? > > -

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
Hi, >> 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see >> Null Pointer Exception in SimpleCSSValuesImpl. > > That I’ll take a look at. It’s running file here for me. What browser / what was the error you were getting? Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread piotrz
I didn't run it in the browser. I run swf in Flash Player projector [1]. [1] http://www.adobe.com/support/flashplayer/debug_downloads.html - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-7-7-git-commit-fle

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
Hi, > if(typeof a !== 'undefined') { > } Are we really concerned that undefined may of been redefined? (Which would probably cause a whole lot of issues.) Seems it may be a little expensive to me compared to a straight === undefined. Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
HI, > I didn't run it in the browser. I run swf in Flash Player projector [1]. How are you compiling that? Looks like "mvn compile” only produces the JS version. Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread piotrz
Justin, I just pushed fix and it should build both version. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Justin Mclean
Hi, OK the issue is that we getting different results for AS and JS. For code like this: var a:Object = {}; var propA:Object = a.prop; var propB:* = a.prop; if (propA === undefined) { trace("A undefined"); } if (propA === null) { trace("A null"); } if (propB === undefined) {

Private properties are undefined in JS and null in AS

2017-06-02 Thread Justin Mclean
Hi, This code: private var a:Object; protected function init():void { trace(a); } When init() is called with display “null” in when run the FlashPlayer and display “undefined” when compiled into JS and run in a browser. How should we fix this? Thanks, Justin

Re: Private properties are undefined in JS and null in AS

2017-06-02 Thread Justin Mclean
Hi, Also the same for public and protected so at least it's consistence in it’s inconsistency :-) Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread Josh Tynjala
Another place where things differ is member variables: public var a:String; On the SWF side, this variable defaults to null. On the JS side, it defaults to undefined right now. In the case of a member variable, we could set it to null by default on the JS side to make it more consistent. For yo

Re: Private properties are undefined in JS and null in AS

2017-06-02 Thread Josh Tynjala
I just mentioned the same thing in response to your other thread. Defaulting to null (where appropriate) would help, I think. However, later assignments can still cause a variable to be set to undefined in JS but null in SWF. That could be considered a separate issue, but it's definitely related.

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
Hmm. We seem to be miscommunicating. My proposal is to implement your proposal via outputFolderMap and some default mappings in flex-config.xml. -Alex On 6/2/17, 9:06 AM, "Josh Tynjala" wrote: >Oh, I didn't realize that you wanted to add -outputFolderMap in addition >to >my proposal. That sou

Re: Private properties are undefined in JS and null in AS

2017-06-02 Thread Alex Harui
As Josh mentioned in the other thread, we need data. Maybe there isn't a right answer and folks will have to use directives or compiler options to get what they want for their needs. The data probably needs to answer at least the following questions: 1) how much slower is === than == (and simila

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-06-02 Thread piotrz
Hi Justin, I saw your commit. Why in that case you cannot have? if(styleable.style !== 'undefined' && styleable.style != null) You will have both cases handled. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.

Re: Private properties are undefined in JS and null in AS

2017-06-02 Thread piotrz
Hi, I would be really interested to have answer to each of this questions. It can give us answer what actually need to be used. I would suggest till then do not change anything - apart of obvious bugs. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: htt