Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread piotrz
Om, I cannot guide you cause I don't have my laptop till Tuesday here in my family home. I think I was doing it in a Module settings and Global Library section - than use it, but I will confirm it on Tuesday. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in cont

Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread piotrz
I'm not sure what you mean by conditional compilation? I have setup maven build in Run/Debug you will be able there type maven conditions [1] [2] [1] https://www.jetbrains.com/help/idea/2016.3/creating-maven-run-debug-configuration.html [2] https://www.jetbrains.com/help/idea/2016.3/run-debug-conf

Re: [FlexJS] Added ListExample and DateControlsExample to the maven build

2016-12-26 Thread Peter Ent
Thanks. That was my fault. Much appreciated. Peter > On Dec 25, 2016, at 11:26 AM, Christofer Dutz > wrote: > > Hi guys, > > I noticed two new examples which weren’t automatically built by the maven > build. I fixed that ... now they should build with all the other modules. > While List

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Chris, I think it's worth to try with putting into analysis also ActionScript code. Who should we eventually ask for installing ActionScript plugin? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Fle

Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread yishayw
Looking forward to this. We'd like to use this in our app, so when the basic functionality is there we'll probably start integrating this and give our feedback. I tried using Slider, but noticed there were no events being thrown (probably because there's no default controller for it). -- View

Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread piotrz
Yishay, You just pointed important thing. We should probably for each component involve some controllers instead expose event intself by component. I did for example this in Snackbar. Basically "action" is an event which allows interaction with control. Documentation is saying - if it's doesn't

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Christofer Dutz
I’ll set this up locally and give it a spin. I wouldn’t be surprised, if the result would be “catastrophic” because of all of the conditional compilation … I know that sonar doesn’t like this. So I’ll try to setup a build and settings for ActionScript on my local SonarQube first. Chris Am 26.1

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Thank you. Looking forward to the results. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57570.html Sent from the Apache Flex Development mailing li

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Christofer Dutz
Ok … so the results aren’t that bad at all … Typedefs: 1 Bug 1 Vulnerability 308 Code Smells Framework: 17 Bugs 86 Vulnerabilities 8500 Code Smells (A lot is probably related to the conditional compilation) 35% of duplicated code 35% of duplicated code seems to indicate we could reuse quite a lo

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Thanks Chris. :) That's what I was intrested how much code duplication we have. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57572.html Sent fro

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Josh Tynjala
I suspect that a big chunk of the duplicate code is related to the Basic and HTML projects. As I understand it, HTML was forked from Basic to try a different architecture approach, but a big portion of the code is still the same. - Josh On Mon, Dec 26, 2016 at 8:39 AM, Christofer Dutz wrote: >

Starting fresh / new developers

2016-12-26 Thread Mark Kessler
I'd like to start a discussion aimed at prospective new developers. This is sort of an in-process review. The end state getting feedback on our current setup just to make sure we are making it easy for new folks. Let's setup the ground rules of working on constructive / positive. Giving

Re: Starting fresh / new developers

2016-12-26 Thread Josh Tynjala
1. I think FlexJS would benefit from its own dedicated page on the main website that describes its benefits in a more polished, bite-sized form. Basically, more of a marketing page that keeps the architecture discussion limited to high-level bullet points. If someone really wants to dive in to the

[4.16.0] # Apache Flex SDK 4.16.0 nightly build 181: Successful

2016-12-26 Thread flex . ci . builds
flex-sdk_release-candidate - Build #181 - Successful Changes since last build: No changes For more information, check the console output at http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/181/.

Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread OmPrakash Muppirala
On Mon, Dec 26, 2016 at 1:13 AM, piotrz wrote: > I'm not sure what you mean by conditional compilation? I have setup maven > build in Run/Debug you will be able there type maven conditions [1] [2] > > [1] > https://www.jetbrains.com/help/idea/2016.3/creating- > maven-run-debug-configuration.html

Re: [FlexJS] Setting up FlexJS and MDL

2016-12-26 Thread yishayw
Personally, I would find it confusing to use a component that declares an event that isn't dispatched. So if Toast never dispatches 'action' it should probably not declare it. I would make Toast and Snackbar two separate components and have them share as many beads as possible for code reuse. --