Re: [FlexJS] MDL List problems

2016-11-22 Thread Carlos Rovira
MDL List is extending ListBase (as js:List does). Is a copy/paste of js:List. I want to start from a working component. e contains Error object message is: ·org.apache.flex.utils.Language.as stack is : org.apache.flex.html.beads.DataItemRen -> from here I can't read nothing more So you think I mu

Re: [FlexJS]missing css

2016-11-22 Thread Harbs
Here maybe a clue: I changed the js-output-type to JSC and I got the following error: build_example.compilejs: [echo] Compiling PrintUIManagement.js [echo] FLEX_HOME: /FlexSDK/FlexJSNightly [echo] FALCONJX_HOME: /FlexSDK/FlexJSNightly/js [echo] GOOG_HOME: /FlexSDK/FlexJSNightl

Re: [FlexJS] MDL List problems

2016-11-22 Thread Carlos Rovira
Peter, Alex, I finaly get it working extending from org.apache.flex.html.List instead of ListBase...but this seems to me that something is not working ok on internals, what do you think? One side effect not related to this problem is that this: public class List extends org.apache.flex.html.List

Re: [FlexJS, MDL] Help with MDL

2016-11-22 Thread Carlos Rovira
Great Piotrz! :) 2016-11-22 8:11 GMT+01:00 piotrz : > Carlos, > > I've also put some effort to add MaterialDesignLite.swc to our nightly > build > and it's working. :) Anyone who download nightly can try it from now on. :) > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > --

[FlexJS]build_example.xml

2016-11-22 Thread Harbs
What is the purpose of these settings in the compilejs target?

Re: [FlexJS]missing css

2016-11-22 Thread Harbs
Here is a stripped down project with not much in it. I copied a lot of the build.xml from the CreateJS project with the exception of removing the SWF compile. When I remove the SWF compile in the CreateJS project, it compiles correctly. I also added arguments for library-path and external-libra

Re: [FlexJS] MDL List problems

2016-11-22 Thread Carlos Rovira
Hi Peter, another thing I think is "failing" is the fact I need to explicitly set labelField to "label" or I get [object Object] I think List should asume labelField is "label" by default like in old Flex 2016-11-21 22:57 GMT+01:00 Peter Ent : > I had an issue today with ComboBox and its model n

[FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
Hi, I'm digging into the FlexJS List, and is a complex component with lots of beads. But in MDL the structure is simpler. In MDL there is only a with item elements in FlexJS we have the List Container (that I can change to ), but then we have the List DataGroup that is an additional div. So I

RE: [FlexJS] List Structure

2016-11-22 Thread Yishay Weiss
How about extending list but not using ListView? Maybe you can have a different implementation of IListView where dataGroup references the view element? If you’re sure there’s not going to be any chrome elements (e.g. TitleBar) then it seems to me correct to not use a data group on top of the

Re: [FlexJS] List Structure

2016-11-22 Thread Alex Harui
IIRC There is already a SimpleList component that wraps a Select element. The List is really meant to introduce the whole custom item renderer capability. If you don't need that, just create your own thing. You may not even need a View on the JS side. My 2 cents, -Alex On 11/22/16, 4:03 AM, "ca

[FlexJS]Why is swc missing JS files?

2016-11-22 Thread Harbs
Please take a look at what I did here. https://github.com/unhurdle/cep-flexjs/tree/master/CEPTools I originally tried building the swc using FDT. I thought there was something wrong there, so I set up an ant build, and that does not contain the JS files either. What did I do wrong? Harbs

Re: [FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
I tried to extend from SimpleList, but I get the same output (ul -> div ListDataGroup -> items) It seems SimpleList extends Listso all complexity is there :? 2016-11-22 15:25 GMT+01:00 Alex Harui : > IIRC There is already a SimpleList component that wraps a Select element. > The List is real

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Harbs
Agreed. It should not do automatic conversions. Now that you mention it, I’ve been getting Bindable warnings on those classes for years. Everything worked, so I ignored it, but I would not be surprised if the warnings were related to this issue. Thanks for looking into this. Harbs On Nov 22,

Re: [FlexJS] MDL List problems

2016-11-22 Thread Alex Harui
On 11/22/16, 3:16 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi Peter, > >another thing I think is "failing" is the fact I need to explicitly set >labelField to "label" or I get [object Object] >I think List should asume labelField is "label" by default like in old >Flex

Re: [FlexJS]build_example.xml

2016-11-22 Thread Alex Harui
On 11/22/16, 2:36 AM, "Harbs" wrote: >What is the purpose of these settings in the compilejs target? > > >/> > > It allows the build.xml that calls build_example to set some additional per-example parameters -Alex

Re: [FlexJS]build_example.xml

2016-11-22 Thread Harbs
Yes. I know. But what are those CONFIG settings? The elements are further down. On Nov 22, 2016, at 6:00 PM, Alex Harui wrote: > > On 11/22/16, 2:36 AM, "Harbs" wrote: > >> What is the purpose of these settings in the compilejs target? >> >> >> > /> >> >> > > It

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Josh Tynjala
Perhaps Falcon should have a specific compiler error or warning that says that setters must be public when using [Bindable]. I assume that the current error is kind of generic, so something more specific would help make it clear what's wrong and how to fix it. - Josh On Mon, Nov 21, 2016 at 9:48

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Alex Harui
On 11/22/16, 7:24 AM, "Harbs" wrote: >Please take a look at what I did here. >https://github.com/unhurdle/cep-flexjs/tree/master/CEPTools > >I originally tried building the swc using FDT. I thought there was >something wrong there, so I set up an ant build, and that does not >contain the JS fil

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Harbs
Where do you see it expecting the Flex structure? AFAIU, the compile-js target is only needed for the JS suffixed SWCs. All the regular SWCs have the js in them as well. Am I missing the boat? On Nov 22, 2016, at 6:15 PM, Alex Harui wrote: > > > On 11/22/16, 7:24 AM, "Harbs" wrote: > >> P

Re: [FlexJS] List Structure

2016-11-22 Thread Alex Harui
On 11/22/16, 7:43 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >I tried to extend from SimpleList, but I get the same output (ul -> div >ListDataGroup -> items) >It seems SimpleList extends Listso all complexity is there :? Ugh. SimpleList got ruined in the back port fr

Re: [FlexJS]build_example.xml

2016-11-22 Thread Alex Harui
On 11/22/16, 8:05 AM, "Harbs" wrote: >Yes. I know. But what are those CONFIG settings? They are just dummy values. AFAIK, there is no way in Ant to and another tag at execution time. So the only solution I could think of was to put in lines like: But if you don'

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Alex Harui
On 11/22/16, 8:17 AM, "Harbs" wrote: >Where do you see it expecting the Flex structure? That compile-js will find the JS build in frameworks/js/FlexJS/projects > >AFAIU, the compile-js target is only needed for the JS suffixed SWCs. All >the regular SWCs have the js in them as well. > >Am I m

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Alex Harui
I think it should be possible to generate the right code for [Bindable] so that the setter remains private. But then when the code tries to access the setter without the "private::" namespace you will get a "read-only" error. Regarding Josh's feedback, I'm not sure we should detect a mismatch bet

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Josh Tynjala
If they make the getter public and the setter private, it's probably on purpose. If the compiler then forces the setter to be public for [Bindable], it should at least tell them that something probably unexpected is happening. I think a warning makes sense. [Bindable(eventName)] is definitely the

Re: [FlexJS] MDL List problems

2016-11-22 Thread Carlos Rovira
Alex, I filed the import issue here: https://issues.apache.org/jira/browse/FLEX-35179 Thanks 2016-11-22 16:57 GMT+01:00 Alex Harui : > > > On 11/22/16, 3:16 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" > > wrote: > > >Hi Peter, > > > >another thing I think is "failing" is the fact

Re: [FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
> Ugh. SimpleList got ruined in the back port from JS to AS. > > So maybe I should wait for some fix on this component? > It occurred to me though that both SimpleList and List/ListBase are going > to be oriented towards the "ItemRenderer Factory" API. In such a case, > there is a dataProvider

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Alex Harui
On 11/22/16, 9:26 AM, "Josh Tynjala" wrote: >If they make the getter public and the setter private, it's probably on >purpose. If the compiler then forces the setter to be public for >[Bindable], it should at least tell them that something probably >unexpected >is happening. I think a warning m

Re: [Bindable] and private setters (was Re: [Falcon])

2016-11-22 Thread Josh Tynjala
That works for me. I wonder if we can show a different error if there's a non-public setter. I remember being confused for a bit the first time I saw that error about the property being read-only. - Josh On Tue, Nov 22, 2016 at 10:01 AM, Alex Harui wrote: > > > On 11/22/16, 9:26 AM, "Josh Tynja

Re: [FlexJS]

2016-11-22 Thread Carlos Rovira
> > > So anyway, what should work is in-line xhtml as the value of the html > property. IOW a plain text label should look like the following MXML: > > > > AFAIK, Button (and not js, only mdl) is the only control that allows "text" has default property, but others not... maybe text based contro

Re: [FlexJS] List Structure

2016-11-22 Thread Alex Harui
Well if it were up to me, the Basic List and SimpleList will only support the dataprovider/factory mechanism and not support setting random children. Again, I am trying to make sure the Basic set does not have just-in-case code. I think you've added components that thinly wrap HTML elements so I

Re: [FlexJS]build_example.xml

2016-11-22 Thread Harbs
Ah. That’s fine. I just thought I was missing something basic. Thanks for the explanation. Maybe it would be helpful to put in a comment in case someone else ends up scratching their head like me? On Nov 22, 2016, at 6:31 PM, Alex Harui wrote: > > > On 11/22/16, 8:05 AM, "Harbs" wrote: > >

Re: [FlexJS]missing css

2016-11-22 Thread Alex Harui
On 11/22/16, 2:40 AM, "Harbs" wrote: >There’s not a lot in the project. Please take a look and let me know if >you can spot what’s wrong. I don't know if this is the only problem, but I did find a problem that I should have seen earlier, but I only saw after spending an hour stepping through

Re: [FlexJS]missing css

2016-11-22 Thread Harbs
OMG!!! That was it. Phew! Changing that brought up some (real) errors, and fixing them gave me proper output. I guess the question is why the compiler didn’t give a more intelligent error. Thanks, Harbs On Nov 22, 2016, at 9:19 PM, Alex Harui wrote: > > > On 11/22/16, 2:40 AM, "Harbs" wro

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Harbs
I see. I totally did not understand how it’s working. The js build puts the js files into the swc which is (also?) built by the non-js build. There are two targets there and I’m not sure I understand what they are both doing: compile-js-swc and compile-asjs. It looks like compile-asjs is what p

Re: [FlexJS]missing css

2016-11-22 Thread Alex Harui
On 11/22/16, 11:26 AM, "Harbs" wrote: >OMG!!! I used other acronyms, but it was mostly amusing to me that neither of us saw this. > >I guess the question is why the compiler didn’t give a more intelligent >error. The compiler seems to think it will find errors in the parsing, but not in the

Re: [FlexJS]missing css

2016-11-22 Thread Josh Tynjala
I've been meaning to create a JIRA issue for another MXML parsing issue that I recently discovered. If you have an un-closed XML comment

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Alex Harui
On 11/22/16, 11:04 AM, "Harbs" wrote: >I see. I totally did not understand how it’s working. The js build puts >the js files into the swc which is (also?) built by the non-js build. > >There are two targets there and I’m not sure I understand what they are >both doing: compile-js-swc and compil

Re: [FlexJS]missing css

2016-11-22 Thread Alex Harui
On 11/22/16, 11:54 AM, "Josh Tynjala" wrote: >I've been meaning to create a JIRA issue for another MXML parsing issue >that I recently discovered. > >If you have an un-closed XML comment

Re: [FlexJS]Why is swc missing JS files?

2016-11-22 Thread Harbs
OK. I’ll see if I can get it right… We’ll see tomorrow. Thanks, Harbs On Nov 22, 2016, at 10:06 PM, Alex Harui wrote: > > > On 11/22/16, 11:04 AM, "Harbs" wrote: > >> I see. I totally did not understand how it’s working. The js build puts >> the js files into the swc which is (also?) built

Node problems (was Re: [FlexJS]missing css)

2016-11-22 Thread Harbs
I’m now on to the next issue: I’m getting lots of errors like this: (and by lots, I mean 1300 lines worth of output) I have lots of Node.js code in my project and all the require() statements are output automatically. It seems to me that the variable declarations should be scoped to the file (o

Re: Node problems (was Re: [FlexJS]missing css)

2016-11-22 Thread Josh Tynjala
Yes, I probably should have made those automatically generated require() calls work similarly to "internal" classes that appear after the package block, where they end up being stored statically on the class in the generated JS instead of globally. The redeclared variable warnings should be safe to

Re: Node problems (was Re: [FlexJS]missing css)

2016-11-22 Thread Harbs
There’s a number of different classes of errors I’m getting. Some I believe to be blockers: Redeclared variable constant fs assigned a value more than once variable XML is undeclared variable Buffer is undeclared WARNING: externs/assert.js:142: WARNING - accessing name assert in externs has no e

Re: [FlexJS] List Structure

2016-11-22 Thread piotrz
Let's say that list will be built using components LI, OL - How from the developer point of view use case of such list will look like ? something something For me it is nothing more than HTML, if SimpleList will give me: - This is the simplicity which I love and would like to see. Even if we

Re: [FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
> Well if it were up to me, the Basic List and SimpleList will only support > the dataprovider/factory mechanism and not support setting random > children. But change itemrenderer class factory is something needed, if not we're making the list use cases restricted. > Again, I am trying to make

Re: [FlexJS]missing css

2016-11-22 Thread Carlos Rovira
I saw some of the things reported here of bad closing tags giving some strange errors...thanks that I saw it quickly in my case, but blinded by pursuing my own problems at that moment does not make me think in report this. But it's clear those are errors very visible to people working just few hour

Re: Node problems (was Re: [FlexJS]missing css)

2016-11-22 Thread Josh Tynjala
I'm pretty sure that the "variable XML is undeclared" warning is unrelated to node.swc. I noticed that the globals.js extern was not included in the node.swc, for some reason. It appears to compile fine if I add it, so that was probably just a simple mistake. That should get rid of the issue with

Re: [FlexJS] List Structure

2016-11-22 Thread Alex Harui
I just remembered that there are two kinds of "lists" in HTML. There is the Select element which has a selection model, and then there is ol/ul which has no selection model. What kind of list is MDL's list? Does it support selection? IMO, ol/ul are for displaying a list of items without a selec

Re: [FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
2016-11-22 22:56 GMT+01:00 Alex Harui : > I just remembered that there are two kinds of "lists" in HTML. There is > the Select element which has a selection model, and then there is ol/ul > which has no selection model. What kind of list is MDL's list? Does it > support selection? > > IMO, ol/u

Re: [FlexJS] List Structure

2016-11-22 Thread Alex Harui
On 11/22/16, 4:15 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >2016-11-22 22:56 GMT+01:00 Alex Harui : > >> I just remembered that there are two kinds of "lists" in HTML. There is >> the Select element which has a selection model, and then there is ol/ul >> which has no sel

Re: [FlexJS, MDL] Help with MDL

2016-11-22 Thread piotrz
Hi Carlos, I see that you are hardly working on List and refactoring. :) I think I will take another component and it will be Chips. What do you think - To have one basic Chips and other things like DeletableChips and ContactChips would be a Beads? What do you think ? Piotr

Re: [FlexJS] List Structure

2016-11-22 Thread Carlos Rovira
Hi Alex, That would be ok, but I would like to provide data in flex way vía data provider, since is the way we have to populate List in Flex... Is like other components I introduce yesterday. I marked here : https://cwiki.apache.org/confluence/display/FLEX/Table+Of+Components to redactor and provi