[GitHub] flex-asjs pull request #10: Binary data improvement

2016-07-22 Thread greg-dove
GitHub user greg-dove opened a pull request: https://github.com/apache/flex-asjs/pull/10 Binary data improvement As discussed with Harbs, this is my effort to get BinaryData closer to the regular flash ByteArray, particularly in terms of getting close to the IDataInput and IDataOut

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread Harbs
Github user Harbs commented on the issue: https://github.com/apache/flex-asjs/pull/10 I gave this a quick look-over. The only issue that I noticed was that the default behavior of Endianess is different between Flash and JS. In Flash, the default is bin endian, while in JS, th

FlexJS Graphics Text fill

2016-07-22 Thread Harbs
This one is for Peter. It looks like the text color was being taken from the stroke setting of the element. This does not seem correct to me. For Text, I changed it to use fill and for GraphicsContainer (now CompoundGraphic), I added a textColor property. Is this going to cause problems with gr

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread adufilie
Github user adufilie commented on the issue: https://github.com/apache/flex-asjs/pull/10 The default should be big endian ("network byte order") used by java and flash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: FlexJS Graphics Text fill

2016-07-22 Thread Peter Ent
Hi, It might but I can fix that I believe. I recall having the SVG text looking too full, but maybe if I set it with no file and stroke only it would be fine. I think text should be rendered with stroke and fill, optimally. ‹peter On 7/22/16, 7:15 AM, "Harbs" wrote: >This one is for Peter. > >

Re: FlexJS Graphics Text fill

2016-07-22 Thread Harbs
Flash does not support stroked text, so to get the same output on both platforms, the text should not be stroked. It would be good to support text strokes as well for full svg (and canvas) support, but that should probably be its own property. To be clear, Text objects will still have the same

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread Harbs
Github user Harbs commented on the issue: https://github.com/apache/flex-asjs/pull/10 The thing is: Endianness based on the hardware was done for a reason: http://calculist.org/blog/2012/04/24/the-little-endian-web/ Basically, if the data is being used for GPU drawing, it n

[GitHub] flex-utilities issue #8: Correctly locate SCRIPT_HOME even when scripts are ...

2016-07-22 Thread adufilie
Github user adufilie commented on the issue: https://github.com/apache/flex-utilities/pull/8 We've verified that the changes to work on OS10, Linux, and Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread aharui
Github user aharui commented on the issue: https://github.com/apache/flex-asjs/pull/10 Someday, we can have a BinaryDataForGPU class with native defaults. Or make more classes like BinaryDataLittleEndian and BinaryDataBigEndian. No need to figure it out all in a single class. ---

[GitHub] flex-utilities pull request #8: Correctly locate SCRIPT_HOME even when scrip...

2016-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flex-utilities/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread adufilie
Github user adufilie commented on the issue: https://github.com/apache/flex-asjs/pull/10 Thanks for the link, Harbs. I mistakenly thought this code was only related to ByteArray. Now I see that it's actually writing to an ArrayBuffer in JavaScript. --- If your project is set up for

Re: [GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread Greg Dove
Harbs, FYI the changes I made do not alter the behavior that was there originally, but they do provide the user with more information, and also retain the optimal code path after a BinaryData has had an explicit endian value set. Flash continues to default to BIG_ENDIAN as before. I don't actual

[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread greg-dove
Github user greg-dove commented on the issue: https://github.com/apache/flex-asjs/pull/10 I just read back on the other comments, some of which I had missed seeing before my earlier reply. If defaulting to big endian is necessary on js for consistency, that's easy simply by chan

[FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
Just sync'd flex-asjs repo. Must have missed the email about it now requiring flex-typedefs. Cloned that and tried to build it using ant: /Users/pent/dev/flex-typedefs/build.xml:52: The following error occurred while executing this line: /Users/pent/dev/flex-typedefs/js/build.xml:29: src '/Us

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Alex Harui
Did you switch to the develop branch in flex-typedefs? If you used the standard folder naming and structure, the scripts should find it. You may need to sync and build flex-falcon first. -Alex On 7/22/16, 12:13 PM, "Peter Ent" wrote: >Just sync'd flex-asjs repo. Must have missed the email abo

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
OK, thanks. On 7/22/16, 3:44 PM, "Alex Harui" wrote: >Did you switch to the develop branch in flex-typedefs? If you used the >standard folder naming and structure, the scripts should find it. You may >need to sync and build flex-falcon first. > >-Alex > >On 7/22/16, 12:13 PM, "Peter Ent" wro

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
No joy. I did switch to develop branch of flex-typedefs. I sync'd with Falcon and did an ant all; that failed so I did a ant wipe-all and then ant all. That fails: download: [get] Getting: https://raw.githubusercontent.com/google/closure-compiler/master/contrib/ex terns/jquery-1.9.js

AW: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Christofer Dutz
Could you eventually give the Maven build a try? Chris Von meinem Samsung Galaxy Smartphone gesendet. Ursprüngliche Nachricht Von: Peter Ent Datum: 22.07.16 22:33 (GMT+01:00) An: dev@flex.apache.org Betreff: Re: [FLEXJS, TYPEDEFS] No joy. I did switch to develop branch of

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
I'll make a note to try it Monday morning (now late afternoon Friday here). ‹peter On 7/22/16, 5:05 PM, "Christofer Dutz" wrote: >Could you eventually give the Maven build a try? > >Chris > > > >Von meinem Samsung Galaxy Smartphone gesendet. > > > Ursprüngliche Nachricht >Von:

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Alex Harui
I just did ant wipe-all and ant all in Falcon and it worked for me. Did you run 'ant wipe' in flex-typedefs after switching to the develop branch? Since that was the repo that was on the wrong branch it might have some cruft in it that is messing up the flex-falcon build. -Alex On 7/22/16, 1:33