Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Erik de Bruin
Harbs, When I ran the tests with Java 1.8 on my Mac (Yosemite), I still see failures: ... [flexunit] Suite: UnitTest.Tests.GeneralFunctionsTest [flexunit] Tests run: 36, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.603 sec ... [flexunit] Suite: UnitTest.Tests.ContainerAttributeTest [flexun

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modif

2015-01-02 Thread Erik de Bruin
Done. Thanks for your contribution! EdB On Wed, Dec 31, 2014 at 2:00 PM, Kessler CTR Mark J wrote: > Lol, thanks. > > -Mark > > -Original Message- > From: Erik de Bruin [mailto:e...@ixsoftware.nl] > Sent: Wednesday, December 31, 2014 7:47 AM > To: dev@flex.apache.org > Subject: Re: g

Re: [Mobile] [Mustella] Need help with the Mustella tests

2015-01-02 Thread Erik de Bruin
Om, Between RC mobile builds 72 and 73 the number of failing tests jumped from 41 to 135... The only change between those builds was: [bigosmallm] Add non iOS7/Android skinclass and bring back old BusyIndicator behavior - to fix Mustella tests Are you sure that 'fix' didn't break more stuff than

Re: flex-sdk_mustella - Build # 1319 - Still Failing!

2015-01-02 Thread Erik de Bruin
I've rebooted the VM (again). I also disabled the 'regular' runs, to give the RC runs a bit more attention. I 'reset' these runs by removing the versions.txt file, so all suites should run on 'known good' FP/AIR combinations (some were stuck on the 16/16beta combo, but that's likely coincidence).

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread piotrz
Harbs, This is another huge thing which I have to implement in our TLF tests - configuration for every test case. Logic for reading configuration for tests was bind with some UI functionality (It was tree where you could choose which tests should be launched) - I have removed everything and left

[4.14] Notification: release branch closed for regular fixes

2015-01-02 Thread Erik de Bruin
Hello, A heads up: as of today (2015-01-02), the 'release4.14' branch is closed for all regular commits. I will allow only commits for commits aimed at finalizing the release... This means I will accept commits related to: - documentation (licensing etc.) - Mustella failure fixes (mobile and mai

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread piotrz
Erik, I have just tried on Windows with Java 1.8 and I don't have any errors... Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/DISCUSS-Release-Apache-Flex-4-14-0-tp43390p44073.html Sent from the Apach

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Harbs
I’m not seeing any failures, and Jenkins is not reporting any failures either. Which tests are failing for you? On Jan 2, 2015, at 11:55 AM, Erik de Bruin wrote: > Harbs, > > When I ran the tests with Java 1.8 on my Mac (Yosemite), I still see failures: > > ... > [flexunit] Suite: UnitTest.Te

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Erik de Bruin
... [flexunit] Suite: UnitTest.Tests.GeneralFunctionsTest [flexunit] Tests run: 36, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.603 sec ... [flexunit] Suite: UnitTest.Tests.ContainerAttributeTest [flexunit] Tests run: 31, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 170.805 sec ... [fl

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Harbs
A bit further up it says exactly which tests are failing. That’s just the suites. On Jan 2, 2015, at 12:31 PM, Erik de Bruin wrote: > ... > [flexunit] Suite: UnitTest.Tests.GeneralFunctionsTest > [flexunit] Tests run: 36, Failures: 2, Errors: 0, Skipped: 0, Time > elapsed: 3.603 sec > ... > [fl

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Erik de Bruin
Ah, lemme look... Here they are: [flexunit] FlexUnit test paddingBottomTest ([object Object]) in suite UnitTest.Tests.ContainerAttributeTest failed. [flexunit] FlexUnit test arrowUp in suite UnitTest.Tests.GeneralFunctionsTest failed. [flexunit] FlexUnit test arrowDown in suite UnitTest.Tests.Gen

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Erik de Bruin
I see the 'flex-tlf' build is also reporting no issues. So, it must be me, and I didn't see any issues when I use Java 1.6. Let's leave it at that, and go back to stabilizing the release branch and get 4.14 out the door. Thanks, EdB On Fri, Jan 2, 2015 at 11:42 AM, Erik de Bruin wrote: > Ah,

Re: [4.14] release status update

2015-01-02 Thread Erik de Bruin
Hi, The release is progressing nicely. I've just 'closed' the release branch for regular fixes. We're now in full stabilization mode, trying to fix the failing Mustella tests, and resolve the licensing issues. I've addressed the status and progress of these issues in their respective threads. Te

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Erik de Bruin
> Java version mentioned in the README is getting a bit long in the tooth. The > README still refers to 1.6, 1.7 and 1.8 have been release and there's a > prerelease of 1.9. What version of JAVA would be suggest people to use? On > OSX compiling with Java 1.8 is significantly faster. All I see

Re: TLF status was: [DISCUSS] Release Apache Flex 4.14.0

2015-01-02 Thread Harbs
I have a feeling there might be a some-times bug here. There seems to be a difference between different machines on arrow behavior which might be why the arrow test is failing for you. Please try the following: Place your cursor in the beginning of a text flow line (it should not matter which o

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Erik de Bruin
>> Then we need to decide whether we want the install scripts to prompt folks >> to accept Saxon or not, and whether we should continue to have folks >> approve OSMF and SWFObject like we currently do. > > We should probably be consistent. If we ask for OSMF we should for Saxon. It > seems clear t

Re: [Mobile] [Mustella] Need help with the Mustella tests

2015-01-02 Thread Erik de Bruin
> Between RC mobile builds 72 and 73 the number of failing tests jumped > from 41 to 135... The only change between those builds was: > > [bigosmallm] Add non iOS7/Android skinclass and bring back old > BusyIndicator behavior - to fix Mustella tests > > Are you sure that 'fix' didn't break more stu

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modif

2015-01-02 Thread Mark Kessler
Thanks Erik. -Mark On Fri, Jan 2, 2015 at 4:58 AM, Erik de Bruin wrote: > Done. > > Thanks for your contribution! > > EdB > > > > On Wed, Dec 31, 2014 at 2:00 PM, Kessler CTR Mark J > wrote: > > Lol, thanks. > > > > -Mark > > > > -Original Message- > > From: Erik de Bruin [mailto:e..

[4.14] # Apache Flex SDK 4.14 nightly build 55: Successful

2015-01-02 Thread flex . ci . builds
flex-sdk_release-candidate - Build #55 - Successful Changes since last build: [erik] FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modified the setter to use setGridProperty which allows delayed

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Alex Harui
On 1/2/15, 3:44 AM, "Erik de Bruin" wrote: > >So, if I understand correctly, the current 'consensus' is that there >need to be fixes to LICENSE and NOTICE. Alex has these all but done. >Then there is the issue about the various installer prompts: we either >include a Saxon prompt, or we decide n

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Erik de Bruin
> We cannot bundle Saxon in the binary package because there are classes in > the Saxon jar that haven’t been approved as Apache-compatible. While > other Apache projects “use” Saxon, the first four I looked at don’t appear > to bundle it in their binary packages. At least, I don’t see saxon*.jar

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Alex Harui
On 1/2/15, 11:30 AM, "Erik de Bruin" wrote: >> We cannot bundle Saxon in the binary package because there are classes >>in >> the Saxon jar that haven’t been approved as Apache-compatible. While >> other Apache projects “use” Saxon, the first four I looked at don’t >>appear >> to bundle it in

[FLEXJS] RemoveEventListener

2015-01-02 Thread Alex Harui
Erik (and others). Do we know for sure whether removeEventListener works for FlexJS with goog.bind()? I think I just stepped into it and it didn’t work because for code like this: e.addEventListener(“foo", goog.bind(this.handler, this)); e.removeEventListener(“foo", goog.bind(

[4.14] # Apache Flex SDK 4.14 nightly build 56: Successful

2015-01-02 Thread flex . ci . builds
flex-sdk_release-candidate - Build #56 - Successful Changes since last build: [Alex Harui] add other Batik NOTICE entries for text_html.png [Alex Harui] fix LICENSE and NOTICE in the former Adobe jars [Alex Harui] custom NOTICE for XercesPatch jar [Alex Harui] custom batik NOTICE for Adobe fork

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Justin Mclean
Hi, This is for discussion before I make any changes to the current files after a first pass. They still need a bit of work IMO. I assume LICENSE.bin is appended to LICENSE as part of the build process, this does mean that if you look at the LICENSE.bin in svn it's not correct. Would it be be

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Alex Harui
On 1/2/15, 1:40 PM, "Justin Mclean" wrote: >Hi, > >This is for discussion before I make any changes to the current files >after a first pass. They still need a bit of work IMO. I didn’t expect to get it fully right. I don’t have time to reply to all of these points right now but I will later.

-keep-generated-actionscript error?

2015-01-02 Thread Héctor A
With Flex 4.13 when trying to use -keep-generated-actionscript=true in a Flex Mobile application that uses TabbedNavigatorApplication I get a compilation error: "Type was not found or was not a compile-time constant: ViewNavigatorBase". It seems to work fine with non-mobile Flex applications. Can

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Justin Mclean
Hi, > I don’t have time to reply to all of these points right now but I will later. Once you do I'll make the changes. > I’m not clear most of your suggestions are required.' Correct not everything there is a licensing error but there several that would be IMO release blockers. But as we're ch

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Alex Harui
On 1/2/15, 4:16 PM, "Justin Mclean" wrote: >>I’m not clear most of your suggestions are required.' > >Correct not everything there is a licensing error but there several that >would be IMO release blockers. Which ones in your opinion are release blockers? IMO, the rest aren’t worth the energy.

Re: -keep-generated-actionscript error?

2015-01-02 Thread Alex Harui
Are you trying to compile the generated ActionScript? Or does this happen during the compile only if you turn on that flag? On 1/2/15, 3:23 PM, "Héctor A" wrote: >With Flex 4.13 when trying to use -keep-generated-actionscript=true in a >Flex Mobile application that uses TabbedNavigatorApplicatio

Re: [4.14] binary vs. source package legal docs

2015-01-02 Thread Alex Harui
After reading your notes and reviewing the links, I’m not sure I’m that far off from being “good enough”. My goal is to make the fewest and easiest changes possible to get us into compliance, so I opted for copying entire NOTICE files instead of picking apart pieces of it, leveraging the build scr