I just couldn't let it go, so I did some more digging. From the sept.
17 2012 release notes [1]: "- Updated library dependencies (like
Guava)". This means that a version of the compiler from before that
release shouldn't have any problems with the old Guava. I changed the
'compiler.jx/download.xml'
Sorry, didn't see your comment as it fell in the "commits" directory.
Yes, I will put them in static vars
-Message d'origine-
De : Alex Harui [mailto:aha...@adobe.com]
Envoyé : samedi 2 novembre 2013 04:54
À : dev@flex.apache.org; comm...@flex.apache.org
Objet : Re: [1/2] git commit: [f
Hi,
Can you give a little more detail about this change and why you made it? What
exactly is the "new" MXML codegen? How does performance compare before and
after these changes?
Updating the Release notes would also be nice.
Thanks,
Justin
Hi,
Also why this?
+ protected function addMXMLChildren(comps:Array):void
+ {
+ }
Justin
Yeah, sorry. This is all for Falcon. Doesn't affect MXMLC SWFs at all.
The initial code paths went in in 4.10 I think. Unless I made a mistake
there should only be one null check per UIComponent instance that MXMLC
SWFs will see.
-Alex
On 11/2/13 4:09 PM, "Justin Mclean" wrote:
>Hi,
>
>Can
On 11/2/13 4:11 PM, "Justin Mclean" wrote:
>Hi,
>
>Also why this?
>+ protected function addMXMLChildren(comps:Array):void
>+ {
>+ }
Forgot to clean that up. I'm going to try to re-factor this code into a
common utility class soon. Variants are now in at least three places.
-Al
Hi,
> Yeah, sorry. This is all for Falcon. Doesn't affect MXMLC SWFs at all.
Are you 100% sure? I'm not sure and not looked at the code closely but it looks
like more than a null check to me.
Looks like there quite a few changes in there and there a couple of things that
look a little odd at
Well, the changes you copied into this thread I think are all in Falcon
java files aren't they? The code checked into the SDK should be gated by
that one null check and some generated code from Falcon.
And the net is that Falcon generated the new codegen and BasicTests
passed. I'm now debugging
