Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
> waitEvent="updateComplete" waitTarget="myNumericStepper" /> >> >> > value="-3" waitEvent="updateComplete" waitTarget="myNumericStepper" /> >> >> >> >> >> >> > waitTar

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
'origine- From: Harbs Sent: Sunday, April 07, 2013 4:59 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN Yeah. Easy if you know what you're looking at. To me it looks like a bit of meaningless xml… :P I have a lot o

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
wrote: > >> One more point, none of the Mustella tests for the Mx and the Spark >> NumericStepper have the use case of the NaN, it would be nice to add this >> case and make them consistent, what do you think ? >> >> -Fred >> >> -Message d'

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
s worth :) > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 4:37 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > I just used the test app with mx:NumericStepper

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
e of NaN but it never happen because the checkValidValue reset it the old value in case of NaN, it means the Spart one and the Mx one are not consistent, the Mx one doesn’t allows the value to be set with NaN, is this the right answer to apply to the Spark one ? -Fred -Message d'origi

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
l 07, 2013 4:37 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN I just used the test app with mx:NumericStepper, and it's reverted to 0 when setting it to NaN. So it looks like the behavior is now equivalent. Note. It'

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
the opposite of the bad > one, you can then work on. > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 2:08 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN >

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
one are not > consistent, the Mx one doesn’t allows the value to be set with NaN, is this > the right answer to apply to the Spark one ? > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 2:08 PM > To: dev@flex.apache.org > Subject:

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
ght answer > to apply to the Spark one ? > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 2:08 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > Okay.

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
-- From: Harbs Sent: Sunday, April 07, 2013 2:08 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN Okay. Done. I'll set up Mustella when I get a chance… On Apr 7, 2013, at 2:28 PM, Frédéric THOMAS wrote: Yeah, Range al

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN Ok, I just noticed the mx:NumericStepper commitProperties set it to 0 in case of NaN but it never happen because the checkValidValue reset it the old value in case of NaN, it means the Spar

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
the right answer to apply to the Spark one ? -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013 2:08 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN Okay. Done. I'll set up Mustella when I ge

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
#x27;t the good function, I have to fix that, that's a pain. > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 1:21 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
nt: Sunday, April 07, 2013 1:21 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN Yes. nearestValidValue looks like a good place to fix it. The question is, should it be in Range, Spinner (what a funny name for a base class…) or NumericSte

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
> > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 12:39 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > Okay. But I'll have to set up another machine to run Mustella on

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
07, 2013 1:00 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > IMHO, it is more a Spinner thing as the Range doesn’t incr/decr values, so, > it is valid to set it to a NaN value to say that's a meaningles

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
ed > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 12:36 PM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > If 0 is out of range, 0 will be converted to minimum automa

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
ubject: Re: git commit: Added override to set value to ensure it is not set to NaN IMHO, it is more a Spinner thing as the Range doesn’t incr/decr values, so, it is valid to set it to a NaN value to say that's a meaningless value but the incr/decr have currently no code to manage that situat

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
n the Mustella tests to ensure the fix doesn't break them (or eventually you'll need to adapt the tests too). -Fred -Message d'origine- From: Frédéric THOMAS Sent: Sunday, April 07, 2013 11:46 AM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value t

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
you think ? -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013 12:36 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN If 0 is out of range, 0 will be converted to minimum automatically. But you are pr

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
ix doesn't break them (or eventually you'll > need to adapt the tests too). > > -Fred > > -Message d'origine- From: Frédéric THOMAS > Sent: Sunday, April 07, 2013 11:46 AM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set va

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
ewValue)) > newValue = minimum; > > -Fred > > -Message d'origine- From: Harbs > Sent: Sunday, April 07, 2013 11:38 AM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > I thought it was au

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
1:46 AM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN And maybe it can be fixed directly in the Sinner at override public function changeValueByStep(increase:Boolean = true):void -Fred -Message d'origine- From: Frédéric THOMAS

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
1:38 AM To: dev@flex.apache.org Subject: Re: git commit: Added override to set value to ensure it is not set to NaN I thought it was automatically prepended because I created a branch for it. I see that when I deleted the branch, the JIRA number disappeared. Still learning git… ;-) FWIW, it was

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
M To: comm...@flex.apache.org Subject: git commit: Added override to set value to ensure it is not set to NaN Updated Branches: refs/heads/develop 9ec4d1780 -> 53ad8aa03 Added override to set value to ensure it is not set to NaN Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: h

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
: git commit: Added override to set value to ensure it is not set to > NaN > > Updated Branches: > refs/heads/develop 9ec4d1780 -> 53ad8aa03 > > > Added override to set value to ensure it is not set to NaN > > > Project: http://git-wip-us.apache.org/repos/asf

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
: git commit: Added override to set value to ensure it is not set to NaN Updated Branches: refs/heads/develop 9ec4d1780 -> 53ad8aa03 Added override to set value to ensure it is not set to NaN Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.o