Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-13 Thread Alex Harui
I did some more digging. At some point, NumericStepper calls NumberFormatter. I believe there is a bug in that logic because the NumberFormatter does not get created until you hit the up/down buttons. Anyway, the NumberFormatter creates an instance of flash.globalization.NumberFormatter. On Win

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-13 Thread Alex Harui
I'm concerned we're going to break someone's app. Another scenario I thought of was the 50 cent scenario where you set the step size to .5 but want to show 2 digits of cents. Yes, they can fix their apps, but I don't like doing that to people. I think I'll drag out my Windows computer and see wh

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread Justin Mclean
Hi, > Clever idea. I didn't try it but from looking at this diff, I wonder if > it is ok to tie the number of decimal places to the step size. In most cases (that I can think of) it is. It certainly better than what it's currently doing. > Couldn't there be a difference like stepping by whole

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread Alex Harui
Clever idea. I didn't try it but from looking at this diff, I wonder if it is ok to tie the number of decimal places to the step size. Couldn't there be a difference like stepping by whole dollars but wanting to show cents, or maybe starting at some fractional value but stepping by whole integers

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread OmPrakash Muppirala
On Thu, Sep 12, 2013 at 1:59 AM, Justin Mclean wrote: > Hi, > > > I ran the tests under tests/components/NumericStepper. No failures > > reported. > > Think they are the mx ones you want to run: > ./mini_run.sh tests/gumbo/components/NumericStepper > > Ah sorry, got confused. Its 2AM here. I t

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread Justin Mclean
Hi, > I ran the tests under tests/components/NumericStepper. No failures > reported. Think they are the mx ones you want to run: ./mini_run.sh tests/gumbo/components/NumericStepper All pass btw and I've checked the code in. > I see that there is a test_changes.sh script. How would I run that

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread OmPrakash Muppirala
10 and 100 works fine too. I ran the tests under tests/components/NumericStepper. No failures reported. I see that there is a test_changes.sh script. How would I run that? Thanks, Om On Thu, Sep 12, 2013 at 12:52 AM, Justin Mclean wrote: > Hi, > > > I can confirm that the patch works. When

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread Justin Mclean
Hi, > I can confirm that the patch works. When I click on the stepper buttons, > it does not show the decimal point or extra digits. > Also confirmed that if I set stepSize=0.1, the expected behavior works as > well. Could you try a step size of 10 or 100? I tested this here but obviously could

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread OmPrakash Muppirala
I can confirm that the patch works. When I click on the stepper buttons, it does not show the decimal point or extra digits. Also confirmed that if I set stepSize=0.1, the expected behavior works as well. Thanks, Om On Thu, Sep 12, 2013 at 12:01 AM, Justin Mclean wrote: > Hi, > > Thanks, much

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-12 Thread Justin Mclean
Hi, Thanks, much appreciated, and of course I meant NumericStepper not NumericSpinner :-) Justin

Re: Spark NumericSpinner patch to fix extra digits showing

2013-09-11 Thread OmPrakash Muppirala
On it... On Wed, Sep 11, 2013 at 11:24 PM, Justin Mclean wrote: > Hi, > > Someone mind trying out this patch for the spark NumericSpinner? > > diff --git > a/frameworks/projects/spark/src/spark/components/NumericStepper.as > b/frameworks/projects/spark/src/spark/components/NumericStepper.as > in

Spark NumericSpinner patch to fix extra digits showing

2013-09-11 Thread Justin Mclean
Hi, Someone mind trying out this patch for the spark NumericSpinner? diff --git a/frameworks/projects/spark/src/spark/components/NumericStepper.as b/frameworks/projects/spark/src/spark/components/NumericStepper.as index 6a45b32..02d0ebf 100644 --- a/frameworks/projects/spark/src/spark/components