Re: TLF Branch merged back

2017-07-03 Thread Harbs
BTW: Sorry for forgetting to merge Falcon as well and thanks Alex for taking care of it. > On Jul 3, 2017, at 4:41 PM, Harbs wrote: > > I just merged the TLF branch back into develop. > > TLF is still “alpha quality”, so unless you do a LOT of custom work on a > proprietary text engine, it’s

Re: TLF Branch merged back

2017-07-03 Thread piotrz
Hi Harbs, After your merge I see in Maven build [1] some strange things like that [2]. I think it caused by CONFIG::debug It is strange that Maven didn't failed. Could you look into that once you get a chance. [1] https://builds.apache.org/job/FlexJS%20Framework%20(maven)/1020/console [2] http

Re: Feature Branches (was Re: TLF Branch merged back)

2017-07-03 Thread piotrz
Alex, My view is that "jira + branch" is more concrete documentation than discussion on dev list - It could be always wonderful addition. Additionally making some things on feature branches is definitely for committers who are more experience. I would not push such requirements who just join us

Re: Feature Branches (was Re: TLF Branch merged back)

2017-07-03 Thread Alex Harui
Hi Piotr, What is the advantage of this documentation? IMO, we need to get as much work done with the resources we have. Introducing more overhead for the most active committers doesn't help, especially since I don't see a lot of folks switching over to these feature branches to help validate the

Re: Feature Branches (was Re: TLF Branch merged back)

2017-07-03 Thread piotrz
I think pushing any kind of features through "jira + branch" has also some documentation purposes, so even if you not breaking anything it is worth to do this. Second thing if you do exactly same branches for Compiler and typedefs you will have it automatically in Maven build which generally build

Feature Branches (was Re: TLF Branch merged back)

2017-07-03 Thread Harbs
I just looked at what you did there. Makes sense. I think we should have some kind of consensus on what should be done in feature branches and should there be some kind of naming convention for these branches. For example, I’m writing some code for browser and version detection. (Browser bugs R

Re: TLF Branch merged back

2017-07-03 Thread piotrz
Harbs, In case of your TLF my thoughts was always that it would be good if we will have it in develop, cause you are fixing a lot of things not only related to TLF. - Personally I don't have anything against that you are putting all to develop. But if someone is going to do some other feature - i