Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
On 8/26/13 5:42 PM, "Justin Mclean" wrote: >Hi, > >> It is doing the right thing for Java 6, but Java 7 is stricter. >Sure understand that, but as I said looking at the code it seems to do >the right thing ie can return 0,1 or -1 as required, obviously there >something subtle in there. Yes, the

Re: Java 1.7 compiler issue

2013-08-26 Thread Justin Mclean
Hi, > I was able to successfully compile a few test projects using the batches. Thanks for trying that out. Justin

Re: Java 1.7 compiler issue

2013-08-26 Thread Justin Mclean
Hi, > It is doing the right thing for Java 6, but Java 7 is stricter. Sure understand that, but as I said looking at the code it seems to do the right thing ie can return 0,1 or -1 as required, obviously there something subtle in there. It might be this section: CompilationU

Re: Java 1.7 compiler issue

2013-08-26 Thread Mark Kessler
I was able to successfully compile a few test projects using the batches. On Mon, Aug 26, 2013 at 8:18 PM, Mark Kessler wrote: > I've been using Java 1.7 for a while now and haven't had an issues issues > with this one problem. But I call the "mxmlc.bat" instead of "mxmlc" file > directly. I'l

Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
On 8/26/13 5:07 PM, "Justin Mclean" wrote: >Hi, > >The exception points to compare in updateMaps in SwcGroup.java but it >seems to be doing the right thing. > >https://github.com/apache/flex-sdk/blob/e1649ef1a28766647885c7ad2e61bd29a5 >6778a1/modules/compiler/src/java/flex2/compiler/swc/SwcGrou

Re: Java 1.7 compiler issue

2013-08-26 Thread Mark Kessler
I've been using Java 1.7 for a while now and haven't had an issues issues with this one problem. But I call the "mxmlc.bat" instead of "mxmlc" file directly. I'll try the batch changes out and make sure I can still compile with it. -Mark On Mon, Aug 26, 2013 at 8:04 PM, Alex Harui wrote: > >

Re: Java 1.7 compiler issue

2013-08-26 Thread Justin Mclean
Hi, The exception points to compare in updateMaps in SwcGroup.java but it seems to be doing the right thing. https://github.com/apache/flex-sdk/blob/e1649ef1a28766647885c7ad2e61bd29a56778a1/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java Justin

Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
On 8/26/13 5:01 PM, "Mark Kessler" wrote: >Was this an eclipse / FB issue? At least one customer hit it in FB because it calls MXMLC directly (not through the batch or shell scripts. I hit it doing an ANT build or Mustella run or both because I think they also call MXMLC.JAR directly, but it w

Re: Java 1.7 compiler issue

2013-08-26 Thread Mark Kessler
Was this an eclipse / FB issue? -Mark On Mon, Aug 26, 2013 at 7:11 PM, Justin Mclean wrote: > Hi, > > I've just checkin a fix for this and appreciate it if someone could try it > out on Java 1.6/1.7 on windows and confirm that it works. > > https://issues.apache.org/jira/browse/FLEX-33667 > > T

Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
On 8/26/13 4:49 PM, "Justin Mclean" wrote: >Hi, > >> According to SO, the 'right' fix is to change the comparator in the >> compiler code. >Do you know which comparator? Don't know off-hand. I was hoping to figure it out from the stack trace. > > >I had a look at every Collections.sort, Array

Re: Java 1.7 compiler issue

2013-08-26 Thread Justin Mclean
Hi, > According to SO, the 'right' fix is to change the comparator in the > compiler code. Do you know which comparator? I had a look at every Collections.sort, Arrays.sort and new Comparator() call and couldn't see anything obvious (ie no custom comparator or they return 0,1 and -1 as far as

Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
According to SO, the 'right' fix is to change the comparator in the compiler code. I haven't looked into it, but I can try to fix it at some point before we release again, if someone else doesn't beat me to it. On 8/26/13 4:21 PM, "Justin Mclean" wrote: >Hi, > >> I don't think it will work "eve

Re: Java 1.7 compiler issue

2013-08-26 Thread Justin Mclean
Hi, > I don't think it will work "everywhere". Where else would it need to change and can you provide a patch? Thanks, Justin

Re: Java 1.7 compiler issue

2013-08-26 Thread Alex Harui
I don't think it will work "everywhere". The batch and shell scripts are not always used to call MXMLC and COMPC. On 8/26/13 4:11 PM, "Justin Mclean" wrote: >Hi, > >I've just checkin a fix for this and appreciate it if someone could try >it out on Java 1.6/1.7 on windows and confirm that it wor