Re: FlexJS build broken

2014-02-28 Thread Carlos Rovira
Thanks Erik, just tested the fix I compilation was successful :) C. 2014-02-28 8:54 GMT+01:00 Erik de Bruin : > Ah, as to why I didn't get the error in the first place: I ran ant on a > specific example, not the ant in root. I guess the example ants don't lint. > > EdB > > > > > On Fri, Feb 28,

Re: FlexJS build broken

2014-02-28 Thread Erik de Bruin
No, technically you are correct. I was working on the SDK using the example, changing both and then running the ant for the example. Anyway, next time I'll remember to run the uber-ant before committing. EdB On Fri, Feb 28, 2014 at 3:37 PM, Alex Harui wrote: > > > On 2/27/14 11:54 PM, "Erik

Re: FlexJS build broken

2014-02-28 Thread Alex Harui
On 2/27/14 11:54 PM, "Erik de Bruin" wrote: >Ah, as to why I didn't get the error in the first place: I ran ant on a >specific example, not the ant in root. I guess the example ants don't >lint. In theory, there is no JS to lint in the examples folder because all of it is generated? Or should

Re: FlexJS build broken

2014-02-27 Thread Erik de Bruin
Ah, as to why I didn't get the error in the first place: I ran ant on a specific example, not the ant in root. I guess the example ants don't lint. EdB On Fri, Feb 28, 2014 at 8:53 AM, Erik de Bruin wrote: > Ok, I've made the error go away ;-) > > EdB > > > > > On Fri, Feb 28, 2014 at 8:35 A

Re: FlexJS build broken

2014-02-27 Thread Erik de Bruin
Ok, I've made the error go away ;-) EdB On Fri, Feb 28, 2014 at 8:35 AM, Erik de Bruin wrote: > Hi Carlos, > > Thank you for your patience. You were right to hold off on that 'fix'. I > specifically didn't use dot notation for these properties because that > would allow the Closure Compiler

Re: FlexJS build broken

2014-02-27 Thread Erik de Bruin
Hi Carlos, Thank you for your patience. You were right to hold off on that 'fix'. I specifically didn't use dot notation for these properties because that would allow the Closure Compiler to rename them. Since these properties are called from outside code, we don't want that to happen. I could've

Re: FlexJS build broken

2014-02-27 Thread Carlos Rovira
Hi Alex, Erik change from dot notation so I prefer wait since I don't know the motivations behind Thanks El viernes, 28 de febrero de 2014, Alex Harui escribió: > Might want to wait for Erik, but why not just use dot notation there? > > It is puzzling if he didn't get these same errors. > > -Al

Re: FlexJS build broken

2014-02-27 Thread Alex Harui
Might want to wait for Erik, but why not just use dot notation there? It is puzzling if he didn't get these same errors. -Alex On 2/27/14 3:25 PM, "Carlos Rovira" wrote: >Hi, > >after clean and build falcon and then asks with the last updates I had >build broken due to spaces in js comments...